Skip to content

NO-ISSUE: Revert "OCPBUGS-59723: Add mechanism to delete MCN v1alpha1 CRD in 4.16+ clusters"#5237

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
djoshy:revert-5215-delete-old-mcn-crd
Aug 11, 2025
Merged

NO-ISSUE: Revert "OCPBUGS-59723: Add mechanism to delete MCN v1alpha1 CRD in 4.16+ clusters"#5237
openshift-merge-bot[bot] merged 1 commit intoopenshift:mainfrom
djoshy:revert-5215-delete-old-mcn-crd

Conversation

@djoshy
Copy link
Copy Markdown
Contributor

@djoshy djoshy commented Aug 10, 2025

Reverts #5215; it breaks hypershift conformance tests. This manifest shouldn't be deployed on Hypershift clusters because hosted clusters lack control-plane nodes where the cronjob can be scheduled. Further, Hypershift does not run the MCO operator pod and so https://issues.redhat.com/browse/OCPBUGS-59723 does not apply to Hypershift; the follow-up fix here would be to exclude the manifest on hypershift clusters.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 10, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@djoshy: This pull request references Jira Issue OCPBUGS-59723, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Reverts #5215; it breaks hypershift conformance tests. This manifest shouldn't be deployed on Hypershift clusters because hosted clusters lack control-plane nodes where the cronjob can be scheduled. Further, Hypershift does not run the MCO operator pod and so https://issues.redhat.com/browse/OCPBUGS-59723 does not apply to Hypershift; the follow-up fix here would be to exclude the manifest on hypershift clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@djoshy djoshy changed the title Revert "OCPBUGS-59723: Add mechanism to delete MCN v1alpha1 CRD in 4.16+ clusters" NO-ISSUE: Revert "OCPBUGS-59723: Add mechanism to delete MCN v1alpha1 CRD in 4.16+ clusters" Aug 10, 2025
@openshift-ci-robot openshift-ci-robot removed jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 10, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@djoshy: This pull request explicitly references no jira issue.

Details

In response to this:

Reverts #5215; it breaks hypershift conformance tests. This manifest shouldn't be deployed on Hypershift clusters because hosted clusters lack control-plane nodes where the cronjob can be scheduled. Further, Hypershift does not run the MCO operator pod and so https://issues.redhat.com/browse/OCPBUGS-59723 does not apply to Hypershift; the follow-up fix here would be to exclude the manifest on hypershift clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2025
@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Aug 10, 2025

/test unit

@jianlinliu
Copy link
Copy Markdown

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, jianlinliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jianlinliu
Copy link
Copy Markdown

/override ci/prow/e2e-aws-ovn

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 11, 2025

@jianlinliu: jianlinliu unauthorized: /override is restricted to Repo administrators, approvers in top level OWNERS file, and the following github teams:openshift: openshift-release-oversight openshift-staff-engineers.

Details

In response to this:

/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@pablintino
Copy link
Copy Markdown
Contributor

/override ci/prow/e2e-aws-ovn

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 11, 2025

@pablintino: Overrode contexts on behalf of pablintino: ci/prow/e2e-aws-ovn

Details

In response to this:

/override ci/prow/e2e-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 11, 2025

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change ca8cce4 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-mco-disruptive ca8cce4 link false /test e2e-gcp-mco-disruptive
ci/prow/e2e-azure-ovn-upgrade ca8cce4 link false /test e2e-azure-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn ca8cce4 link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-gcp-op-ocl ca8cce4 link false /test e2e-gcp-op-ocl
ci/prow/e2e-aws-serial ca8cce4 link false /test e2e-aws-serial
ci/prow/e2e-aws-mco-disruptive ca8cce4 link false /test e2e-aws-mco-disruptive

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 9fe5860 into openshift:main Aug 11, 2025
17 of 24 checks passed
@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.20.0-202508110914.p0.g9fe5860.assembly.stream.el9.
All builds following this will include this PR.

@djoshy djoshy deleted the revert-5215-delete-old-mcn-crd branch August 11, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants