Skip to content

OCPBUGS-59723: Reintroduce cronjob that deletes MCN v1alpha1 CRD#5238

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
djoshy:unrevert-mcn-crd
Aug 12, 2025
Merged

OCPBUGS-59723: Reintroduce cronjob that deletes MCN v1alpha1 CRD#5238
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
djoshy:unrevert-mcn-crd

Conversation

@djoshy
Copy link
Copy Markdown
Contributor

@djoshy djoshy commented Aug 10, 2025

This PR adds the cronjob manifest that was removed in #5237. The last commit removes an annotation(include.release.openshift.io/ibm-cloud-managed) and adds an annotation (exclude.release.openshift.io/internal-openshift-hosted). This is how our current MCO deployments are defined, and is what prevents them from being deployed on Hypershift clusters.

@openshift-ci-robot openshift-ci-robot added jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. labels Aug 10, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@djoshy: This pull request references Jira Issue OCPBUGS-59723, which is invalid:

  • expected the bug to be in one of the following states: NEW, ASSIGNED, POST, but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Follow-up to #5237.

The last commit removes an annotation(include.release.openshift.io/ibm-cloud-managed) and adds an annotation (exclude.release.openshift.io/internal-openshift-hosted). This is how our current MCO deployments are defined, and is what prevents them from being deployed on Hypershift clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Aug 10, 2025
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 10, 2025
@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Aug 10, 2025

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Aug 10, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@djoshy: This pull request references Jira Issue OCPBUGS-59723, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.20.0) matches configured target version for branch (4.20.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @sergiordlr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from sergiordlr August 10, 2025 14:08
@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Aug 10, 2025

/payload 4.20 nightly blocking

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 10, 2025

@djoshy: trigger 10 job(s) of type blocking for the nightly release of OCP 4.20

  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-upgrade-ovn-single-node
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-upgrade-fips
  • periodic-ci-openshift-release-master-ci-4.20-e2e-azure-ovn-upgrade
  • periodic-ci-openshift-release-master-ci-4.20-upgrade-from-stable-4.19-e2e-gcp-ovn-rt-upgrade
  • periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-aws-ovn-serial
  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview
  • periodic-ci-openshift-release-master-ci-4.20-e2e-aws-ovn-techpreview-serial
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-bm
  • periodic-ci-openshift-release-master-nightly-4.20-e2e-metal-ipi-ovn-ipv6

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cea39630-75f5-11f0-9b32-db3ae415779b-0

@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Aug 11, 2025

/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 11, 2025

@djoshy: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/cecccf30-769c-11f0-8132-e9b27480046c-0

@pablintino
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 11, 2025
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, pablintino

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Aug 11, 2025

/hold

Hold until we can check payloads are passing

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2025
@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Aug 11, 2025

/cherry-pick release-4.19

@openshift-cherrypick-robot
Copy link
Copy Markdown

@djoshy: once the present PR merges, I will cherry-pick it on top of release-4.19 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@isabella-janssen
Copy link
Copy Markdown
Member

/payload-job periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 11, 2025

@isabella-janssen: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

  • periodic-ci-openshift-hypershift-release-4.20-periodics-e2e-aws-ovn-conformance

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2417d2d0-76b3-11f0-84fd-12b792f169bc-0

@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Aug 11, 2025

Last set of runs look good, we don't have the events failure anymore. Current failures seem to be related to https://issues.redhat.com/browse/OCPBUGS-57658 which is flaking on e2e-aws-ovn payload tests.

@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Aug 11, 2025

/unhold

/retest-required

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 11, 2025
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 9fe5860 and 2 for PR HEAD 38093ce in total

@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Aug 11, 2025

/test e2e-aws-ovn

@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Aug 11, 2025

/retest-required

2 similar comments
@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Aug 11, 2025

/retest-required

@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Aug 11, 2025

/retest-required

@djoshy
Copy link
Copy Markdown
Contributor Author

djoshy commented Aug 12, 2025

/override ci/prow/e2e-aws-ovn

Seems like this test is flaking and we've passed it on this commit before.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 12, 2025

@djoshy: Overrode contexts on behalf of djoshy: ci/prow/e2e-aws-ovn

Details

In response to this:

/override ci/prow/e2e-aws-ovn

Seems like this test is flaking and we've passed it on this commit before.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-ci-robot
Copy link
Copy Markdown
Contributor

/retest-required

Remaining retests: 0 against base HEAD 1b20021 and 2 for PR HEAD 38093ce in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Aug 12, 2025

@djoshy: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-mco-disruptive 38093ce link false /test e2e-gcp-mco-disruptive
ci/prow/e2e-aws-mco-disruptive 38093ce link false /test e2e-aws-mco-disruptive
ci/prow/e2e-azure-ovn-upgrade 38093ce link false /test e2e-azure-ovn-upgrade
ci/prow/okd-scos-e2e-aws-ovn 38093ce link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-azure-ovn-upgrade-out-of-change 38093ce link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-gcp-op-ocl 38093ce link false /test e2e-gcp-op-ocl
ci/prow/e2e-aws-serial 38093ce link false /test e2e-aws-serial

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit 409d01e into openshift:main Aug 12, 2025
17 of 24 checks passed
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

@djoshy: Jira Issue OCPBUGS-59723: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-59723 has been moved to the MODIFIED state.

Details

In response to this:

This PR adds the cronjob manifest that was removed in #5237. The last commit removes an annotation(include.release.openshift.io/ibm-cloud-managed) and adds an annotation (exclude.release.openshift.io/internal-openshift-hosted). This is how our current MCO deployments are defined, and is what prevents them from being deployed on Hypershift clusters.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-cherrypick-robot
Copy link
Copy Markdown

@djoshy: new pull request created: #5243

Details

In response to this:

/cherry-pick release-4.19

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator
This PR has been included in build ose-machine-config-operator-container-v4.20.0-202508121146.p0.g409d01e.assembly.stream.el9.
All builds following this will include this PR.

@djoshy djoshy deleted the unrevert-mcn-crd branch August 15, 2025 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/severity-critical Referenced Jira bug's severity is critical for the branch this PR is targeting. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants