Skip to content

AGENT-1395: IRI followup changes#5562

Merged
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
andfasano:iri-followup-changes
Feb 2, 2026
Merged

AGENT-1395: IRI followup changes#5562
openshift-merge-bot[bot] merged 2 commits intoopenshift:mainfrom
andfasano:iri-followup-changes

Conversation

@andfasano
Copy link
Copy Markdown
Contributor

@andfasano andfasano commented Jan 16, 2026 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jan 16, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 16, 2026 •
edited by openshift-ci Bot
Loading

@andfasano: This pull request references AGENT-1395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did
This patch addresses previous comments:

- How to verify it

- Description for the changelog

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested review from yuqi-zhang and zaneb January 16, 2026 15:16
@andfasano andfasano force-pushed the iri-followup-changes branch from 7fcd593 to 21e6adc Compare January 16, 2026 15:43
@andfasano
Copy link
Copy Markdown
Contributor Author

andfasano commented Jan 19, 2026

/test e2e-hypershift

bfournie
bfournie reviewed Jan 20, 2026
View reviewed changes
Comment thread pkg/controller/internalreleaseimage/internalreleaseimage_controller.go
bfournie
bfournie reviewed Jan 20, 2026
View reviewed changes
Comment thread pkg/controller/internalreleaseimage/internalreleaseimage_controller.go
@bfournie bfournie mentioned this pull request Jan 21, 2026
Merged
@andfasano andfasano force-pushed the iri-followup-changes branch from 21e6adc to d390244 Compare January 23, 2026 08:38
@bfournie
Copy link
Copy Markdown
Contributor

bfournie commented Jan 23, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2026
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2026
@andfasano andfasano force-pushed the iri-followup-changes branch from d390244 to a223cc7 Compare January 23, 2026 15:15
@openshift-ci openshift-ci Bot removed the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2026
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 23, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Jan 23, 2026 •
edited by openshift-ci Bot
Loading

@andfasano: This pull request references AGENT-1395 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

- What I did
This patch addresses previous comments:

It also adds a new unit test for the status update

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@bfournie
Copy link
Copy Markdown
Contributor

bfournie commented Jan 23, 2026

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 23, 2026
@pawanpinjarkar
Copy link
Copy Markdown

pawanpinjarkar commented Jan 23, 2026

/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 23, 2026 •
edited
Loading

@andfasano: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-ocl a223cc7 link false /test e2e-gcp-op-ocl

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@andfasano
Copy link
Copy Markdown
Contributor Author

andfasano commented Jan 29, 2026

/test e2e-gcp-op-single-node

yuqi-zhang
yuqi-zhang approved these changes Feb 1, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@yuqi-zhang yuqi-zhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally lgtm, CI and testing should cover the functionality

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Feb 1, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andfasano, bfournie, pawanpinjarkar, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 1, 2026
@bfournie
Copy link
Copy Markdown
Contributor

bfournie commented Feb 2, 2026

/verified later @andfasano

@openshift-ci-robot openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Feb 2, 2026
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented Feb 2, 2026

@bfournie: This PR has been marked to be verified later by @andfasano.

Details

In response to this:

/verified later @andfasano

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-bot openshift-merge-bot Bot merged commit 43fe37f into openshift:main Feb 2, 2026
8 of 15 checks passed
bfournie pushed a commit to bfournie/machine-config-operator that referenced this pull request Feb 2, 2026
@openshift-merge-bot @bfournie
Merge pull request openshift#5562 from andfasano/iri-followup-changes
45b4f01 
AGENT-1395: IRI followup changes
@bfournie bfournie mentioned this pull request Feb 2, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yuqi-zhang yuqi-zhang yuqi-zhang approved these changes

@zaneb zaneb Awaiting requested review from zaneb

+1 more reviewer

@bfournie bfournie bfournie left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@bfournie bfournie

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. verified Signifies that the PR passed pre-merge verification criteria verified-later

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@andfasano @openshift-ci-robot @bfournie @pawanpinjarkar @yuqi-zhang @openshift-merge-robot