AGENT-1431: Backport InternalReleaseImage support#5610
AGENT-1431: Backport InternalReleaseImage support#5610openshift-merge-bot[bot] merged 8 commits intoopenshift:release-4.21from
Conversation
AGENT-1391: Use TLS cert for the InternalReleaseImage registry
…vice AGENT-1411: Preload the registry image when starting the iri-service
…y-file AGENT-1411: fix IRI registry setup file
AGENT-1424: add initial e2e tests for the InternalReleaseImage controller
openshift-ci-robot
added
the
jira/valid-reference
|
@bfournie: This pull request references AGENT-1431 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
This adds the minimal osimagestream.GetReleasePayloadImage() function needed to support PR openshift#5545 (AGENT-1412 IRI deletion guard) without requiring the full OSImageStream functionality from PR openshift#5476. This is a targeted backport to release-4.21 to enable the IRI deletion guard feature. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
@bfournie: This pull request references AGENT-1431 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
…on-guard AGENT-1412: Prevent deletion of InternalReleaseImage when in use Add ValidatingAdmissionPolicy to block deletion of the InternalReleaseImage singleton resource if any of its release bundles are currently in use by the cluster. This prevents accidental deletion of IRI while the cluster is running a release version that is stored in the InternalReleaseImage resource. The policy checks the ClusterVersion's current version against all release bundle names in the IRI status. If a match is found, deletion is blocked with a clear error message instructing the user to upgrade or downgrade before deletion. This is part of the NoRegistryClusterInstall feature, where deletion of IRI is the default opt-out mechanism, and this guard ensures safe operation. Backported from upstream main with minimal osimagestream package support.
bfournie
force-pushed
the
backport-4.21-batch1
branch
from
d09d108 to
e25b74b
Compare
|
/retest-required |
|
/hold |
openshift-ci
Bot
added
the
do-not-merge/hold
AGENT-1424: Add e2e test for IRI deletion
AGENT-1395: IRI followup changes
|
/unhold |
openshift-ci
Bot
removed
the
do-not-merge/hold
|
@bfournie: This pull request references AGENT-1431 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.0" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
Backports are complete |
yuqi-zhang
left a comment
yuqi-zhang
left a comment
There was a problem hiding this comment.
Did a general pass and the backport seems clean to me. Did not cross-check each PR individually, but hopefully the test/validation can cover that.
Since this is a feature backport via SBAR, I think we may need explicitly acknowledgement and label overrides to get merged.
openshift-ci
Bot
added
the
approved
|
/retest-required |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: bfournie, pawanpinjarkar, yuqi-zhang The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest-required |
1 similar comment
|
/retest-required |
|
/test e2e-hypershift |
|
/verified later @bfournie |
openshift-ci-robot
added
verified-later
verified
|
@bfournie: This PR has been marked to be verified later by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/label backport-risk-assessed Should be safe given it's behind a FG |
openshift-ci
Bot
added
the
backport-risk-assessed
openshift-ci
Bot
assigned
anuragthehatter,
imatza-rh,
lyman9966,
mhanss,
ptalgulk01,
rbbratta,
rioliu-rh,
sergiordlr and
zhaozhanqi
|
Manually setting |
zaneb
added
the
jira/valid-bug
|
@bfournie: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
openshift-merge-bot
Bot
merged commit c3866b2
into
openshift:release-4.21
14 participants
- What I did
This is a backport to add support for the InternalReleaseImage.
The following PRs have been backported:
#5483
#5514
#5543
#5588
#5545 (note that this change also required minimal
changes included for the addition of ClusterVersion in #5476)
#5608
#5562
- Description for the changelog
Backport InternalReleaseImage support