pkg/daemon: fix pending config logic#719
Conversation
openshift-ci-robot
added
the
size/XS
openshift-ci-robot
added
the
approved
runcom
force-pushed
the
fix-logic-pending-config
branch
from
f2b1035 to
fde19b3
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cgwalters, runcom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
| return "", nil | ||
| } | ||
| if entry.BootID == dn.bootID { | ||
| return "", fmt.Errorf("pending config %s bootID %s matches current! Failed to reboot?", entry.Message, dn.bootID) |
There was a problem hiding this comment.
@cgwalters this is a dangerous check that we've been doing over time.... if the MCD is killed before resetting the pending state (irrespective of journal vs ondisk, this is just a bug I guess now), this check is gonna fire and crashloop. Maybe we just need to log this?
There was a problem hiding this comment.
Yeah, this code predated the MCD being a controller.
Dunno. I'm OK changing this to a warning. We could also just leave it as is as the problem goes away with the journal approach.
|
/refresh |
runcom
added
lgtm
|
LGTM - Merging immediately per request from Antonio |
4 participants
we don't need to compare bootid if we have a not pending config...
xref #711