Skip to content

BUG 1703581: templates/master/00-master: bump etcd ETCD_QUOTA_BACKEND_BYTES default to 7GB#720

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
hexfusion:etcd_db_default
May 8, 2019
Merged

BUG 1703581: templates/master/00-master: bump etcd ETCD_QUOTA_BACKEND_BYTES default to 7GB#720
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
hexfusion:etcd_db_default

Conversation

@hexfusion
Copy link
Copy Markdown
Contributor

After conversations with various folks, we have decided to increase the default for ETCD_QUOTA_BACKEND_BYTES to 7516192768 (7GB). The value protects users from uncontrolled growth. If a user deploys a cluster and does not perform proper maintenance procedures such as defragmentation they will hit an NOSPACE alarm. This alarm puts the cluster into a maintenance mode which only allows read and delete.

But this process is disruptive, also we would like to reduce day 2 configuration changes required. This new default will cover most users and also add 1GB protection against runaway clusters. To allow time to plan next steps and create a second cluster.

/cc @jupierce

@openshift-ci-robot openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 8, 2019
@runcom
Copy link
Copy Markdown
Member

runcom commented May 8, 2019

can you rebase to pick #719

@jupierce
Copy link
Copy Markdown
Contributor

jupierce commented May 8, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2019
…t to 7GB.

Signed-off-by: Sam Batschelet <sbatsche@redhat.com>
@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label May 8, 2019
@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

hopefully this passes e2e-upgrade now with the rebase picking up 719.

/approve

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

/approve

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 8, 2019
@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

This is for GA so we'll hold until tomorrow.

/hold

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2019
@eparis
Copy link
Copy Markdown
Member

eparis commented May 8, 2019

/retest

@blomquisg
Copy link
Copy Markdown

blomquisg commented May 8, 2019

This is for GA so we'll hold until tomorrow.

@kikisdeliveryservice GA code freeze is today (May 8th). Should this say, "This is not for GA"? If it holds until tomorrow, it will not be in GA.

@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

/hold cancel

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 8, 2019
@kikisdeliveryservice
Copy link
Copy Markdown
Contributor

re-adding LGTM since @jupierce already LGTM'ed the substance of the PR. only change since then was a rebase to pick up 719 to pass e2e.

all tests pass now.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label May 8, 2019
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hexfusion, jupierce, kikisdeliveryservice

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kikisdeliveryservice]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@hexfusion
Copy link
Copy Markdown
Contributor Author

hexfusion commented May 8, 2019

\moonwalk

jeez... prow hates MJ I guess.

@hexfusion
Copy link
Copy Markdown
Contributor Author

this passed all tests FTR

@openshift-merge-robot openshift-merge-robot merged commit d2af1aa into openshift:master May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants