disable ingress-ip controller as we are not allowing configuration of IngressIPNetworkCIDR

[atiratree]

external IPs on services should be assigned manually and not automatically in microshift

followup to #1011 (comment) conversation

[atiratree]

@dhellmann @zshi-redhat

[openshift-ci]

@atiratree: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[dhellmann]

So we don't need this controller because we are going to require users to set IPs on services themselves? I assume that only applies in the case where they want an IP other than the default one for the cluster?

[mangelajo]

/approve

[atiratree]

So we don't need this controller because we are going to require users to set IPs on services themselves? I assume that only applies in the case where they want an IP other than the default one for the cluster?

Yes, applies only to LoadBalancer services that need an external ingress IP set

[dhellmann]

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, dhellmann, mangelajo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [dhellmann,mangelajo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment