Skip to content

Revert reverted e2e changes for MicroShift #27502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
ingvagabund wants to merge 5 commits into from
Closed

Revert reverted e2e changes for MicroShift #27502

ingvagabund wants to merge 5 commits into from

Conversation

@ingvagabund
Copy link
Member

@ingvagabund ingvagabund commented Oct 30, 2022

Reverted by #27499

@openshift-ci openshift-ci bot requested review from bparees and knobunc October 30, 2022 17:05
@ingvagabund
Copy link
Member Author

ingvagabund commented Oct 30, 2022

/cc @pacevedom @pmtk

@openshift-ci openshift-ci bot requested review from pacevedom and pmtk October 30, 2022 17:14
@ingvagabund
Copy link
Member Author

ingvagabund commented Oct 30, 2022

error: unable to create a release: operator "cluster-capi-operator" contained an invalid image-references file: no input image tag named "ibmcloud-cluster-api-controllers"

@ingvagabund
Copy link
Member Author

ingvagabund commented Oct 30, 2022

/retest

1 similar comment
@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 1, 2022

/retest

@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 1, 2022

/retest-required

1 similar comment
@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 1, 2022

/retest-required

@mfojtik
Copy link
Contributor

mfojtik commented Nov 2, 2022

/lgtm

@openshift-ci openshift-ci bot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 2, 2022
@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 3, 2022

/retest-required

@ingvagabund ingvagabund force-pushed the revert-reverted-e2e-changes branch from 9401618 to c114b4b Compare November 4, 2022 12:41
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2022
atiratree
atiratree reviewed Nov 4, 2022
View reviewed changes
test/extended/networking/services.go

InBareMetalIPv4ClusterContext(oc, func() {
It("ensures external auto assign cidr is configured correctly on the cluster [Serial]", func() {
It("ensures external auto assign cidr is configured correctly on the cluster [apigroup:config.openshift.io] [Serial]", func() {
Copy link
Member

@atiratree atiratree Nov 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this group is not present in microshift, right? FYI this test should be skipped there regardless of the groups since we disabled this controller openshift/microshift#1058

Copy link
Member

@atiratree atiratree Nov 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just checked - it is not present

@atiratree
Copy link
Member

atiratree commented Nov 4, 2022

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, ingvagabund, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@pmtk
Copy link
Member

pmtk commented Nov 4, 2022

/retest-required

2 similar comments
@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 5, 2022

/retest-required

@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 5, 2022

/retest-required

@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 5, 2022

@ingvagabund: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openstack-ovn c114b4b link false /test e2e-openstack-ovn
ci/prow/e2e-metal-ipi-ovn-ipv6 c114b4b link false /test e2e-metal-ipi-ovn-ipv6
ci/prow/e2e-aws-ovn-single-node-upgrade c114b4b link false /test e2e-aws-ovn-single-node-upgrade
ci/prow/e2e-metal-ipi-sdn c114b4b link false /test e2e-metal-ipi-sdn
ci/prow/e2e-gcp-ovn-rt-upgrade c114b4b link false /test e2e-gcp-ovn-rt-upgrade
ci/prow/e2e-aws-ovn-single-node-serial c114b4b link false /test e2e-aws-ovn-single-node-serial
ci/prow/e2e-gcp-ovn-image-ecosystem c114b4b link true /test e2e-gcp-ovn-image-ecosystem

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 5, 2022 •
edited
Loading

Both [sig-devex][Feature:ImageEcosystem][mysql][Slow] openshift mysql image Creating from a template should instantiate the template [apigroup:apps.openshift.io] and [sig-devex][Feature:ImageEcosystem][mariadb][Slow] openshift mariadb image Creating from a template should instantiate the template [apigroup:image.openshift.io][apigroup:operator.openshift.io][apigroup:config.openshift.io][apigroup:apps.openshift.io] are repeatedly failing in other PRs as well:

Based on https://prow.ci.openshift.org/pr-history/?org=openshift&repo=origin&pr=27502 it looks like e2e-gcp-ovn-image-ecosystem started running just recently. The job got enabled in openshift/release#33550.

@pmtk pmtk mentioned this pull request Nov 7, 2022
Merged
@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 7, 2022

Waiting for #27529 to merge

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 7, 2022
@openshift-merge-robot
Copy link
Contributor

openshift-merge-robot commented Nov 7, 2022

@ingvagabund: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pmtk pmtk mentioned this pull request Nov 10, 2022
Merged
@ingvagabund
Copy link
Member Author

ingvagabund commented Nov 11, 2022

Merged through #27540.

@ingvagabund ingvagabund deleted the revert-reverted-e2e-changes branch November 11, 2022 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@knobunc knobunc Awaiting requested review from knobunc

@pacevedom pacevedom Awaiting requested review from pacevedom

@pmtk pmtk Awaiting requested review from pmtk

1 more reviewer

@atiratree atiratree atiratree left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@mfojtik mfojtik

@atiratree atiratree

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@ingvagabund @mfojtik @atiratree @pmtk @openshift-merge-robot @pacevedom