Skip to content

Conversation

@jluhrsen
Copy link
Contributor

fix test flake that checks if the job name matches the running CNI, which is ovnk in 4.12+

jobs were found using this search:

❯ w3m -dump -cols 200
"https://search.ci.openshift.org/?maxAge=96h&type=junit&search=job+name.*does+not+have+network+type+in+name.*expected.*ovn" | sed -n 's/^([^ ]*) .failures match./\1/p' | grep -v rehearse | rg 'origin-master'
pull-ci-openshift-origin-master-e2e-gcp-builds
pull-ci-openshift-origin-master-e2e-aws-upgrade
pull-ci-openshift-origin-master-e2e-aws-image-registry pull-ci-openshift-origin-master-e2e-gcp-image-ecosystem

Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com

@openshift-ci openshift-ci bot requested review from bparees and deads2k October 27, 2022 17:31
@jluhrsen
Copy link
Contributor Author

/retest

@jluhrsen
Copy link
Contributor Author

fix test flake that checks if the job name matches the running CNI,
which is ovnk in 4.12+

jobs were found using this search:

❯ w3m -dump -cols 200
"https://search.ci.openshift.org/?maxAge=96h&type=junit&search=job+name.*does+not+have+network+type+in+name.*expected.*ovn"
| sed -n 's/^\([^ ]*\) .*failures match.*/\1/p' | grep -v rehearse | rg
'origin-master'
pull-ci-openshift-origin-master-e2e-gcp-builds
pull-ci-openshift-origin-master-e2e-aws-upgrade
pull-ci-openshift-origin-master-e2e-aws-image-registry
pull-ci-openshift-origin-master-e2e-gcp-image-ecosystem

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen
Copy link
Contributor Author

jluhrsen commented Nov 3, 2022

/test pj-rehearse

1 similar comment
@jluhrsen
Copy link
Contributor Author

jluhrsen commented Nov 4, 2022

/test pj-rehearse

@jluhrsen
Copy link
Contributor Author

jluhrsen commented Nov 4, 2022

this is ready. if you click through all the rehearsals here to find jobs that didn't fail at install, you can verify that the
flake this PR fixes is working.

@bparees
Copy link
Contributor

bparees commented Nov 4, 2022

/lgtm
/approve

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bparees, jluhrsen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2022

@jluhrsen: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/rehearse/openshift/origin/master/e2e-gcp-ovn-image-ecosystem 9bcf295 link unknown /test pj-rehearse
ci/rehearse/openshift/origin/release-4.13/e2e-aws-ovn-image-registry 9bcf295 link unknown /test pj-rehearse
ci/rehearse/openshift/origin/release-4.12/e2e-gcp-ovn-image-ecosystem 9bcf295 link unknown /test pj-rehearse
ci/rehearse/openshift/origin/release-4.12/e2e-aws-ovn-image-registry 9bcf295 link unknown /test pj-rehearse
ci/rehearse/openshift/origin/release-4.13/e2e-aws-ovn-upgrade 9bcf295 link unknown /test pj-rehearse
ci/rehearse/openshift/origin/master/e2e-aws-ovn-upgrade 9bcf295 link unknown /test pj-rehearse

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit e0d9b73 into openshift:master Nov 4, 2022
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Nov 4, 2022

@jluhrsen: Updated the following 6 configmaps:

  • ci-operator-master-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-master.yaml using file ci-operator/config/openshift/origin/openshift-origin-master.yaml
  • ci-operator-4.12-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-release-4.12.yaml using file ci-operator/config/openshift/origin/openshift-origin-release-4.12.yaml
  • ci-operator-4.13-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-release-4.13.yaml using file ci-operator/config/openshift/origin/openshift-origin-release-4.13.yaml
  • job-config-master-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-master-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-master-presubmits.yaml
  • job-config-4.12 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-release-4.12-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-release-4.12-presubmits.yaml
  • job-config-4.13 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-origin-release-4.13-presubmits.yaml using file ci-operator/jobs/openshift/origin/openshift-origin-release-4.13-presubmits.yaml
Details

In response to this:

fix test flake that checks if the job name matches the running CNI, which is ovnk in 4.12+

jobs were found using this search:

❯ w3m -dump -cols 200
"https://search.ci.openshift.org/?maxAge=96h&type=junit&search=job+name.*does+not+have+network+type+in+name.*expected.*ovn" | sed -n 's/^([^ ]*) .failures match./\1/p' | grep -v rehearse | rg 'origin-master'
pull-ci-openshift-origin-master-e2e-gcp-builds
pull-ci-openshift-origin-master-e2e-aws-upgrade
pull-ci-openshift-origin-master-e2e-aws-image-registry pull-ci-openshift-origin-master-e2e-gcp-image-ecosystem

Signed-off-by: Jamo Luhrsen jluhrsen@gmail.com

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ingvagabund
Copy link
Member

ascerra pushed a commit to ascerra/release that referenced this pull request Nov 7, 2022
fix test flake that checks if the job name matches the running CNI,
which is ovnk in 4.12+

jobs were found using this search:

❯ w3m -dump -cols 200
"https://search.ci.openshift.org/?maxAge=96h&type=junit&search=job+name.*does+not+have+network+type+in+name.*expected.*ovn"
| sed -n 's/^\([^ ]*\) .*failures match.*/\1/p' | grep -v rehearse | rg
'origin-master'
pull-ci-openshift-origin-master-e2e-gcp-builds
pull-ci-openshift-origin-master-e2e-aws-upgrade
pull-ci-openshift-origin-master-e2e-aws-image-registry
pull-ci-openshift-origin-master-e2e-gcp-image-ecosystem

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>

Signed-off-by: Jamo Luhrsen <jluhrsen@gmail.com>
@jluhrsen jluhrsen deleted the ovn-4-origin branch April 4, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants