Skip to content

OCPBUGS-13221: show the effective config by default#1806

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:OCPBUGS-13221-show-config-default-mode
Jun 5, 2023
Merged

OCPBUGS-13221: show the effective config by default#1806
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:OCPBUGS-13221-show-config-default-mode

Conversation

@dhellmann
Copy link
Copy Markdown
Contributor

@dhellmann dhellmann commented May 16, 2023

Change the default for the mode option to show-config so that the effective
configuration is displayed when no mode is specified and the user has to
ask explicitly for the default values.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 16, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 16, 2023

@dhellmann: This pull request references Jira Issue OCPBUGS-13221, which is invalid:

  • expected the bug to target the "4.14.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Change the default for the mode option to show-config so that the effective
configuration is displayed when no mode is specified and the user has to
ask explicitly for the default values.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label May 16, 2023
@openshift-ci openshift-ci Bot requested review from copejon and ggiguash May 16, 2023 19:28
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 16, 2023
@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented May 16, 2023

/jira refresh

@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented May 16, 2023

/hold

This PR relies on test resources added in #1735

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 16, 2023
@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented May 16, 2023

/test microshift-e2e

It looks like the job timed out downloading the CSI container images.

@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented May 18, 2023

/jira refresh

@dhellmann dhellmann force-pushed the OCPBUGS-13221-show-config-default-mode branch 4 times, most recently from 3da4529 to 90e008d Compare May 25, 2023 16:42
@dhellmann dhellmann force-pushed the OCPBUGS-13221-show-config-default-mode branch from 90e008d to ae93e1a Compare May 26, 2023 12:52
@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented May 26, 2023

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels May 26, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 26, 2023

@dhellmann: This pull request references Jira Issue OCPBUGS-13221, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.14.0) matches configured target version for branch (4.14.0)
  • bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @gangwgr

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested a review from gangwgr May 26, 2023 12:53
@dhellmann dhellmann force-pushed the OCPBUGS-13221-show-config-default-mode branch 2 times, most recently from 4ee3bdf to 155a905 Compare May 26, 2023 19:54
@dhellmann
OCPBUGS-13221: show the effective config by default
7c6c002 
Change the default for the mode option to show-config so that the
effective configuration is displayed when no mode is specified and the
user has to ask explicitly for the default values.
@dhellmann dhellmann force-pushed the OCPBUGS-13221-show-config-default-mode branch from 155a905 to 7c6c002 Compare June 1, 2023 18:21
@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented Jun 1, 2023

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 1, 2023
@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented Jun 2, 2023

/retest-required

1 similar comment
@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented Jun 3, 2023

/retest-required

@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented Jun 4, 2023

/test microshift-e2e-arm
/test e2e-openshift-conformance-reduced-arm

@ggiguash
Copy link
Copy Markdown
Contributor

ggiguash commented Jun 5, 2023

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 5, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jun 5, 2023

@dhellmann: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/microshift-e2e-arm 7c6c002 link false /test microshift-e2e-arm
ci/prow/e2e-openshift-conformance-reduced-arm 7c6c002 link false /test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 80e4dfe into openshift:main Jun 5, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Jun 5, 2023

@dhellmann: Jira Issue OCPBUGS-13221: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-13221 has been moved to the MODIFIED state.

Details

In response to this:

Change the default for the mode option to show-config so that the effective
configuration is displayed when no mode is specified and the user has to
ask explicitly for the default values.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

This was referenced Oct 27, 2025
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@copejon copejon Awaiting requested review from copejon

@ggiguash ggiguash Awaiting requested review from ggiguash

@gangwgr gangwgr Awaiting requested review from gangwgr

Assignees

@ggiguash ggiguash

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@dhellmann @openshift-ci-robot @ggiguash @openshift-merge-robot