USHIFT-1199: add automated tests for etcd memory limit management by dhellmann · Pull Request #1735 · openshift/microshift

dhellmann · 2023-04-29T19:45:38Z

No description provided.

openshift-ci-robot · 2023-04-29T19:45:41Z

@dhellmann: This pull request references USHIFT-1199 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

dhellmann · 2023-04-29T19:46:52Z

/hold

These tests depend on #1734

These tests introduce instability to the overall test run by restarting microshift and not waiting long enough for it to restart.

pacevedom · 2023-05-18T11:28:13Z

/assign @pacevedom

dhellmann · 2023-05-28T17:12:28Z

/retest-required

dhellmann · 2023-05-28T18:51:05Z

/hold

The e2e tests are not running on this PR because only test code is being changed. See openshift/release#39797

dhellmann · 2023-05-29T15:55:58Z

/retest-required

dhellmann · 2023-05-29T15:56:17Z

/hold cancel

dhellmann · 2023-05-29T20:48:56Z

/test microshift-e2e-arm

openshift-ci · 2023-05-30T21:41:53Z

@dhellmann: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm	4aeb19db6ba1e1b8c5ba1528f471e1e0154e713e	link	false	`/test e2e-openshift-conformance-reduced-arm`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

pacevedom · 2023-05-31T20:15:09Z

What do you think about cat /etc/microshift/config.yaml 2>/dev/null || true? This way we can check for rc==0 and avoid mistaking ssh errors for an empty configuration.

If we always return true, we would have to look at the output to see if we got any content. Is that what you mean? I'm not sure when we would have an empty file.

pacevedom · 2023-05-31T21:29:56Z

MicroShift runs as root so it will be able to read anything, isnt it?

It does, but we want to make sure that file is owned by root for security and because that's what we would expect users to do.

pacevedom · 2023-05-31T21:32:50Z

Actually it does work even if not in ostree. You will see an error about not being in an ostree host but thats only cosmetic. Checks run and return codes reflect situation. Needs some refactoring though, as it always expects topolvm to be up, even if there is no lvmd.

I think I tried the script and it exited because I was not on an ostree system. Maybe I was running the wrong one.

pacevedom · 2023-05-31T21:34:33Z

Greenboot tests do this in a different way, will ping you when its up for review. Actually it would benefit from some of the work in this PR.

@pmtk has some "wait" logic in one of his PRs, too. It would be ideal if we could come up with 1 good strong implementation of that.

pacevedom · 2023-05-31T21:38:39Z

This is already covered by sos report, isnt it? It doesnt even matter if the test succeeds or not (it fails here, though). You are going to get a huge output from this, mixed with the other tests/keywords output.

We may want to cut this down, but I found it useful in debugging to see the logs from the process at the time of the command inline. I could make it 20 lines?

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>

pacevedom

Will address comments in further PRs, as the main target of the PR looks good. Merging for progress and lets keep iterating the common functions.
/lgtm

openshift-ci · 2023-06-01T15:33:02Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [dhellmann,pacevedom]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2023

openshift-ci Bot requested review from copejon and pmtk April 29, 2023 19:46

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2023

dhellmann changed the title ~~USHIFT-1199: add automated tests for etcd memory limit management~~ WIP: USHIFT-1199: add automated tests for etcd memory limit management Apr 29, 2023

openshift-ci Bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Apr 29, 2023

dhellmann mentioned this pull request Apr 29, 2023

USHIFT-1119: Add load-balancer Robot Framework test #1708

Merged

dhellmann force-pushed the USHIFT-1199-robot-test-etcd-memory-limit branch from 9c5902e to 9a45753 Compare April 29, 2023 22:10

openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2023

dhellmann force-pushed the USHIFT-1199-robot-test-etcd-memory-limit branch from 9a45753 to 44da87a Compare May 6, 2023 19:53

openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2023

dhellmann force-pushed the USHIFT-1199-robot-test-etcd-memory-limit branch 3 times, most recently from 281b088 to d789ebc Compare May 10, 2023 13:40

dhellmann force-pushed the USHIFT-1199-robot-test-etcd-memory-limit branch from d789ebc to fece1d7 Compare May 16, 2023 19:23

dhellmann mentioned this pull request May 16, 2023

OCPBUGS-13221: show the effective config by default #1806

Merged

openshift-ci Bot assigned pacevedom May 18, 2023

dhellmann force-pushed the USHIFT-1199-robot-test-etcd-memory-limit branch 5 times, most recently from 0b445dd to 151dba5 Compare May 25, 2023 16:14

dhellmann removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 25, 2023

dhellmann changed the title ~~WIP: USHIFT-1199: add automated tests for etcd memory limit management~~ USHIFT-1199: add automated tests for etcd memory limit management May 25, 2023

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 25, 2023

dhellmann force-pushed the USHIFT-1199-robot-test-etcd-memory-limit branch from 151dba5 to 4aeb19d Compare May 25, 2023 16:39

dhellmann force-pushed the USHIFT-1199-robot-test-etcd-memory-limit branch 3 times, most recently from 9547aab to 15ec680 Compare May 26, 2023 19:53

openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2023

openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 29, 2023

dhellmann force-pushed the USHIFT-1199-robot-test-etcd-memory-limit branch 3 times, most recently from 1fb0962 to 32f6a74 Compare May 30, 2023 20:56

dhellmann force-pushed the USHIFT-1199-robot-test-etcd-memory-limit branch from 32f6a74 to fd4901a Compare May 30, 2023 22:58

pacevedom reviewed May 31, 2023

View reviewed changes

USHIFT-1199: add automated tests for etcd memory limit management

8a0c986

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>

dhellmann force-pushed the USHIFT-1199-robot-test-etcd-memory-limit branch from fd4901a to 8a0c986 Compare May 31, 2023 22:48

pacevedom approved these changes Jun 1, 2023

View reviewed changes

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 1, 2023

openshift-merge-robot merged commit 08eae1e into openshift:main Jun 1, 2023

Conversation

dhellmann commented Apr 29, 2023

Uh oh!

openshift-ci-robot commented Apr 29, 2023 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dhellmann commented Apr 29, 2023

Uh oh!

pacevedom commented May 18, 2023

Uh oh!

dhellmann commented May 28, 2023

Uh oh!

dhellmann commented May 28, 2023

Uh oh!

dhellmann commented May 29, 2023

Uh oh!

dhellmann commented May 29, 2023

Uh oh!

dhellmann commented May 29, 2023

Uh oh!

openshift-ci Bot commented May 30, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pacevedom left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci Bot commented Jun 1, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

openshift-ci-robot commented Apr 29, 2023 •

edited by openshift-ci Bot

Loading

openshift-ci Bot commented May 30, 2023 •

edited

Loading