Skip to content

USHIFT-1285: ensure microshift-e2e tests run when test code changes#39797

Merged
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
dhellmann:USHIFT-1285-microshift-e2e-tests-on-test-code-changes
May 29, 2023
Merged

USHIFT-1285: ensure microshift-e2e tests run when test code changes#39797
openshift-merge-robot merged 1 commit intoopenshift:masterfrom
dhellmann:USHIFT-1285-microshift-e2e-tests-on-test-code-changes

Conversation

@dhellmann
Copy link
Copy Markdown
Contributor

No description provided.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 28, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

openshift-ci-robot commented May 28, 2023

@dhellmann: This pull request references USHIFT-1285 which is a valid jira issue.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Copy Markdown
Contributor Author

/assign @pacevedom

@openshift-ci openshift-ci Bot requested review from pacevedom and pmtk May 28, 2023 18:50
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2023
@openshift-ci-robot
Copy link
Copy Markdown
Contributor

[REHEARSALNOTIFIER]
@dhellmann: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-microshift-main-microshift-e2e openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-main-microshift-e2e-arm openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.15-microshift-e2e openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.15-microshift-e2e-arm openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.14-microshift-e2e openshift/microshift presubmit Ci-operator config changed
pull-ci-openshift-microshift-release-4.14-microshift-e2e-arm openshift/microshift presubmit Ci-operator config changed

Prior to this PR being merged, you will need to either run and acknowledge or opt to skip these rehearsals.

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 10 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 20 rehearsals
Comment: /pj-rehearse max to run up to 35 rehearsals
Comment: /pj-rehearse auto-ack to run up to 10 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

Copy link
Copy Markdown
Contributor

@pacevedom pacevedom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 29, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, pacevedom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@dhellmann
Copy link
Copy Markdown
Contributor Author

This changes the condition for running tests so they run on more PRs, but does not change the content or configuration of the tests.

/pj-rehearse ack

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label May 29, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2023

@dhellmann: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit b988e78 into openshift:master May 29, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 29, 2023

@dhellmann: Updated the following 6 configmaps:

  • job-config-4.15 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-microshift-release-4.15-presubmits.yaml using file ci-operator/jobs/openshift/microshift/openshift-microshift-release-4.15-presubmits.yaml
  • ci-operator-main-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-microshift-main.yaml using file ci-operator/config/openshift/microshift/openshift-microshift-main.yaml
  • ci-operator-4.14-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-microshift-release-4.14.yaml using file ci-operator/config/openshift/microshift/openshift-microshift-release-4.14.yaml
  • ci-operator-4.15-configs configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-microshift-release-4.15.yaml using file ci-operator/config/openshift/microshift/openshift-microshift-release-4.15.yaml
  • job-config-main-presubmits configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-microshift-main-presubmits.yaml using file ci-operator/jobs/openshift/microshift/openshift-microshift-main-presubmits.yaml
  • job-config-4.14 configmap in namespace ci at cluster app.ci using the following files:
    • key openshift-microshift-release-4.14-presubmits.yaml using file ci-operator/jobs/openshift/microshift/openshift-microshift-release-4.14-presubmits.yaml
Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants