Skip to content

USHIFT-1284: make test login to microshift host more reliable#1843

Merged
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:USHIFT-1284-fix-rf-login-to-microshift-host
May 31, 2023
Merged

USHIFT-1284: make test login to microshift host more reliable#1843
openshift-merge-robot merged 1 commit intoopenshift:mainfrom
dhellmann:USHIFT-1284-fix-rf-login-to-microshift-host

Conversation

@dhellmann
Copy link
Copy Markdown
Contributor

Use 'Get Varible Value' to see if an ssh key has been provided instead
of looking for the name in all of the variables ourselves.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 26, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 26, 2023

@dhellmann: This pull request references USHIFT-1284 which is a valid jira issue.

Details

In response to this:

Use 'Get Varible Value' to see if an ssh key has been provided instead
of looking for the name in all of the variables ourselves.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann
Copy link
Copy Markdown
Contributor Author

/assign @pacevedom

@openshift-ci openshift-ci Bot requested review from pacevedom and pliurh May 26, 2023 12:50
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 26, 2023
@dhellmann dhellmann force-pushed the USHIFT-1284-fix-rf-login-to-microshift-host branch from a928842 to 47e007a Compare May 26, 2023 19:05
@dhellmann
Copy link
Copy Markdown
Contributor Author

/hold

The e2e tests are not running on this PR because only test code is being changed. See openshift/release#39797

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 28, 2023
@pacevedom
Copy link
Copy Markdown
Contributor

/retest

@dhellmann
Copy link
Copy Markdown
Contributor Author

/hold cancel

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 30, 2023
@ggiguash
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 31, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 31, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, ggiguash

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 31, 2023

@dhellmann: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/microshift-e2e-arm 47e007a link false /test microshift-e2e-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 1e91bde into openshift:main May 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants