Skip to content

USHIFT-1198: add tests for version API#1734

Merged
openshift-merge-robot merged 5 commits intoopenshift:mainfrom
dhellmann:USHIFT-1198-robot-test-version
May 23, 2023
Merged

USHIFT-1198: add tests for version API#1734
openshift-merge-robot merged 5 commits intoopenshift:mainfrom
dhellmann:USHIFT-1198-robot-test-version

Conversation

@dhellmann
Copy link
Copy Markdown
Contributor

@dhellmann dhellmann commented Apr 29, 2023 •
edited
Loading

  • update the way commands are run to return stdout
  • log the remote host used for tests when connecting
  • add shell runner for robot framework tests
  • add tests for version config map and command line output
  • move variable file up one level and make the default an example file
  • update ssh connection so if no key is provided the active agent is used instead

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Apr 29, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented Apr 29, 2023 •
edited by openshift-ci Bot
Loading

@dhellmann: This pull request references USHIFT-1198 which is a valid jira issue.

Details

In response to this:

  • update the way commands are run to return stdout
  • log the remote host used for tests when connecting
  • add shell runner for robot framework tests
  • add tests for version config map and command line output

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot requested review from pliurh and pmtk April 29, 2023 19:04
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 29, 2023
@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented Apr 29, 2023

/hold

This builds on #1708 and should wait for that PR.

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 29, 2023
@dhellmann dhellmann force-pushed the USHIFT-1198-robot-test-version branch 2 times, most recently from 70af76d to 9990937 Compare April 29, 2023 19:30
@dhellmann dhellmann mentioned this pull request Apr 29, 2023
Merged
@dhellmann dhellmann force-pushed the USHIFT-1198-robot-test-version branch from 9990937 to 13ece1f Compare April 29, 2023 22:09
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2023
@dhellmann dhellmann force-pushed the USHIFT-1198-robot-test-version branch from 13ece1f to ed60d86 Compare May 6, 2023 18:41
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 6, 2023
@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented May 6, 2023

/hold cancel
/assign @pacevedom @jogeo

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 6, 2023
@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 6, 2023 •
edited by openshift-ci Bot
Loading

@dhellmann: This pull request references USHIFT-1198 which is a valid jira issue.

Details

In response to this:

  • update the way commands are run to return stdout
  • log the remote host used for tests when connecting
  • add shell runner for robot framework tests
  • add tests for version config map and command line output
  • move variable file up one level and make the default an example file
  • update ssh connection so if no key is provided the active agent is used instead

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@dhellmann dhellmann force-pushed the USHIFT-1198-robot-test-version branch 6 times, most recently from 74305fe to 82de8d1 Compare May 10, 2023 13:39
@dhellmann dhellmann force-pushed the USHIFT-1198-robot-test-version branch from 82de8d1 to 868a350 Compare May 16, 2023 19:23
jogeo
jogeo reviewed May 18, 2023
View reviewed changes
Comment thread test/resources/YAML.py Outdated
Comment thread test/resources/kubeconfig.resource Outdated
Comment thread test/resources/microshift-process.resource Outdated
Comment thread test/resources/microshift-process.resource Outdated
Comment thread test/resources/microshift-process.resource Outdated
Comment thread test/resources/oc.resource Outdated
Comment thread test/resources/systemd.resource Outdated
@ggiguash
Copy link
Copy Markdown
Contributor

ggiguash commented May 18, 2023

/assign @pacevedom

1 similar comment
@pacevedom
Copy link
Copy Markdown
Contributor

pacevedom commented May 18, 2023

/assign @pacevedom

@dhellmann
update the log level to trace
4afef39 
This ensures full return values and assigned values are logged, which
means we need fewer explicit log calls.

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
dhellmann added 2 commits May 18, 2023 10:06
@dhellmann
return stdout from commands run with kubeconfig
a63bfe3 
We will use the output of some commands, so return it.

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann
log stderr in Run With Kubeconfig
7aa09d4 
Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann dhellmann force-pushed the USHIFT-1198-robot-test-version branch 2 times, most recently from 0357849 to b74525e Compare May 18, 2023 14:20
@dhellmann
Copy link
Copy Markdown
Contributor Author

dhellmann commented May 18, 2023

@jogeo Thanks for the review! I think I've responded to all of your feedback.

dhellmann and others added 2 commits May 19, 2023 12:43
@dhellmann
USHIFT-1198: add tests for version API
678b33e 
Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann
move login/logout to suite setup/teardown steps
ffb0966 
Instead of logging into the microshift host each time we need to do
something on that host, login when the test suite starts. This means
most tests already have an open connection. Any tests that will take
action that disrupt that connection are responsible for restoring it.

Signed-off-by: Doug Hellmann <dhellmann@redhat.com>
@dhellmann dhellmann force-pushed the USHIFT-1198-robot-test-version branch from b74525e to ffb0966 Compare May 19, 2023 16:43
@jogeo
Copy link
Copy Markdown
Contributor

jogeo commented May 22, 2023 •
edited
Loading

Thanks for the updates @dhellmann
/lgtm

@jogeo
Copy link
Copy Markdown
Contributor

jogeo commented May 22, 2023

/label lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 22, 2023

@jogeo: The label(s) /label lgtm cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, px-approved, docs-approved, qe-approved, downstream-change-needed, rebase/manual, approved, backport-risk-assessed, bugzilla/invalid-bug, bugzilla/valid-bug, cherry-pick-approved, jira/invalid-bug, jira/valid-bug, staff-eng-approved. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/label lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label May 22, 2023
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 22, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dhellmann, jogeo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot
Copy link
Copy Markdown

openshift-ci-robot commented May 22, 2023

/retest-required

Remaining retests: 0 against base HEAD bac892b and 2 for PR HEAD ffb0966 in total

@jogeo
Copy link
Copy Markdown
Contributor

jogeo commented May 22, 2023

/retest

@ggiguash
Copy link
Copy Markdown
Contributor

ggiguash commented May 23, 2023

/override e2e-openshift-conformance-reduced

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 23, 2023

@ggiguash: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • e2e-openshift-conformance-reduced

Only the following failed contexts/checkruns were expected:

  • ci/prow/e2e-openshift-conformance-reduced
  • ci/prow/e2e-openshift-conformance-reduced-arm
  • ci/prow/images
  • ci/prow/microshift-e2e
  • ci/prow/microshift-e2e-arm
  • ci/prow/test-unit
  • ci/prow/verify
  • pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced
  • pull-ci-openshift-microshift-main-e2e-openshift-conformance-reduced-arm
  • pull-ci-openshift-microshift-main-images
  • pull-ci-openshift-microshift-main-microshift-e2e
  • pull-ci-openshift-microshift-main-microshift-e2e-arm
  • pull-ci-openshift-microshift-main-test-unit
  • pull-ci-openshift-microshift-main-verify
  • tide

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

Details

In response to this:

/override e2e-openshift-conformance-reduced

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ggiguash
Copy link
Copy Markdown
Contributor

ggiguash commented May 23, 2023

/override ci/prow/e2e-openshift-conformance-reduced

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 23, 2023

@ggiguash: Overrode contexts on behalf of ggiguash: ci/prow/e2e-openshift-conformance-reduced

Details

In response to this:

/override ci/prow/e2e-openshift-conformance-reduced

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented May 23, 2023

@dhellmann: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-reduced-arm ffb0966 link false /test e2e-openshift-conformance-reduced-arm

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 038da07 into openshift:main May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pliurh pliurh Awaiting requested review from pliurh

@pmtk pmtk Awaiting requested review from pmtk

1 more reviewer

@jogeo jogeo jogeo left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@jogeo jogeo

@pacevedom pacevedom

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@dhellmann @openshift-ci-robot @ggiguash @pacevedom @jogeo @openshift-merge-robot