USHIFT-1119: Add load-balancer Robot Framework test#1708
USHIFT-1119: Add load-balancer Robot Framework test#1708openshift-merge-robot merged 9 commits intoopenshift:mainfrom
Conversation
openshift-ci-robot
added
the
jira/valid-reference
|
@pacevedom: This pull request references USHIFT-1119 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
Bot
added
the
approved
|
/hold until CI jobs ack |
openshift-ci
Bot
added
the
do-not-merge/hold
There was a problem hiding this comment.
How can I run just 1 test file locally, if that's what I want?
This Makefile might make more sense as a shell script.
There was a problem hiding this comment.
Just supply the file, it is autocompleted because of the $(tests) target.
There was a problem hiding this comment.
I wasn't able to get that to work. I wrote a shell script in #1735
There was a problem hiding this comment.
This 2 step pattern seems like something we're going to use a lot. Is there no Get Temporary Filename keyword? Maybe we should add one to the common resources.
There was a problem hiding this comment.
I wasn't able to get that to work. I wrote a shell script in #1735
| Resource ../resources/kubeconfig.resource | ||
|
|
||
| *** Keywords *** | ||
| Setup Suite |
There was a problem hiding this comment.
I'd like to discuss a "style guide" rule that the suite setup keywords for a test suite be in the file for that test suite, and reuse composable parts. That makes it more obvious what the preconditions are for a test when someone is working on it. Of course, the trade off is that if we need to change the startup logic we have to touch more files, but I'm not sure how often that is likely to happen. I think of it as composition vs. inheritance.
Don't change anything in this PR, but maybe we can talk about it as we evolve the early versions of the tests.
There was a problem hiding this comment.
Was using this PR as some sort of guinea pig to test the CI job. Now that I got that running (meaning junit and such) it contains the bare minimum to run at least one test.
I expect the resource files to undergo massive changes as more tests are added. These are only placeholders to get things going while we acquire more knowledge about the framework.
I am all for composition, so the more primitive-like these files look, the better. We will see if they evolve into more complex functions once we add more tests (it might be that almost all setup/teardown strategies end up being the same).
I would be happy to merge this and then keep modifying it with new test suites.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dhellmann, jogeo, pacevedom The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest |
|
@pacevedom: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
/hold cancel |
openshift-ci
Bot
removed
the
do-not-merge/hold
5 participants
Which issue(s) this PR addresses:
Closes #