Skip to content

WIP: Embedded cluster policy controller#458

Closed
sallyom wants to merge 4 commits into
openshift:mainfrom
sallyom:embedded-cluster-policy-controller
Closed

WIP: Embedded cluster policy controller#458
sallyom wants to merge 4 commits into
openshift:mainfrom
sallyom:embedded-cluster-policy-controller

Conversation

@sallyom
Copy link
Copy Markdown
Contributor

@sallyom sallyom commented Nov 16, 2021 •
edited
Loading

cluster-policy-controller

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 16, 2021

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from sallyom after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot requested review from copejon and rootfs November 16, 2021 16:58
@sallyom sallyom force-pushed the embedded-cluster-policy-controller branch 2 times, most recently from 360426c to caf5b1a Compare November 16, 2021 23:13
@sallyom sallyom force-pushed the embedded-cluster-policy-controller branch 7 times, most recently from afd0e07 to 7b89cf8 Compare December 2, 2021 14:23
@sallyom sallyom changed the title WIP: BROKEN ATM: Embedded cluster policy controller WIP: Embedded cluster policy controller Dec 2, 2021
@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Dec 2, 2021
@sallyom sallyom mentioned this pull request Dec 2, 2021
Closed
@sallyom
cluster-policy-controller
4712c09 
Signed-off-by: Sally O'Malley <somalley@redhat.com>
@sallyom
bump(deps-cluster-policy-controller)
193e7c1 
Signed-off-by: Sally O'Malley <somalley@redhat.com>
@sallyom
TODO: Remove-duplicate metrics
9d27e3c 
Signed-off-by: Sally O'Malley <somalley@redhat.com>
@sallyom
rbac cluster-policy-controller
91cc29c 
Signed-off-by: Sally O'Malley <somalley@redhat.com>
@sallyom sallyom force-pushed the embedded-cluster-policy-controller branch from 7b89cf8 to 91cc29c Compare December 2, 2021 17:30
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Dec 2, 2021

@sallyom: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-openshift-conformance-sig-api-machinery 91cc29c link false /test e2e-openshift-conformance-sig-api-machinery

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sallyom
Copy link
Copy Markdown
Contributor Author

sallyom commented Dec 2, 2021 •
edited
Loading

on 3rd thought, embedded is way wonkier than deployment, I'm closing this in favor of deployment #478

#478 (comment)

@sallyom sallyom closed this Dec 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@copejon copejon Awaiting requested review from copejon

@rootfs rootfs Awaiting requested review from rootfs

Assignees

No one assigned

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sallyom