cluster-policy-controller

[sallyom]

Embedding the cluster-policy-controller requires too much reworking of code, I'm in favor of running cluster-policy-controller as a deployment. This way microshift won't be dependent on changes in openshift/library-go controllercmd code.

Added OpenShift Assets:
namespace-security-allocation-controller-clusterrole
namespace-security-allocation-controller-clusterrolebinding
kube-controller-manager static pod cluster-policy-controller container
RangeAllocations CRD
kube-controller-manager ns

Closes #303

[sallyom]

Note: change in RunClusterPolicyController from 4.8, 4.9 - if we embed, will have to rework when bump to 4.9

release 4.9 cluster-policy-controller Run command: https://github.com/openshift/cluster-policy-controller/blob/release-4.9/pkg/cmd/cluster-policy-controller/policy_controller.go#L18

release 4.8 cluster-policy-controller Run command: https://github.com/openshift/cluster-policy-controller/blob/release-4.8/pkg/cmd/cluster-policy-controller/policy_controller.go#L32

[sallyom]

@fzdarsky it works! I've added a commit to run service-ca deployment w/ NonRoot 1001:1001, same as ocp manifest

      securityContext:
          runAsGroup: 1001
          runAsNonRoot: true
          runAsUser: 1001

See Note in PR description about move of service-ca hostPath volumes to configmap & secret

[sallyom]

/assign @fzdarsky

[openshift-ci]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please ask for approval from fzdarsky after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[mangelajo]

@fzdarsky @sallyom did we decide how we want to go about this?, If we want to go this route we need to build multi-arch images for the cluster-policy-controller, I can handle that, just let me know.

thanks for looking at this sally!

[sallyom]

/retest

[cooktheryan]

/retest

[openshift-bot]

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

[openshift-ci]

@sallyom: PR needs rebase.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[sallyom]

closing, we won't need this & if that changes can reopen