Skip to content

Move into a soft-exit in case of kubelet error #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
mangelajo wants to merge 1 commit into from
Closed

Move into a soft-exit in case of kubelet error #576

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions pkg/node/kubelet.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,8 +158,8 @@ serverTLSBootstrap: false #TODO`)
}

func (s *KubeletServer) Run(ctx context.Context, ready chan<- struct{}, stopped chan<- struct{}) error {

defer close(stopped)

// run readiness check
go func() {
healthcheckStatus := util.RetryInsecureHttpsGet("http://127.0.0.1:10248/healthz")
Expand All @@ -178,10 +178,13 @@ func (s *KubeletServer) Run(ctx context.Context, ready chan<- struct{}, stopped

kubeletDeps, err := kubelet.UnsecuredDependencies(kubeletServer, utilfeature.DefaultFeatureGate)
if err != nil {
klog.Fatalf("Error in fetching depenedencies", err)
klog.Errorf("Error in fetching kubelet depenedencies", err)
Copy link
Copy Markdown
Contributor

@oglok oglok Mar 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a typo in "dependencies"

return err
}

if err := kubelet.Run(ctx, kubeletServer, kubeletDeps, utilfeature.DefaultFeatureGate); err != nil {
klog.Fatalf("Kubelet failed to start", err)
klog.Errorf("Kubelet failed to start", err)
return err
}
return ctx.Err()
}
Expand Down