Move into a soft-exit in case of kubelet error#576
Closed
mangelajo wants to merge 1 commit intoopenshift:mainfrom
Closed
Move into a soft-exit in case of kubelet error#576mangelajo wants to merge 1 commit intoopenshift:mainfrom
mangelajo wants to merge 1 commit intoopenshift:mainfrom
Conversation
Contributor
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Depends-On: openshift#575 Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
mangelajo
force-pushed
the
kubelet-soft-error
branch
from
bac6ab4 to
fa1f3ac
Compare
Contributor
Author
|
/retest |
mangelajo
added
the
do-not-merge/work-in-progress
oglok
reviewed
Mar 11, 2022
| kubeletDeps, err := kubelet.UnsecuredDependencies(kubeletServer, utilfeature.DefaultFeatureGate) | ||
| if err != nil { | ||
| klog.Fatalf("Error in fetching depenedencies", err) | ||
| klog.Errorf("Error in fetching kubelet depenedencies", err) |
Contributor
There was a problem hiding this comment.
There is a typo in "dependencies"
Contributor
Author
|
ciosing this one, as this is covered by the global panic capture |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends-On: #575
Signed-off-by: Miguel Angel Ajo majopela@redhat.com