Skip to content

If a service stops with error request all the other services to stop#575

Merged
fzdarsky merged 1 commit intoopenshift:mainfrom
mangelajo:stop-to-cancel-propagation
Jan 31, 2022
Merged

If a service stops with error request all the other services to stop#575
fzdarsky merged 1 commit intoopenshift:mainfrom
mangelajo:stop-to-cancel-propagation

Conversation

@mangelajo
Copy link
Copy Markdown
Contributor

Related-issue: #556

Signed-off-by: Miguel Angel Ajo majopela@redhat.com

Comment thread pkg/servicemanager/manager.go Outdated
@mangelajo mangelajo force-pushed the stop-to-cancel-propagation branch 3 times, most recently from 76133c2 to d9477fe Compare January 28, 2022 13:49
Comment thread pkg/cmd/run.go Outdated
@mangelajo mangelajo force-pushed the stop-to-cancel-propagation branch 2 times, most recently from 51ad265 to 0372f71 Compare January 28, 2022 13:50
@mangelajo mangelajo requested a review from copejon January 28, 2022 14:08
Comment thread pkg/servicemanager/manager.go Outdated
Comment thread pkg/servicemanager/manager.go Outdated
Comment thread pkg/servicemanager/manager.go Outdated
Comment thread pkg/servicemanager/manager.go Outdated
Related-issue: openshift#556

Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
@mangelajo mangelajo force-pushed the stop-to-cancel-propagation branch from 0372f71 to b43b2ec Compare January 28, 2022 16:31
@mangelajo mangelajo requested a review from fzdarsky January 28, 2022 16:31
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 31, 2022
@fzdarsky
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jan 31, 2022
@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Jan 31, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzdarsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fzdarsky fzdarsky merged commit f7d423d into openshift:main Jan 31, 2022
mangelajo added a commit to mangelajo/microshift that referenced this pull request Mar 9, 2022
Depends-On: openshift#575

Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
mangelajo added a commit to mangelajo/microshift that referenced this pull request Mar 9, 2022
Depends-On: openshift#575

Signed-off-by: Miguel Angel Ajo <majopela@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants