Make kube-api-server to return errors from healthcheck

[mangelajo]

Signed-off-by: Miguel Angel Ajo majopela@redhat.com

[openshift-ci]

@mangelajo: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-rpm-install	bcfc022	link	false	/test e2e-rpm-install

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[fzdarsky]

Had to wrap my head around the various conditions on the error channel, but that makes much sense.

/lgtm

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fzdarsky

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [fzdarsky]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[fzdarsky]

Just noticed that returning an error instead of panicing means the ServiceManager just logs the service as stopped (with error) but MicroShift continues running in an undefined state. Need to either panic on error here or globally.

[copejon]

/retest

[mangelajo]

Just noticed that returning an error instead of panicing means the ServiceManager just logs the service as stopped (with error) but MicroShift continues running in an undefined state. Need to either panic on error here or globally.

Not after #575 , I think it's ok now to move back to LGTM :-)