Bug 1984030: netclass: retrieve interface names and filter before parsing#90
Conversation
We should filter excluded interfaces before parsing the interface details. This change is based on prometheus/procfs#376 Signed-off-by: Jan Fajerski <jfajersk@redhat.com> (cherry picked from commit e656b79)
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
openshift-ci
bot
added
the
approved
|
It might be worth creating a BZ so we can backport it on 4.8 later on (the CPU reduction with the patch is quite important for baremetal machines). |
|
/retitle Bug 1984030: netclass: retrieve interface names and filter before parsing |
openshift-ci
bot
changed the title
|
@jan--f: This pull request references Bugzilla bug 1984030, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker. 3 validation(s) were run on this bug
Requesting review from QA contact: DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci
bot
added
bugzilla/severity-unspecified
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jan--f, simonpasquier The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@jan--f: All pull requests linked via external trackers have merged: Bugzilla bug 1984030 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherry-pick release-4.8 |
|
@simonpasquier: new pull request created: #91 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
[ART PR BUILD NOTIFIER] This PR has been included in build golang-github-prometheus-node_exporter-container-v4.9.0-202311250023.p0.g1ab97f3.assembly.stream for distgit golang-github-prometheus-node_exporter. |
Signed-off-by: Jacob Baungard Hansen <jacobbaungard@redhat.com>
5 participants
This is a cherry-pick of prometheus#2033