Skip to content

Comments

[release-4.8] Bug 1984074: netclass: retrieve interface names and filter before parsing#91

Merged
openshift-ci[bot] merged 2 commits intoopenshift:release-4.8from
openshift-cherrypick-robot:cherry-pick-90-to-release-4.8
Aug 6, 2021
Merged

[release-4.8] Bug 1984074: netclass: retrieve interface names and filter before parsing#91
openshift-ci[bot] merged 2 commits intoopenshift:release-4.8from
openshift-cherrypick-robot:cherry-pick-90-to-release-4.8

Conversation

@openshift-cherrypick-robot

This is an automated cherry-pick of #90

/assign simonpasquier

jan--f added 2 commits July 20, 2021 15:18
We should filter excluded interfaces before parsing the interface
details.
This change is based on prometheus/procfs#376

Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
(cherry picked from commit e656b79)
Signed-off-by: Jan Fajerski <jfajersk@redhat.com>
@openshift-ci
Copy link

openshift-ci bot commented Jul 20, 2021

@openshift-cherrypick-robot: Bugzilla bug 1984030 has been cloned as Bugzilla bug 1984074. Retitling PR to link against new bug.
/retitle [release-4.8] Bug 1984074: netclass: retrieve interface names and filter before parsing

Details

In response to this:

[release-4.8] Bug 1984030: netclass: retrieve interface names and filter before parsing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot changed the title [release-4.8] Bug 1984030: netclass: retrieve interface names and filter before parsing [release-4.8] Bug 1984074: netclass: retrieve interface names and filter before parsing Jul 20, 2021
@openshift-ci openshift-ci bot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. labels Jul 20, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 20, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1984074, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.0) matches configured target release for branch (4.8.0)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1984030 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED)
  • dependent Bugzilla bug 1984030 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @juzhao

Details

In response to this:

[release-4.8] Bug 1984074: netclass: retrieve interface names and filter before parsing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci openshift-ci bot requested a review from juzhao July 20, 2021 15:18
@simonpasquier
Copy link

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jul 21, 2021
@openshift-ci
Copy link

openshift-ci bot commented Jul 21, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, simonpasquier

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 21, 2021
@sdodson
Copy link
Member

sdodson commented Jul 22, 2021

Re-validating bugzilla status after prow config updates.
/bugzilla refresh

@openshift-ci
Copy link

openshift-ci bot commented Jul 22, 2021

@sdodson: This pull request references Bugzilla bug 1984074, which is valid.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.8.z) matches configured target release for branch (4.8.z)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1984030 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1984030 targets the "4.9.0" release, which is one of the valid target releases: 4.9.0
  • bug has dependents

Requesting review from QA contact:
/cc @juzhao

Details

In response to this:

Re-validating bugzilla status after prow config updates.
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link

ecordell commented Aug 4, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: missed cutoff today, may make it tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

1 similar comment
@ecordell
Copy link

ecordell commented Aug 5, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: missed cutoff today, may make it tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@ecordell
Copy link

ecordell commented Aug 5, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: missed cutoff for today, may make tomorrow

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@ecordell
Copy link

ecordell commented Aug 6, 2021

[patch-manager] ⌛ This pull request was not picked by the patch manager for the current z-stream window and have to wait for the next window.

skipped

  • Score: 0.20
  • Reason: skipping for now, may still be tagged today

NOTE: This message was automatically generated, if you have questions please ask on #forum-release

@ecordell
Copy link

ecordell commented Aug 6, 2021

[patch-manager] 🚀 Approved for z-stream by score: 0.20

picked

@ecordell ecordell added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Aug 6, 2021
@openshift-ci openshift-ci bot merged commit 9ad2cf9 into openshift:release-4.8 Aug 6, 2021
@openshift-ci
Copy link

openshift-ci bot commented Aug 6, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1984074 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.8] Bug 1984074: netclass: retrieve interface names and filter before parsing

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build golang-github-prometheus-node_exporter-container-v4.8.0-202311261141.p0.g9ad2cf9.assembly.stream for distgit golang-github-prometheus-node_exporter.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants