Skip to content

fix: CI unit test (envtest version)#1375

Merged
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
mateusoliveira43:fix/envtest-unit-test
Mar 25, 2024
Merged

fix: CI unit test (envtest version)#1375
openshift-merge-bot[bot] merged 1 commit into
openshift:masterfrom
mateusoliveira43:fix/envtest-unit-test

Conversation

@mateusoliveira43
Copy link
Copy Markdown

Why the changes were made

Noted that CI unit-test are breaking. This PR fixes it.

How the changes were made

Checked envtest latest release go.mod file
https://github.com/kubernetes-sigs/controller-runtime/blob/e08b286e313e0642b739c7c9bc1d31d7bb333d2f/tools/setup-envtest/go.mod#L3

Its format is not supported by Go version 1.20 (which is used by CI)

Changed latest to last release with supported go.mod file for Go version 1.20

How to test the changes made

Run make test and check CI logs.

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2024
@mateusoliveira43
Copy link
Copy Markdown
Author

/retest

@kaovilai
Copy link
Copy Markdown
Member

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 25, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,mateusoliveira43,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mateusoliveira43
Copy link
Copy Markdown
Author

/override ci/prow/4.12-e2e-test-aws
/override ci/prow/4.14-e2e-test-azure
restore succeeds, but application not fully working flake

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 25, 2024

@mateusoliveira43: Overrode contexts on behalf of mateusoliveira43: ci/prow/4.12-e2e-test-aws, ci/prow/4.14-e2e-test-azure

Details

In response to this:

/override ci/prow/4.12-e2e-test-aws
/override ci/prow/4.14-e2e-test-azure
restore succeeds, but application not fully working flake

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Mar 25, 2024

@mateusoliveira43: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai
Copy link
Copy Markdown
Member

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Mar 25, 2024
@openshift-merge-bot openshift-merge-bot Bot merged commit 1493a5e into openshift:master Mar 25, 2024
@mateusoliveira43
Copy link
Copy Markdown
Author

/cherry-pick oadp-1.3

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

@mateusoliveira43: new pull request created: #1376

Details

In response to this:

/cherry-pick oadp-1.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shubham-pampattiwar
Copy link
Copy Markdown
Member

/cherry-pick oadp-1.2

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

@shubham-pampattiwar: #1375 failed to apply on top of branch "oadp-1.2":

Applying: fix: CI unit test (envtest version)
Using index info to reconstruct a base tree...
M	Makefile
Falling back to patching base and 3-way merge...
Auto-merging Makefile
CONFLICT (content): Merge conflict in Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: CI unit test (envtest version)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick oadp-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

shubham-pampattiwar pushed a commit to shubham-pampattiwar/oadp-operator that referenced this pull request Apr 10, 2024
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
(cherry picked from commit 1493a5e)
@mpryc
Copy link
Copy Markdown
Contributor

mpryc commented Jun 18, 2024

/cherry-pick oadp-1.0

@openshift-cherrypick-robot
Copy link
Copy Markdown
Contributor

@mpryc: #1375 failed to apply on top of branch "oadp-1.0":

Applying: fix: CI unit test (envtest version)
Using index info to reconstruct a base tree...
M	Makefile
Falling back to patching base and 3-way merge...
Auto-merging Makefile
CONFLICT (content): Merge conflict in Makefile
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: CI unit test (envtest version)
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

Details

In response to this:

/cherry-pick oadp-1.0

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

mpryc pushed a commit to mpryc/oadp-operator that referenced this pull request Jun 18, 2024
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
mpryc pushed a commit to mpryc/oadp-operator that referenced this pull request Jun 18, 2024
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
@mpryc
Copy link
Copy Markdown
Contributor

mpryc commented Jun 18, 2024

Cherry pick for oadp-1.0 #1428

weshayutin pushed a commit that referenced this pull request Jun 18, 2024
Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Co-authored-by: Mateus Oliveira <msouzaol@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. CI lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants