Skip to content

[oadp-1.0] fix: CI unit test (envtest version) (#1375)#1428

Merged
weshayutin merged 1 commit into
openshift:oadp-1.0from
mpryc:oadp-1.0-setuptools
Jun 18, 2024
Merged

[oadp-1.0] fix: CI unit test (envtest version) (#1375)#1428
weshayutin merged 1 commit into
openshift:oadp-1.0from
mpryc:oadp-1.0-setuptools

Conversation

@mpryc
Copy link
Copy Markdown
Contributor

@mpryc mpryc commented Jun 18, 2024

This is a cherry-pick of #1375

Signed-off-by: Mateus Oliveira <msouzaol@redhat.com>
Copy link
Copy Markdown
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit test passed.

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 18, 2024
Copy link
Copy Markdown

@mateusoliveira43 mateusoliveira43 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 18, 2024
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Jun 18, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43, mpryc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mpryc
Copy link
Copy Markdown
Contributor Author

mpryc commented Jun 18, 2024

Can we skip the e2e ? I think those are flakes, and the 1.0 is reworked in another release PR.

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 0d17b48 and 2 for PR HEAD 3f1b72b in total

@weshayutin weshayutin merged commit 8a742f4 into openshift:oadp-1.0 Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants