CI: Add fedora-todolist sample to E2E tests.#1381
Conversation
Signed-off-by: Matthew Arnold <marnold@redhat.com>
Signed-off-by: Matthew Arnold <marnold@redhat.com>
Also rearrange some test code so that the new test case can co-exist with the existing CirrOS test. The CirrOS test will be converted to a real YAML template later, and some of the existing virt helper code will be removed. Signed-off-by: Matthew Arnold <marnold@redhat.com>
openshift-ci
Bot
added
the
approved
|
/test 4.14-e2e-test-kubevirt-aws |
mateusoliveira43
left a comment
mateusoliveira43
left a comment
There was a problem hiding this comment.
I believe would be good to use tiny instead of small fedora image, but it seems to took "only" 20 minutes, so we can use small
Signed-off-by: Matthew Arnold <marnold@redhat.com>
Signed-off-by: Matthew Arnold <marnold@redhat.com>
Signed-off-by: Matthew Arnold <marnold@redhat.com>
Avoids timeouts on VMs that will definitely take a long time, and avoids huge test delays on applications that should not take much time. Signed-off-by: Matthew Arnold <marnold@redhat.com>
Signed-off-by: Matthew Arnold <marnold@redhat.com>
Signed-off-by: Matthew Arnold <marnold@redhat.com>
|
/retest |
mateusoliveira43
left a comment
mateusoliveira43
left a comment
There was a problem hiding this comment.
Since tests are fast (~30min), would be good to add CSI for CirrOS and DataMover for Fedora?
Yes, I will add these. It might have to be another pull request though, I was getting some backup failures with datamover on the Fedora test. Now that there's at least one working test, I can go back and debug it better. |
|
/retest |
|
/retest |
|
@mrnold: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
@mpryc eyes when you have a moment please :) |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mateusoliveira43, mrnold, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
* Add fedora-todolist to sample E2E applications. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Bump up timeouts commonly failing new VM test. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Add test case for fedora-todolist. Also rearrange some test code so that the new test case can co-exist with the existing CirrOS test. The CirrOS test will be converted to a real YAML template later, and some of the existing virt helper code will be removed. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Use tiny flavor for Fedora VM. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Add descriptions to virtualization test entries. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Re-use existing VM status check. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Specify backup timeout for every test. Avoids timeouts on VMs that will definitely take a long time, and avoids huge test delays on applications that should not take much time. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Add TODO for a future cloud-init completion check. Signed-off-by: Matthew Arnold <marnold@redhat.com> * Back off namespace cleanup timeout. Signed-off-by: Matthew Arnold <marnold@redhat.com> --------- Signed-off-by: Matthew Arnold <marnold@redhat.com>
4 participants
Run Wes' fedora-todolist VM from #1363 as a virtualization E2E test.