make bundle and VERSION update - after rebase#1901
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mpryc The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
Bot
added
the
approved
| - velero.io | ||
| resources: | ||
| - '*' | ||
| - backuprepositories |
There was a problem hiding this comment.
The '*' which is one line above should cover the removals.
| - velero.io | ||
| resources: | ||
| - '*' | ||
| - backuprepositories |
There was a problem hiding this comment.
The '*' above should cover all the removals.
| - apiGroups: | ||
| - "" | ||
| resources: | ||
| - persistentvolumerclaims |
There was a problem hiding this comment.
persistentvolumerclaims - I think this could have been mistake
There was a problem hiding this comment.
persistentvolumes is something more problematic as it's not covered by other rbac privs here and I am not sure if we should give that somewhere.
There was a problem hiding this comment.
Those are not present in the oadp-dev branch of oadp-operator directory.
mpryc
force-pushed
the
oadp-1.5-non-admin-manifests
branch
from
f5c8449 to
532a3a3
Compare
|
/test unit-test |
mpryc
force-pushed
the
oadp-1.5-non-admin-manifests
branch
from
532a3a3 to
f61deca
Compare
|
The error in the |
Updated VERSION in the Makefile to 1.5.1 Ran: make bundle Signed-off-by: Michal Pryc <mpryc@redhat.com>
mpryc
force-pushed
the
oadp-1.5-non-admin-manifests
branch
from
f61deca to
377195e
Compare
mpryc
changed the title
|
Note: non-admin-backup has nothing to do with the bundle manifest change. |
|
@mpryc: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
Fixed in #1903 |
1 participant
Updated VERSION in the Makefile to 1.5.1
Ran: make bundle