Skip to content

Fix make bundle repo and ran make bundle#1903

Merged
openshift-merge-bot[bot] merged 2 commits into
openshift:oadp-1.5from
mpryc:oadp-1.5-no-gitmodules
Aug 12, 2025
Merged

Fix make bundle repo and ran make bundle#1903
openshift-merge-bot[bot] merged 2 commits into
openshift:oadp-1.5from
mpryc:oadp-1.5-no-gitmodules

Conversation

@mpryc
Copy link
Copy Markdown
Contributor

@mpryc mpryc commented Aug 12, 2025

  1. Removed .gitmodules and git sub-modules
    Removal of the .gitmodules and git-submodules from the repo as they were causing make bundle to fail.
  2. Ran: make bundle - after rebase

@openshift-ci openshift-ci Bot requested review from kaovilai and mrnold August 12, 2025 16:57
@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 12, 2025
@mpryc
Copy link
Copy Markdown
Contributor Author

mpryc commented Aug 12, 2025

/retest

@mpryc mpryc force-pushed the oadp-1.5-no-gitmodules branch from 06f05d3 to fff5865 Compare August 12, 2025 18:52
mpryc added 2 commits August 12, 2025 21:19
Removal of the .gitmodules and git-submodules
from the repo as they were causing make bundle
to fail.

Signed-off-by: Michal Pryc <mpryc@redhat.com>
Updated VERSION in the Makefile to 1.5.1
Ran: make bundle

Signed-off-by: Michal Pryc <mpryc@redhat.com>
@mpryc mpryc force-pushed the oadp-1.5-no-gitmodules branch from fff5865 to b7689db Compare August 12, 2025 19:21
@mpryc mpryc changed the title DNM: Test ci - removed .gitmodules Fix make bundle repo and ran make bundle Aug 12, 2025
Copy link
Copy Markdown
Contributor

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

Copy link
Copy Markdown
Contributor

@rayfordj rayfordj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Aug 12, 2025
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 12, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mpryc, rayfordj, shubham-pampattiwar, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [kaovilai,mpryc,rayfordj,shubham-pampattiwar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Aug 12, 2025

@mpryc: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot Bot merged commit b4951cb into openshift:oadp-1.5 Aug 12, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants