oadp-1.4: feat: add support for Hypershift plugin in OADP 1.4#1915
Conversation
|
Skipping CI for Draft Pull Request. |
|
OK... pulled this PR and then switched to the oadp-1.5 branch to run HCP e2e tests :) \0/ WORKING! |
|
|
So, the issue is CustomPlugin thing? |
Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
a403eca to
dfad651
Compare
| description: The key of the secret to select from. Must be a valid secret key. | ||
| type: string | ||
| name: | ||
| default: "" |
There was a problem hiding this comment.
Is this change intentional ? (I don't see any change in api that would trigger this update 👀 )
There was a problem hiding this comment.
Unit tests are also failing because of it
There was a problem hiding this comment.
must be the sdk version
There was a problem hiding this comment.
not happening locally yet again :/
There was a problem hiding this comment.
96cd819 to
e8a5e7e
Compare
|
After some investigation, to get the exact bundle unit test is happy about, dev must Alternative is to nuke the dir with submodules similar to #1903. |
…pdate --init --recursive` Signed-off-by: Tiger Kaovilai <tkaovila@redhat.com>
e8a5e7e to
7778497
Compare
shubham-pampattiwar
left a comment
There was a problem hiding this comment.
/lgtm, maybe a small ut would not hurt but non-blocking.
|
@kaovilai: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kaovilai, shubham-pampattiwar, weshayutin The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/LGTM |
Signed-off-by: Tiger Kaovilai tkaovila@redhat.com
Why the changes were made
How to test the changes made