Skip to content

Adding function to verify Backup / Restore data#624

Merged
deepakraj1997 merged 4 commits into
openshift:masterfrom
deepakraj1997:validate_br_with_data
May 2, 2022
Merged

Adding function to verify Backup / Restore data#624
deepakraj1997 merged 4 commits into
openshift:masterfrom
deepakraj1997:validate_br_with_data

Conversation

@deepakraj1997
Copy link
Copy Markdown
Contributor

@deepakraj1997 deepakraj1997 commented Apr 6, 2022 •
edited by kaovilai
Loading

@openshift-ci openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 6, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 6, 2022

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@openshift-ci openshift-ci Bot requested review from mperetzred and rayfordj April 6, 2022 17:08
@weshayutin
Copy link
Copy Markdown
Contributor

weshayutin commented Apr 7, 2022

@deepakraj1997 nice start dude!

@deepakraj1997
Copy link
Copy Markdown
Contributor Author

deepakraj1997 commented Apr 12, 2022

/retest

weshayutin
weshayutin reviewed Apr 20, 2022
View reviewed changes
Comment thread tests/e2e/backup_restore_suite_test.go Outdated

parksAppReady := VerificationFunction(func(ocClient client.Client, namespace string) error {
Eventually(IsDCReady(ocClient, "parks-app", "restify"), timeoutMultiplier*time.Minute*10, time.Second*10).Should(BeTrue())
// err := VerifyBackUpRestoreData(artifact_dir, namespace, "restify", "parks-app") // TODO: VERIFY PARKS APP DATA
Copy link
Copy Markdown
Contributor

@weshayutin weshayutin Apr 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks... looking at the parks app.. the last commit was in 2016. I'm a little suspicious of this app. https://github.com/ryanj/restify-mongodb-parks

Copy link
Copy Markdown
Contributor Author

@deepakraj1997 deepakraj1997 Apr 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I had added the issue in the description although we could verify the data if we add a wait function.

@deepakraj1997 deepakraj1997 marked this pull request as ready for review April 20, 2022 14:46
@openshift-ci openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 20, 2022
@openshift-ci openshift-ci Bot requested a review from jwmatthews April 20, 2022 14:48
@deepakraj1997
Copy link
Copy Markdown
Contributor Author

deepakraj1997 commented Apr 20, 2022

/retest

1 similar comment
@deepakraj1997
Copy link
Copy Markdown
Contributor Author

deepakraj1997 commented Apr 21, 2022

/retest

@weshayutin
Copy link
Copy Markdown
Contributor

weshayutin commented Apr 21, 2022

+1 to making this part of the validation VERY resiliant

kaovilai
kaovilai requested changes Apr 22, 2022
View reviewed changes
Comment thread tests/e2e/lib/apps.go Outdated
return err
}

func VerifyBackUpRestoreData(artifact_dir string, namespace string, routeName string, app string) error {
Copy link
Copy Markdown
Member

@kaovilai kaovilai Apr 6, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func VerifyBackUpRestoreData(artifact_dir string, namespace string, routeName string, app string) error {
func VerifyBackupRestoreData(artifact_dir string, namespace string, routeName string, app string) error {

This was referenced Apr 22, 2022
Closed
Merged
@kaovilai
Copy link
Copy Markdown
Member

kaovilai commented Apr 29, 2022

/retest

@kaovilai kaovilai changed the title Adding function to verify BackUp / Restore data Adding function to verify Backup / Restore data Apr 29, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented Apr 29, 2022

@deepakraj1997: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@deepakraj1997 deepakraj1997 merged commit a5c842e into openshift:master May 2, 2022
kaovilai pushed a commit that referenced this pull request May 3, 2022
@weshayutin
replace the parks-app with todolist on mongo (#649)
dfa7af9 
* created a version of todolist for mongo
* ensure the manifest builds and triggers just like
the parks-app did
* adv is that the same app api can be used to add
data to the db and check after restore. Related PR
#624

Resolves: #646
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@weshayutin weshayutin weshayutin left review comments

@kaovilai kaovilai kaovilai approved these changes

@mperetzred mperetzred Awaiting requested review from mperetzred

@rayfordj rayfordj Awaiting requested review from rayfordj

@jwmatthews jwmatthews Awaiting requested review from jwmatthews

Assignees

No one assigned

Labels

testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: OADP tests/e2e backup and restore tests NEED to validate data matches before and after restore.

3 participants

@deepakraj1997 @weshayutin @kaovilai