Skip to content

replace the parks-app with todolist on mongo#649

Merged
kaovilai merged 1 commit into
openshift:masterfrom
weshayutin:todolist_mongo
May 3, 2022
Merged

replace the parks-app with todolist on mongo#649
kaovilai merged 1 commit into
openshift:masterfrom
weshayutin:todolist_mongo

Conversation

@weshayutin
Copy link
Copy Markdown
Contributor

@weshayutin weshayutin commented Apr 28, 2022

Resolves: #646

@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented Apr 28, 2022

/hold WIP

@openshift-ci openshift-ci Bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2022
@openshift-ci openshift-ci Bot requested a review from jmontleon April 28, 2022 17:21
@weshayutin weshayutin mentioned this pull request Apr 28, 2022
Merged
@deepakraj1997
Copy link
Copy Markdown
Contributor

deepakraj1997 commented Apr 28, 2022

LGTM, Thank you for putting this up. Do we want to check CSI template as well as part of this ?

@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented Apr 28, 2022

@deepakraj1997 We could use the CSI version but we should do add that row of test data in a new PR.

@hhpatel14
Copy link
Copy Markdown
Contributor

hhpatel14 commented Apr 28, 2022

@weshayutin mongo-persistent-csi-template.yaml template looks good. I can add new PR after this for CSI.

@hhpatel14
Copy link
Copy Markdown
Contributor

hhpatel14 commented Apr 28, 2022

/lgtm

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 28, 2022
@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented Apr 28, 2022

/unhold

@openshift-ci openshift-ci Bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 28, 2022
@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented Apr 28, 2022

/retest

kaovilai
kaovilai requested changes Apr 29, 2022
View reviewed changes
Comment thread tests/e2e/backup_restore_suite_test.go Outdated
kaovilai
kaovilai reviewed Apr 29, 2022
View reviewed changes
Comment thread tests/e2e/backup_restore_suite_test.go Outdated
kaovilai
kaovilai reviewed Apr 29, 2022
View reviewed changes
Comment thread tests/e2e/backup_restore_suite_test.go Outdated
kaovilai
kaovilai requested changes Apr 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@kaovilai kaovilai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are using the same manifests for all ocp versions, we don't need to separate the entries.

@kaovilai
Copy link
Copy Markdown
Member

kaovilai commented Apr 29, 2022

Have PR of requested changes here weshayutin#1

@openshift-ci openshift-ci Bot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed lgtm Indicates that a PR is ready to be merged. labels May 3, 2022
@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 3, 2022

New changes are detected. LGTM label has been removed.

@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 3, 2022
@weshayutin
replace the parks-app with todolist on mongo
6d1eb5d 
* created a version of todolist for mongo
* ensure the manifest builds and triggers just like
the parks-app did
* adv is that the same app api can be used to add
data to the db and check after restore. Related PR
#624

Resolves: #646
@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented May 3, 2022

@kaovilai THANK YOU! for you help reviewing this one :)

@weshayutin
Copy link
Copy Markdown
Contributor Author

weshayutin commented May 3, 2022

/retest

@openshift-ci
Copy link
Copy Markdown

openshift-ci Bot commented May 3, 2022

@weshayutin: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@kaovilai kaovilai merged commit dfa7af9 into openshift:master May 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaovilai kaovilai kaovilai approved these changes

@hhpatel14 hhpatel14 Awaiting requested review from hhpatel14

@jmontleon jmontleon Awaiting requested review from jmontleon

Assignees

@hhpatel14 hhpatel14

Labels

testing

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Bug: parks-app crashes after being restored when hitting the api

4 participants

@weshayutin @deepakraj1997 @hhpatel14 @kaovilai