CNTRLPLANE-2260: test/e2e: migrate tokenreviews test to OTE framework by wangke19 · Pull Request #182 · openshift/oauth-apiserver

wangke19 · 2026-03-23T04:16:19Z

Summary

Migrate the tokenreviews e2e test to run under OTE/Ginkgo via openshift-tests.

Historical Background: Why `go test` Was Never Running This Test

test/e2e/tokenreviews.go has existed since 2021 but was never executed by go test. The reason: Go only compiles files ending in _test.go as test code. tokenreviews.go (no _test.go suffix) is compiled as regular package code, so go test ./test/e2e/... never picked it up. This was a latent bug — the TestTokenReviews function silently sat unused for ~5 years.

Given this, there is no meaningful go test baseline to preserve. Re-enabling go test for a 5-year-stale test that was never run would require fixing and validating a separate code path (port-forward, raw HTTP, InsecureSkipVerify) without any historical pass data. This PR focuses on OTE only.

What This PR Does

test/e2e/e2e.go (new): Ginkgo entry point with testTokenReviews(ctx, testing.TB).
Uses oauthClient.RESTClient() for authenticated tokenreviews calls — no port-forward,
no raw HTTP, no TLS workarounds. Computes the token resource name via sha256 hashing
(tokenName helper) to correctly distinguish the stored name from the raw token value
sent in the TokenReview spec.
test/e2e/helpers.go: Convert NewClientConfigForTest, PortForwardSvc,
NewResourceTrashbin, and ResourceTrashbin.Empty to accept testing.TB.
cmd/oauth-apiserver-tests-ext/dependencymagnet.go (new): Blank import to register
the test/e2e package with the OTE binary.
go.mod: Move github.com/onsi/ginkgo/v2 from indirect to direct.

Note: test/e2e/tokenreviews.go is left as-is (original upstream content). It remains dead
code as before — modifying it would be misleading since it is never executed.

Case Design

Setup
  └─ Create test user "tokenreviews-e2e-testuser"
  └─ Create OAuthClient "tokenreviews-e2e-client"
  └─ Create OAuthAccessToken with secret "tokenreviews-e2e-secret-value-for-testing"

Scenario A — Invalid token
  └─ POST TokenReview with a non-existent/garbage token
  └─ Expect: authenticated = false

Scenario B — Valid token
  └─ Compute resource name: sha256~<base64(SHA256(secret))>
  └─ POST TokenReview with the real token secret
  └─ Expect: authenticated = true, username matches

Teardown
  └─ ResourceTrashbin.Empty() deletes all created resources

Why SHA256? OpenShift doesn't store raw token secrets. The OAuthAccessToken resource name is derived as sha256~<base64-of-hash>. The tokenName() function performs this computation so the test can reference the token by its actual resource name.

Order matters: Testing the invalid case first confirms the API isn't accidentally open to anything — then the valid case proves it correctly authenticates a token that does exist.

Test Label

[sig-auth] OAuth should successfully review valid and invalid tokens [Component][Serial][apigroup:oauth.openshift.io]

Picked up by the openshift/oauth-apiserver/component/serial suite defined in
cmd/oauth-apiserver-tests-ext/main.go.

Local Verification

Ran 1 of 1 Specs in 2.902 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped

Summary

Add vendor dependencies required for the OTE test framework (Ginkgo + openshift-tests-extension).

⚠️ IMPORTANT: This PR depends on #163 and should be merged after it.

Changes

Commit: Dependency updates only

go.mod, vendor: add Ginkgo and OTE dependencies

go.mod: Add github.com/onsi/ginkgo/v2 v2.24.0 with replace directive to OpenShift fork

go.sum: Updated checksums

vendor/: 257 new files for Ginkgo, Gomega, openshift-tests-extension, and supporting libraries

Dependencies Added

github.com/onsi/ginkgo/v2 - BDD-style test framework (via OpenShift fork)

github.com/onsi/gomega - Matcher library

github.com/openshift-eng/openshift-tests-extension - OTE support

github.com/go-task/slim-sprig/v3, golang.org/x/net, golang.org/x/text, golang.org/x/tools - Supporting libraries

Related

Infrastructure PR: CNTRLPLANE-2260:cmd/oauth-apiserver-tests-ext: Update OTE framework integration #162

Test wrapper PR: CNTRLPLANE-2260: cmd: wire up OTE ginkgo suite for tokenreviews #163 (must be merged first)

Pattern reference: CNTRLPLANE-2159: cmd: add OTE infrastructure and clean up legacy test extension service-ca-operator#295

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai · 2026-03-23T04:16:32Z

Important

Review skipped

Auto reviews are limited based on label configuration.

🚫 Review skipped — only excluded labels are configured. (1)

do-not-merge/work-in-progress

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 60b42055-c31b-4528-bd8e-0cbc362da62d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

@coderabbitai resume to resume automatic reviews.
@coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

▶️ Resume reviews
🔍 Trigger review

Walkthrough

This PR adds end-to-end test infrastructure for the OAuth API server. It introduces a dependency magnet file to enable test registration and an e2e test suite that validates OAuth token review behavior.

Changes

Cohort / File(s)	Summary
E2E Test Infrastructure `cmd/oauth-apiserver-tests-ext/dependencymagnet.go`, `test/e2e/e2e.go`	Adds test registration mechanism via blank import and implements Ginkgo test suite for OAuth token review validation, including authenticated and unauthenticated token scenarios.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (1)

test/e2e/e2e.go (1)

7-7: Use io.ReadAll instead of deprecated ioutil.ReadAll.

ioutil.ReadAll has been deprecated since Go 1.16. Replace with io.ReadAll from the standard io package.

Suggested fix

-	"io/ioutil"
+	"io"

Then update the usages on lines 66 and 81:

-	respBodyBytes, err := ioutil.ReadAll(resp.Body)
+	respBodyBytes, err := io.ReadAll(resp.Body)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/e2e/e2e.go` at line 7, Replace the deprecated use of ioutil.ReadAll:
remove the "io/ioutil" import and import "io" instead, and update all calls to
ioutil.ReadAll to io.ReadAll (e.g., replace usages of ioutil.ReadAll at the
locations calling ReadAll on response bodies with io.ReadAll). Ensure any
variable names (resp, body, etc.) remain unchanged and close/handle response
bodies as before.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@test/e2e/e2e.go`:
- Around line 62-79: The first http response body is deferred (defer
resp.Body.Close()) but resp is reassigned before that defer runs; explicitly
close the first response body after reading and unmarshalling it (call
resp.Body.Close() right after json.Unmarshal and before issuing the second
insecureClient.Do), and remove or avoid the earlier defer for that first resp to
prevent leaking the Body; keep the defer only for the second response (or use
explicit closes for both). Reference: insecureClient.Do, failedReviewReq,
resp.Body.Close, json.Unmarshal, successfulReviewReq,
createTokenReviewRequestForToken.

---

Nitpick comments:
In `@test/e2e/e2e.go`:
- Line 7: Replace the deprecated use of ioutil.ReadAll: remove the "io/ioutil"
import and import "io" instead, and update all calls to ioutil.ReadAll to
io.ReadAll (e.g., replace usages of ioutil.ReadAll at the locations calling
ReadAll on response bodies with io.ReadAll). Ensure any variable names (resp,
body, etc.) remain unchanged and close/handle response bodies as before.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 5de86e2b-a72f-4ce0-a256-5b01d20683cf

📥 Commits

Reviewing files that changed from the base of the PR and between 467c631 and 8c4d1ed.

⛔ Files ignored due to path filters (256)

vendor/github.com/go-task/slim-sprig/v3/.editorconfig is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/.gitattributes is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/.gitignore is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/LICENSE.txt is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/README.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/Taskfile.yml is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/crypto.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/date.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/defaults.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/dict.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/doc.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/functions.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/list.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/network.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/numeric.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/reflect.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/regex.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/strings.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/url.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/.gitignore is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/CONTRIBUTING.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/LICENSE is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/Makefile is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/OWNERS is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/README.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/RELEASING.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/config/deprecated.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/core_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/core_dsl_patch.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/decorator_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/deprecated_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/formatter/colorable_others.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/formatter/colorable_windows.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/formatter/formatter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/build/build_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/command/abort.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/command/command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/command/program.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/generators/boostrap_templates.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/generators/bootstrap_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/generators/generate_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/generators/generate_templates.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/generators/generators_common.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/compile.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/gocovmerge.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/profiles_and_reports.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/run.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/test_suite.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/utils.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/verify_version.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/labels/labels_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/main.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/ginkgo.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/import.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/outline.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/outline_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/run/run_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/unfocus/unfocus_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/delta.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/delta_tracker.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/dependencies.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/package_hash.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/package_hashes.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/suite.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/watch_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo_cli_dependencies.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo_t_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/counter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/failer.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/focus.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/global/init.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/group.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/interrupt_handler/interrupt_handler.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/interrupt_handler/sigquit_swallower_unix.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/interrupt_handler/sigquit_swallower_windows.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/node.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/ordering.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/output_interceptor.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/output_interceptor_unix.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/output_interceptor_wasm.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/output_interceptor_win.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/client_server.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/http_client.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/http_server.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/rpc_client.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/rpc_server.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/server_handler.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_report.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_report_bsd.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_report_unix.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_report_wasm.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_report_win.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_reporter_manager.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/report_entry.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/spec.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/spec_context.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/spec_patch.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/suite.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/suite_patch.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/testingtproxy/testing_t_proxy.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/tree.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/writer.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/default_reporter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/deprecated_reporter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/json_report.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/junit_report.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/reporter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/teamcity_report.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporting_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/table_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/code_location.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/config.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/deprecated_types.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/deprecation_support.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/enum_support.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/errors.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/file_filter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/flags.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/label_filter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/report_entry.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/types.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/types_patch.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/version.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/.gitignore is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/CONTRIBUTING.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/LICENSE is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/README.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/RELEASING.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/format/format.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/gomega_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/assertion.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/async_assertion.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/duration_bundle.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/gomega.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/gutil/post_ioutil.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/gutil/using_ioutil.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/polling_signal_error.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/vetoptdesc.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/and.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/assignable_to_type_of_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/attributes_slice.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_a_directory.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_a_regular_file.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_an_existing_file.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_closed_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_comparable_to_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_element_of_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_empty_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_equivalent_to_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_false_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_identical_to.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_key_of_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_nil_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_numerically_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_sent_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_temporally_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_true_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_zero_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/consist_of.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/contain_element_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/contain_elements_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/contain_substring_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/equal_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_cap_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_each_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_exact_elements.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_existing_field_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_field.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_http_body_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_http_header_with_value_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_http_status_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_key_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_key_with_value_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_len_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_occurred_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_prefix_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_suffix_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_value.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/internal/miter/type_support_iter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/internal/miter/type_support_noiter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/match_error_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/match_json_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/match_regexp_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/match_xml_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/match_yaml_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/not.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/or.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/panic_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/receive_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/satisfy_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/semi_structured_data_support.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/succeed_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/support/goraph/bipartitegraph/bipartitegraph.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/support/goraph/bipartitegraph/bipartitegraphmatching.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/support/goraph/edge/edge.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/support/goraph/node/node.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/support/goraph/util/util.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/type_support.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/with_transform.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/types/types.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo/logging.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo/parallel.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo/util.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/atom/atom.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/atom/table.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/charset/charset.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/const.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/doc.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/doctype.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/entity.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/escape.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/foreign.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/iter.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/node.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/parse.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/render.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/token.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/charmap/charmap.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/charmap/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/encoding.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/htmlindex/htmlindex.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/htmlindex/map.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/htmlindex/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/internal/identifier/identifier.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/internal/identifier/mib.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/internal/internal.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/japanese/all.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/japanese/eucjp.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/japanese/iso2022jp.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/japanese/shiftjis.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/japanese/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/korean/euckr.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/korean/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/simplifiedchinese/all.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/simplifiedchinese/gbk.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/simplifiedchinese/hzgb2312.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/simplifiedchinese/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/traditionalchinese/big5.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/traditionalchinese/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/unicode/override.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/unicode/unicode.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/internal/utf8internal/utf8internal.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/runes/cond.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/runes/runes.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/cover/profile.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/edge/edge.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/cursor.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/inspector.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/iter.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/typeof.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/walk.go is excluded by !vendor/**, !**/vendor/**
vendor/modules.txt is excluded by !vendor/**, !**/vendor/**

📒 Files selected for processing (4)

cmd/oauth-apiserver-tests-ext/dependencymagnet.go
cmd/oauth-apiserver-tests-ext/main.go
go.mod
test/e2e/e2e.go

coderabbitai

🧹 Nitpick comments (2)

test/e2e/e2e.go (2)

7-7: Replace deprecated ioutil with io package.

io/ioutil is deprecated since Go 1.16. Replace ioutil.ReadAll calls (lines 66, 81) with io.ReadAll.

-	"io/ioutil"
+	"io"

And update the usages:

-	respBodyBytes, err := ioutil.ReadAll(resp.Body)
+	respBodyBytes, err := io.ReadAll(resp.Body)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/e2e/e2e.go` at line 7, Replace the deprecated import "io/ioutil" with
"io" in test/e2e/e2e.go and update all calls to ioutil.ReadAll (used in the test
functions around the response body reads at the spots that previously referenced
ioutil.ReadAll) to io.ReadAll; ensure imports and any references to ioutil are
removed and tests still call io.ReadAll(resp.Body) where the response body is
read.

49-58: Consider adding MinVersion to TLS config.

Static analysis flagged the missing MinVersion. While InsecureSkipVerify is intentional here, setting a minimum TLS version provides defense-in-depth.

 		TLSClientConfig: &tls.Config{
 			// we'll be reaching service-ca signed endpoints, service-ca
 			// certs are not a part of kubeconfig's ca bundle
 			InsecureSkipVerify: true,
+			MinVersion:         tls.VersionTLS12,
 		},

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/e2e/e2e.go` around lines 49 - 58, The TLS config for the test HTTP
client (the TLSClientConfig inside the Transport of insecureClient in
test/e2e/e2e.go) should include a MinVersion to enforce a minimum TLS protocol;
add MinVersion: tls.VersionTLS12 (or higher) to the tls.Config literal alongside
InsecureSkipVerify to provide defense-in-depth while keeping the intentional
skip verification.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@test/e2e/e2e.go`:
- Line 7: Replace the deprecated import "io/ioutil" with "io" in test/e2e/e2e.go
and update all calls to ioutil.ReadAll (used in the test functions around the
response body reads at the spots that previously referenced ioutil.ReadAll) to
io.ReadAll; ensure imports and any references to ioutil are removed and tests
still call io.ReadAll(resp.Body) where the response body is read.
- Around line 49-58: The TLS config for the test HTTP client (the
TLSClientConfig inside the Transport of insecureClient in test/e2e/e2e.go)
should include a MinVersion to enforce a minimum TLS protocol; add MinVersion:
tls.VersionTLS12 (or higher) to the tls.Config literal alongside
InsecureSkipVerify to provide defense-in-depth while keeping the intentional
skip verification.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 43e92c77-9477-4db3-b4b3-98a3a4171045

📥 Commits

Reviewing files that changed from the base of the PR and between 8c4d1ed and 6b2572e.

⛔ Files ignored due to path filters (40)

vendor/github.com/go-task/slim-sprig/v3/.editorconfig is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/.gitattributes is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/.gitignore is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/LICENSE.txt is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/README.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/Taskfile.yml is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/crypto.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/date.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/defaults.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/dict.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/doc.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/functions.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/list.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/network.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/numeric.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/reflect.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/regex.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/strings.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/url.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/.gitignore is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/CONTRIBUTING.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/LICENSE is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/Makefile is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/OWNERS is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/README.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/RELEASING.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/config/deprecated.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/core_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/core_dsl_patch.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/decorator_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/deprecated_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/formatter/colorable_others.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/formatter/colorable_windows.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/formatter/formatter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/build/build_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/command/abort.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/command/command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/command/program.go is excluded by !vendor/**, !**/vendor/**

📒 Files selected for processing (4)

cmd/oauth-apiserver-tests-ext/dependencymagnet.go
cmd/oauth-apiserver-tests-ext/main.go
go.mod
test/e2e/e2e.go

✅ Files skipped from review due to trivial changes (1)

cmd/oauth-apiserver-tests-ext/dependencymagnet.go

🚧 Files skipped from review as they are similar to previous changes (2)

go.mod
cmd/oauth-apiserver-tests-ext/main.go

coderabbitai

Actionable comments posted: 1

🧹 Nitpick comments (2)

test/e2e/e2e.go (2)

7-7: Replace deprecated ioutil with io.

io/ioutil has been deprecated since Go 1.16. Replace ioutil.ReadAll with io.ReadAll.

Suggested fix

 import (
 	"context"
 	"crypto/tls"
 	"encoding/json"
-	"io/ioutil"
+	"io"
 	"net/http"
 	"testing"

Then update the usages:

-	respBodyBytes, err := ioutil.ReadAll(resp.Body)
+	respBodyBytes, err := io.ReadAll(resp.Body)

Also applies to: 66-66, 81-81

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/e2e/e2e.go` at line 7, The import of the deprecated package "io/ioutil"
should be replaced with "io" and all calls to ioutil.ReadAll must be updated to
io.ReadAll; update the import statement in test/e2e/e2e.go and replace any usage
occurrences (e.g., the calls at the locations referenced around lines where
ioutil.ReadAll is used) so functions that call ioutil.ReadAll now call
io.ReadAll instead, ensuring imports compile-cleanly.

49-58: Consider setting TLS MinVersion.

Static analysis flagged the missing MinVersion in the TLS config. While this is test code with InsecureSkipVerify: true, setting a minimum TLS version is a good practice.

Optional: Add MinVersion

 		TLSClientConfig: &tls.Config{
 			// we'll be reaching service-ca signed endpoints, service-ca
 			// certs are not a part of kubeconfig's ca bundle
 			InsecureSkipVerify: true,
+			MinVersion:         tls.VersionTLS12,
 		},

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/e2e/e2e.go` around lines 49 - 58, The TLS config for the test http
client (insecureClient) is missing a MinVersion setting; update the tls.Config
used inside http.Transport (the one assigned to insecureClient in
test/e2e/e2e.go) to include a MinVersion (e.g., set MinVersion to
tls.VersionTLS12) so the client enforces a minimum TLS version even with
InsecureSkipVerify enabled.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@cmd/oauth-apiserver-tests-ext/main.go`:
- Around line 64-82: The test in test/e2e/e2e.go must include the tags required
by the OTE suites so it will match the qualifiers used in extension.AddSuite
(the suites named "openshift/oauth-apiserver/component/serial" and
"openshift/oauth-apiserver/component/serial-disruptive"); update the test's
registration/description to include both "[Component]" and "[Serial]" (in
addition to its existing tags like "[sig-auth]" and
"[apigroup:oauth.openshift.io]") so the suite Qualifiers match, or alternatively
remove this test from OTE registration if it should not run in those suites.

---

Nitpick comments:
In `@test/e2e/e2e.go`:
- Line 7: The import of the deprecated package "io/ioutil" should be replaced
with "io" and all calls to ioutil.ReadAll must be updated to io.ReadAll; update
the import statement in test/e2e/e2e.go and replace any usage occurrences (e.g.,
the calls at the locations referenced around lines where ioutil.ReadAll is used)
so functions that call ioutil.ReadAll now call io.ReadAll instead, ensuring
imports compile-cleanly.
- Around line 49-58: The TLS config for the test http client (insecureClient) is
missing a MinVersion setting; update the tls.Config used inside http.Transport
(the one assigned to insecureClient in test/e2e/e2e.go) to include a MinVersion
(e.g., set MinVersion to tls.VersionTLS12) so the client enforces a minimum TLS
version even with InsecureSkipVerify enabled.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 7ab6f960-bd98-4bd2-9f25-0674b1881b9d

📥 Commits

Reviewing files that changed from the base of the PR and between 6b2572e and fe3bed2.

⛔ Files ignored due to path filters (256)

vendor/github.com/go-task/slim-sprig/v3/.editorconfig is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/.gitattributes is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/.gitignore is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/LICENSE.txt is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/README.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/Taskfile.yml is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/crypto.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/date.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/defaults.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/dict.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/doc.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/functions.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/list.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/network.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/numeric.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/reflect.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/regex.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/strings.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/url.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/.gitignore is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/CONTRIBUTING.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/LICENSE is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/Makefile is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/OWNERS is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/README.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/RELEASING.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/config/deprecated.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/core_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/core_dsl_patch.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/decorator_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/deprecated_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/formatter/colorable_others.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/formatter/colorable_windows.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/formatter/formatter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/build/build_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/command/abort.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/command/command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/command/program.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/generators/boostrap_templates.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/generators/bootstrap_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/generators/generate_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/generators/generate_templates.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/generators/generators_common.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/compile.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/gocovmerge.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/profiles_and_reports.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/run.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/test_suite.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/utils.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/verify_version.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/labels/labels_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/main.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/ginkgo.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/import.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/outline.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/outline_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/run/run_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/unfocus/unfocus_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/delta.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/delta_tracker.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/dependencies.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/package_hash.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/package_hashes.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/suite.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/watch_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo_cli_dependencies.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo_t_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/counter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/failer.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/focus.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/global/init.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/group.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/interrupt_handler/interrupt_handler.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/interrupt_handler/sigquit_swallower_unix.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/interrupt_handler/sigquit_swallower_windows.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/node.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/ordering.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/output_interceptor.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/output_interceptor_unix.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/output_interceptor_wasm.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/output_interceptor_win.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/client_server.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/http_client.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/http_server.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/rpc_client.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/rpc_server.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/server_handler.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_report.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_report_bsd.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_report_unix.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_report_wasm.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_report_win.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_reporter_manager.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/report_entry.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/spec.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/spec_context.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/spec_patch.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/suite.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/suite_patch.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/testingtproxy/testing_t_proxy.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/tree.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/writer.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/default_reporter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/deprecated_reporter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/json_report.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/junit_report.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/reporter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/teamcity_report.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporting_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/table_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/code_location.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/config.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/deprecated_types.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/deprecation_support.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/enum_support.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/errors.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/file_filter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/flags.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/label_filter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/report_entry.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/types.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/types_patch.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/version.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/.gitignore is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/CONTRIBUTING.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/LICENSE is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/README.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/RELEASING.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/format/format.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/gomega_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/assertion.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/async_assertion.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/duration_bundle.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/gomega.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/gutil/post_ioutil.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/gutil/using_ioutil.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/polling_signal_error.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/vetoptdesc.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/and.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/assignable_to_type_of_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/attributes_slice.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_a_directory.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_a_regular_file.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_an_existing_file.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_closed_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_comparable_to_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_element_of_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_empty_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_equivalent_to_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_false_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_identical_to.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_key_of_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_nil_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_numerically_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_sent_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_temporally_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_true_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_zero_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/consist_of.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/contain_element_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/contain_elements_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/contain_substring_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/equal_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_cap_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_each_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_exact_elements.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_existing_field_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_field.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_http_body_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_http_header_with_value_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_http_status_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_key_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_key_with_value_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_len_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_occurred_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_prefix_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_suffix_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_value.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/internal/miter/type_support_iter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/internal/miter/type_support_noiter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/match_error_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/match_json_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/match_regexp_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/match_xml_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/match_yaml_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/not.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/or.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/panic_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/receive_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/satisfy_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/semi_structured_data_support.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/succeed_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/support/goraph/bipartitegraph/bipartitegraph.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/support/goraph/bipartitegraph/bipartitegraphmatching.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/support/goraph/edge/edge.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/support/goraph/node/node.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/support/goraph/util/util.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/type_support.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/with_transform.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/types/types.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo/logging.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo/parallel.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo/util.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/atom/atom.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/atom/table.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/charset/charset.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/const.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/doc.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/doctype.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/entity.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/escape.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/foreign.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/iter.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/node.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/parse.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/render.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/token.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/charmap/charmap.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/charmap/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/encoding.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/htmlindex/htmlindex.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/htmlindex/map.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/htmlindex/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/internal/identifier/identifier.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/internal/identifier/mib.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/internal/internal.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/japanese/all.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/japanese/eucjp.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/japanese/iso2022jp.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/japanese/shiftjis.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/japanese/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/korean/euckr.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/korean/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/simplifiedchinese/all.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/simplifiedchinese/gbk.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/simplifiedchinese/hzgb2312.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/simplifiedchinese/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/traditionalchinese/big5.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/traditionalchinese/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/unicode/override.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/unicode/unicode.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/internal/utf8internal/utf8internal.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/runes/cond.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/runes/runes.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/cover/profile.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/edge/edge.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/cursor.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/inspector.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/iter.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/typeof.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/walk.go is excluded by !vendor/**, !**/vendor/**
vendor/modules.txt is excluded by !vendor/**, !**/vendor/**

📒 Files selected for processing (4)

cmd/oauth-apiserver-tests-ext/dependencymagnet.go
cmd/oauth-apiserver-tests-ext/main.go
go.mod
test/e2e/e2e.go

✅ Files skipped from review due to trivial changes (2)

cmd/oauth-apiserver-tests-ext/dependencymagnet.go
go.mod

coderabbitai

♻️ Duplicate comments (1)

test/e2e/e2e.go (1)

62-79: ⚠️ Potential issue | 🟡 Minor

First response body is leaked due to variable reassignment.

The defer resp.Body.Close() on line 64 won't close the first response. When resp is reassigned on line 77, the defer captures the variable by reference, so both defers will close only the second response body.

Suggested fix: Close first body explicitly

 	resp, err := insecureClient.Do(failedReviewReq)
 	require.NoError(t, err)
-	defer resp.Body.Close()

-	respBodyBytes, err := ioutil.ReadAll(resp.Body)
+	respBodyBytes, err := io.ReadAll(resp.Body)
+	resp.Body.Close()
 	require.NoError(t, err)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/e2e/e2e.go` around lines 62 - 79, The first HTTP response body is leaked
because the deferred resp.Body.Close() is tied to the mutable resp variable and
gets overwritten when resp is reassigned; before calling
insecureClient.Do(successfulReviewReq) you must explicitly close the first
response body (e.g., call resp.Body.Close() after reading respBodyBytes) or use
a new variable for the second response (e.g., resp2) so each response from
insecureClient.Do(failedReviewReq) and insecureClient.Do(successfulReviewReq)
has its own Close called; update the code around the insecureClient.Do calls and
the resp variable handling (resp, failedReviewReq, successfulReviewReq,
createTokenReviewRequestForToken) to ensure the first resp.Body is closed before
reassignment.

🧹 Nitpick comments (1)

test/e2e/e2e.go (1)

7-7: Replace deprecated io/ioutil with io.

ioutil is deprecated since Go 1.16. Use io.ReadAll instead.

-	"io/ioutil"
+	"io"

Then update the calls on lines 66 and 81:

-	respBodyBytes, err := ioutil.ReadAll(resp.Body)
+	respBodyBytes, err := io.ReadAll(resp.Body)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/e2e/e2e.go` at line 7, Replace the deprecated import "io/ioutil" with
"io" in the import block and update all calls to ioutil.ReadAll to io.ReadAll
(specifically the two ReadAll usages in this file). Ensure the import list only
includes "io" (remove "io/ioutil") and that any variables receiving the read
result still handle the returned ([]byte, error) signature from io.ReadAll;
update error handling accordingly in the functions where those ReadAll calls
occur.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@test/e2e/e2e.go`:
- Around line 62-79: The first HTTP response body is leaked because the deferred
resp.Body.Close() is tied to the mutable resp variable and gets overwritten when
resp is reassigned; before calling insecureClient.Do(successfulReviewReq) you
must explicitly close the first response body (e.g., call resp.Body.Close()
after reading respBodyBytes) or use a new variable for the second response
(e.g., resp2) so each response from insecureClient.Do(failedReviewReq) and
insecureClient.Do(successfulReviewReq) has its own Close called; update the code
around the insecureClient.Do calls and the resp variable handling (resp,
failedReviewReq, successfulReviewReq, createTokenReviewRequestForToken) to
ensure the first resp.Body is closed before reassignment.

---

Nitpick comments:
In `@test/e2e/e2e.go`:
- Line 7: Replace the deprecated import "io/ioutil" with "io" in the import
block and update all calls to ioutil.ReadAll to io.ReadAll (specifically the two
ReadAll usages in this file). Ensure the import list only includes "io" (remove
"io/ioutil") and that any variables receiving the read result still handle the
returned ([]byte, error) signature from io.ReadAll; update error handling
accordingly in the functions where those ReadAll calls occur.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: efea35e1-b800-417a-a72f-82808dc7111f

📥 Commits

Reviewing files that changed from the base of the PR and between fe3bed2 and 5ddbdc4.

⛔ Files ignored due to path filters (256)

vendor/github.com/go-task/slim-sprig/v3/.editorconfig is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/.gitattributes is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/.gitignore is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/LICENSE.txt is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/README.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/Taskfile.yml is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/crypto.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/date.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/defaults.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/dict.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/doc.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/functions.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/list.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/network.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/numeric.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/reflect.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/regex.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/strings.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/go-task/slim-sprig/v3/url.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/.gitignore is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/CONTRIBUTING.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/LICENSE is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/Makefile is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/OWNERS is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/README.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/RELEASING.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/config/deprecated.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/core_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/core_dsl_patch.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/decorator_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/deprecated_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/formatter/colorable_others.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/formatter/colorable_windows.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/formatter/formatter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/build/build_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/command/abort.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/command/command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/command/program.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/generators/boostrap_templates.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/generators/bootstrap_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/generators/generate_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/generators/generate_templates.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/generators/generators_common.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/compile.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/gocovmerge.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/profiles_and_reports.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/run.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/test_suite.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/utils.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/internal/verify_version.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/labels/labels_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/main.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/ginkgo.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/import.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/outline.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/outline/outline_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/run/run_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/unfocus/unfocus_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/delta.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/delta_tracker.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/dependencies.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/package_hash.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/package_hashes.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/suite.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo/watch/watch_command.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo_cli_dependencies.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/ginkgo_t_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/counter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/failer.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/focus.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/global/init.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/group.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/interrupt_handler/interrupt_handler.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/interrupt_handler/sigquit_swallower_unix.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/interrupt_handler/sigquit_swallower_windows.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/node.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/ordering.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/output_interceptor.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/output_interceptor_unix.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/output_interceptor_wasm.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/output_interceptor_win.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/client_server.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/http_client.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/http_server.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/rpc_client.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/rpc_server.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/parallel_support/server_handler.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_report.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_report_bsd.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_report_unix.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_report_wasm.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_report_win.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/progress_reporter_manager.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/report_entry.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/spec.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/spec_context.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/spec_patch.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/suite.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/suite_patch.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/testingtproxy/testing_t_proxy.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/tree.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/internal/writer.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/default_reporter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/deprecated_reporter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/json_report.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/junit_report.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/reporter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporters/teamcity_report.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/reporting_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/table_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/code_location.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/config.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/deprecated_types.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/deprecation_support.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/enum_support.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/errors.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/file_filter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/flags.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/label_filter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/report_entry.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/types.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/types_patch.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/ginkgo/v2/types/version.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/.gitignore is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/CHANGELOG.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/CONTRIBUTING.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/LICENSE is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/README.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/RELEASING.md is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/format/format.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/gomega_dsl.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/assertion.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/async_assertion.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/duration_bundle.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/gomega.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/gutil/post_ioutil.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/gutil/using_ioutil.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/polling_signal_error.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/internal/vetoptdesc.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/and.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/assignable_to_type_of_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/attributes_slice.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_a_directory.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_a_regular_file.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_an_existing_file.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_closed_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_comparable_to_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_element_of_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_empty_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_equivalent_to_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_false_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_identical_to.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_key_of_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_nil_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_numerically_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_sent_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_temporally_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_true_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/be_zero_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/consist_of.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/contain_element_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/contain_elements_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/contain_substring_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/equal_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_cap_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_each_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_exact_elements.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_existing_field_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_field.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_http_body_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_http_header_with_value_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_http_status_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_key_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_key_with_value_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_len_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_occurred_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_prefix_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_suffix_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/have_value.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/internal/miter/type_support_iter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/internal/miter/type_support_noiter.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/match_error_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/match_json_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/match_regexp_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/match_xml_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/match_yaml_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/not.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/or.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/panic_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/receive_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/satisfy_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/semi_structured_data_support.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/succeed_matcher.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/support/goraph/bipartitegraph/bipartitegraph.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/support/goraph/bipartitegraph/bipartitegraphmatching.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/support/goraph/edge/edge.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/support/goraph/node/node.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/support/goraph/util/util.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/type_support.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/matchers/with_transform.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/onsi/gomega/types/types.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo/logging.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo/parallel.go is excluded by !vendor/**, !**/vendor/**
vendor/github.com/openshift-eng/openshift-tests-extension/pkg/ginkgo/util.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/atom/atom.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/atom/table.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/charset/charset.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/const.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/doc.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/doctype.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/entity.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/escape.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/foreign.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/iter.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/node.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/parse.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/render.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/net/html/token.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/charmap/charmap.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/charmap/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/encoding.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/htmlindex/htmlindex.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/htmlindex/map.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/htmlindex/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/internal/identifier/identifier.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/internal/identifier/mib.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/internal/internal.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/japanese/all.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/japanese/eucjp.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/japanese/iso2022jp.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/japanese/shiftjis.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/japanese/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/korean/euckr.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/korean/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/simplifiedchinese/all.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/simplifiedchinese/gbk.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/simplifiedchinese/hzgb2312.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/simplifiedchinese/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/traditionalchinese/big5.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/traditionalchinese/tables.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/unicode/override.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/encoding/unicode/unicode.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/internal/utf8internal/utf8internal.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/runes/cond.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/text/runes/runes.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/cover/profile.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/edge/edge.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/cursor.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/inspector.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/iter.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/typeof.go is excluded by !vendor/**, !**/vendor/**
vendor/golang.org/x/tools/go/ast/inspector/walk.go is excluded by !vendor/**, !**/vendor/**
vendor/modules.txt is excluded by !vendor/**, !**/vendor/**

📒 Files selected for processing (3)

cmd/oauth-apiserver-tests-ext/dependencymagnet.go
go.mod
test/e2e/e2e.go

✅ Files skipped from review due to trivial changes (2)

cmd/oauth-apiserver-tests-ext/dependencymagnet.go
go.mod

openshift-ci-robot · 2026-03-27T08:35:07Z

@wangke19: This pull request references CNTRLPLANE-2260 which is a valid jira issue.

Details

In response to this:

Summary

Add the Ginkgo wrapper and dependency magnet to register the tokenreviews
e2e test with the OTE binary.

✅ PR #163 (suite wiring + vendor) has been merged. This PR adds the final test migration.

Commits

Commit 1: Test migration

test/e2e: migrate tokenreviews test to OTE framework

test/e2e/e2e.go: Ginkgo wrapper calling testTokenReviewsGinkgo(),
tagged with [sig-auth] and [apigroup:oauth.openshift.io]

cmd/oauth-apiserver-tests-ext/dependencymagnet.go: blank import to
register the test/e2e package with the OTE binary

test/e2e/tokenreviews.go is left completely unchanged.

OTE Discovery

After merging, the OTE binary discovers:
[sig-auth] OAuth should successfully review valid and invalid tokens [apigroup:oauth.openshift.io]
Related

Infrastructure PR: CNTRLPLANE-2260:cmd/oauth-apiserver-tests-ext: Update OTE framework integration #162 (merged ✅)

Suite wiring + vendor PR: CNTRLPLANE-2260: cmd: wire up OTE ginkgo suite for tokenreviews #163 (merged ✅)

Pattern reference: CNTRLPLANE-2159: cmd: add OTE infrastructure and clean up legacy test extension service-ca-operator#295

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

coderabbitai

♻️ Duplicate comments (1)

test/e2e/e2e.go (1)
62-79: ⚠️ Potential issue | 🟡 Minor

Response body handling pattern from previous review still present.

The first response body's defer resp.Body.Close() (line 64) will not execute until the function returns. When resp is reassigned on line 77, the first response body remains open until function exit. The previous review suggested explicitly closing the first response body after reading it and before issuing the second request.

While this works correctly in this test context with only two requests, the pattern can lead to resource leaks in longer-running code.
🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed.

In `@test/e2e/e2e.go` around lines 62 - 79, The first HTTP response body
referenced by resp is deferred for Close() and remains open until the test
function exits, causing a potential resource leak when resp is reassigned;
update the token review handling so you close resp.Body immediately after
reading (after ioutil.ReadAll and json.Unmarshal of tokenReviewResp) instead of
deferring Close() (keep the defer for the second request's resp), ensuring the
initial resp.Body is explicitly closed before calling
insecureClient.Do(createTokenReviewRequestForToken(...)).

🧹 Nitpick comments (2)

test/e2e/e2e.go (2)

66-66: Replace deprecated ioutil.ReadAll with io.ReadAll.

ioutil.ReadAll has been deprecated since Go 1.16. Use io.ReadAll from the io package instead.

♻️ Update to use io.ReadAll

Update the import at the top of the file:

 import (
 	"context"
 	"crypto/tls"
 	"encoding/json"
-	"io/ioutil"
+	"io"
 	"net/http"
 	"testing"

Then update both usages:

-	respBodyBytes, err := ioutil.ReadAll(resp.Body)
+	respBodyBytes, err := io.ReadAll(resp.Body)
 	require.NoError(t, err)

Also applies to: 81-81

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/e2e/e2e.go` at line 66, Replace deprecated ioutil.ReadAll usage with
io.ReadAll: update the import block to remove "io/ioutil" and import "io"
instead, then change both occurrences where respBodyBytes, err :=
ioutil.ReadAll(resp.Body) (and the other usage around the same area) to use
io.ReadAll(resp.Body). Ensure any build/import references to ioutil are removed
and tests compile.

49-58: Consider setting TLS MinVersion for completeness.

While InsecureSkipVerify is appropriately used for this test environment (as documented in the comment), consider adding MinVersion: tls.VersionTLS13 to the TLS config for completeness and to align with security best practices.

🔒 Optional TLS configuration improvement

 	insecureClient := http.Client{
 		Transport: &http.Transport{
 			Proxy: http.ProxyFromEnvironment,
 			TLSClientConfig: &tls.Config{
+				MinVersion: tls.VersionTLS13,
 				// we'll be reaching service-ca signed endpoints, service-ca
 				// certs are not a part of kubeconfig's ca bundle
 				InsecureSkipVerify: true,
 			},
 		},
 	}

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@test/e2e/e2e.go` around lines 49 - 58, The TLS config for the test HTTP
client (tls.Config inside insecureClient / http.Client) omits a minimum TLS
version; add MinVersion: tls.VersionTLS13 to the tls.Config to enforce TLS 1.3
as the minimum while retaining InsecureSkipVerify for the test environment,
updating the tls.Config initialization in the insecureClient declaration.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Duplicate comments:
In `@test/e2e/e2e.go`:
- Around line 62-79: The first HTTP response body referenced by resp is deferred
for Close() and remains open until the test function exits, causing a potential
resource leak when resp is reassigned; update the token review handling so you
close resp.Body immediately after reading (after ioutil.ReadAll and
json.Unmarshal of tokenReviewResp) instead of deferring Close() (keep the defer
for the second request's resp), ensuring the initial resp.Body is explicitly
closed before calling insecureClient.Do(createTokenReviewRequestForToken(...)).

---

Nitpick comments:
In `@test/e2e/e2e.go`:
- Line 66: Replace deprecated ioutil.ReadAll usage with io.ReadAll: update the
import block to remove "io/ioutil" and import "io" instead, then change both
occurrences where respBodyBytes, err := ioutil.ReadAll(resp.Body) (and the other
usage around the same area) to use io.ReadAll(resp.Body). Ensure any
build/import references to ioutil are removed and tests compile.
- Around line 49-58: The TLS config for the test HTTP client (tls.Config inside
insecureClient / http.Client) omits a minimum TLS version; add MinVersion:
tls.VersionTLS13 to the tls.Config to enforce TLS 1.3 as the minimum while
retaining InsecureSkipVerify for the test environment, updating the tls.Config
initialization in the insecureClient declaration.

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: d2568823-c071-4adf-a258-a9e4605d3389

📥 Commits

Reviewing files that changed from the base of the PR and between 5ddbdc4 and 6d57cb8.

📒 Files selected for processing (2)

cmd/oauth-apiserver-tests-ext/dependencymagnet.go
test/e2e/e2e.go

✅ Files skipped from review due to trivial changes (1)

cmd/oauth-apiserver-tests-ext/dependencymagnet.go

openshift-ci-robot · 2026-03-27T08:40:34Z

@wangke19: This pull request references CNTRLPLANE-2260 which is a valid jira issue.

Details

In response to this:

Summary

Add the Ginkgo wrapper and dependency magnet to register the tokenreviews
e2e test with the OTE binary.

✅ PR #163 (suite wiring + vendor) has been merged. This PR adds the final test migration.

Commits

Commit 1: Infrastructure code

test/e2e: migrate tokenreviews test to OTE framework

test/e2e/e2e.go: Ginkgo wrapper calling testTokenReviewsGinkgo(),
tagged with [sig-auth] and [apigroup:oauth.openshift.io]

cmd/oauth-apiserver-tests-ext/dependencymagnet.go: blank import to
register the test/e2e package with the OTE binary

test/e2e/tokenreviews.go is left completely unchanged.

Commit 2: Dependencies

go.mod: mark ginkgo/v2 as direct dependency

Move github.com/onsi/ginkgo/v2 from indirect to direct dependencies
since test/e2e/e2e.go now imports it directly

OTE Discovery

After merging, the OTE binary discovers:
[sig-auth] OAuth should successfully review valid and invalid tokens [apigroup:oauth.openshift.io]
Related

Infrastructure PR: CNTRLPLANE-2260:cmd/oauth-apiserver-tests-ext: Update OTE framework integration #162 (merged ✅)

Suite wiring + vendor PR: CNTRLPLANE-2260: cmd: wire up OTE ginkgo suite for tokenreviews #163 (merged ✅)

Pattern reference: CNTRLPLANE-2159: cmd: add OTE infrastructure and clean up legacy test extension service-ca-operator#295

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-27T10:18:20Z

@wangke19: This pull request references CNTRLPLANE-2260 which is a valid jira issue.

Details

In response to this:

Summary

Add dual-mode compatibility for the tokenreviews e2e test, enabling it to run
with both standard go test and OTE/Ginkgo.

✅ PR #163 (suite wiring + vendor) has been merged. This PR adds the final test migration.

Dual-Mode Pattern

Following the service-ca-operator migration pattern,
this PR maintains compatibility with existing go test runs while enabling OTE execution:

Shared test logic in test/e2e/e2e.go using testing.TB interface

Go test wrapper in test/e2e/tokenreviews_test.go delegates to shared function

Ginkgo wrapper in test/e2e/e2e.go for OTE discovery

Helper functions converted to accept testing.TB for dual compatibility

Commits

Commit 1: Infrastructure code

test/e2e: migrate tokenreviews test to OTE framework

test/e2e/e2e.go: Ginkgo wrapper and shared testTokenReviews(testing.TB) function,
tagged with [sig-auth] and [apigroup:oauth.openshift.io]

test/e2e/tokenreviews_test.go: Simplified go test wrapper that delegates to shared function

test/e2e/helpers.go: Convert helper functions to accept testing.TB

cmd/oauth-apiserver-tests-ext/dependencymagnet.go: Blank import to register test package

Commit 2: Dependencies

go.mod: mark ginkgo/v2 as direct dependency

Move github.com/onsi/ginkgo/v2 from indirect to direct dependencies

Test Execution

Via go test:
make test-e2e
Via OTE:
openshift-tests run openshift/component/serial --provider [...]
OTE Discovery

After merging, the OTE binary discovers:
[sig-auth] OAuth should successfully review valid and invalid tokens [apigroup:oauth.openshift.io]
Related

Infrastructure PR: CNTRLPLANE-2260:cmd/oauth-apiserver-tests-ext: Update OTE framework integration #162 (merged ✅)

Suite wiring + vendor PR: CNTRLPLANE-2260: cmd: wire up OTE ginkgo suite for tokenreviews #163 (merged ✅)

Pattern reference: CNTRLPLANE-3034:test/e2e: migrate crd-ca-bundle-injection to OTE serial suite service-ca-operator#334

Migration guide: ~/ai-workspace/service-ca-operator/OTE-MIGRATION-GUIDE.md

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-27T10:44:34Z

@wangke19: This pull request references CNTRLPLANE-2260 which is a valid jira issue.

Details

In response to this:

Summary

Add dual-mode compatibility for the tokenreviews e2e test, enabling it to run
with both standard go test and OTE/Ginkgo.

✅ PR #163 (suite wiring + vendor) has been merged. This PR adds the final test migration.

Dual-Mode Pattern

Following the service-ca-operator migration pattern,
this PR maintains compatibility with existing go test runs while enabling OTE execution:

Shared test logic in test/e2e/e2e.go using testing.TB interface

Existing test file test/e2e/tokenreviews.go simplified to delegate to shared function

Ginkgo wrapper in test/e2e/e2e.go for OTE discovery

Helper functions converted to accept testing.TB for dual compatibility

No new test files created - the existing tokenreviews.go is modified to call the shared function.

Commits

Commit 1: Infrastructure code (177 additions, 144 deletions)

test/e2e: migrate tokenreviews test to OTE framework

test/e2e/e2e.go: New file with Ginkgo wrapper and shared testTokenReviews(testing.TB)
function, tagged with [sig-auth] and [apigroup:oauth.openshift.io]. Includes all
helper functions converted to testing.TB.

test/e2e/tokenreviews.go: Modified to delegate to shared testTokenReviews() function.
Reduced from ~146 lines to ~9 lines with NOTE comment explaining temporary duplication.

test/e2e/helpers.go: Modified helper functions to accept testing.TB:

NewClientConfigForTest(testing.TB)

PortForwardSvc(testing.TB, ...)

NewResourceTrashbin(testing.TB, ...)

ResourceTrashbin.Empty(testing.TB)

cmd/oauth-apiserver-tests-ext/dependencymagnet.go: New file with blank import to
register the test/e2e package with the OTE binary.

Commit 2: Dependencies (1 insertion, 1 deletion)

go.mod: mark ginkgo/v2 as direct dependency

Move github.com/onsi/ginkgo/v2 from indirect to direct dependencies

Test Execution

Both test architectures run in parallel until OTE is stable:

Via go test (existing):
make test-e2e
# Runs TestTokenReviews(t *testing.T) → testTokenReviews(t)
Via OTE (new):
openshift-tests run openshift/component/serial --provider [...]
# Runs g.It(...) → testTokenReviews(g.GinkgoTB())
OTE Discovery

After merging, the OTE binary discovers:
[sig-auth] OAuth should successfully review valid and invalid tokens [apigroup:oauth.openshift.io]
Related

Infrastructure PR: CNTRLPLANE-2260:cmd/oauth-apiserver-tests-ext: Update OTE framework integration #162 (merged ✅)

Suite wiring + vendor PR: CNTRLPLANE-2260: cmd: wire up OTE ginkgo suite for tokenreviews #163 (merged ✅)

Pattern reference: CNTRLPLANE-3034:test/e2e: migrate crd-ca-bundle-injection to OTE serial suite service-ca-operator#334

Migration guide: ~/ai-workspace/service-ca-operator/OTE-MIGRATION-GUIDE.md

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2026-03-27T11:59:40Z

@wangke19: This pull request references CNTRLPLANE-2260 which is a valid jira issue.

Details

In response to this:

Summary

Add dual-mode compatibility for the tokenreviews e2e test, enabling it to run
with both standard go test and OTE/Ginkgo.

✅ PR #163 (suite wiring + vendor) has been merged. This PR adds the final test migration.

Dual-Mode Pattern

Following the service-ca-operator migration pattern,
this PR maintains compatibility with existing go test runs while enabling OTE execution:

Shared test logic in test/e2e/e2e.go using testing.TB interface

Existing test file test/e2e/tokenreviews.go simplified to delegate to shared function

Ginkgo wrapper in test/e2e/e2e.go for OTE discovery

Helper functions converted to accept testing.TB for dual compatibility

No new test files created - the existing tokenreviews.go is modified to call the shared function.

Commits

Commit 1: Infrastructure code (177 additions, 144 deletions)

test/e2e: migrate tokenreviews test to OTE framework

test/e2e/e2e.go: New file with Ginkgo wrapper and shared testTokenReviews(testing.TB)
function, tagged with [sig-auth] and [apigroup:oauth.openshift.io]. Includes all
helper functions converted to testing.TB.

test/e2e/tokenreviews.go: Modified to delegate to shared testTokenReviews() function.
Reduced from ~146 lines to ~9 lines with NOTE comment explaining temporary duplication.

test/e2e/helpers.go: Modified helper functions to accept testing.TB:

NewClientConfigForTest(testing.TB)

PortForwardSvc(testing.TB, ...)

NewResourceTrashbin(testing.TB, ...)

ResourceTrashbin.Empty(testing.TB)

cmd/oauth-apiserver-tests-ext/dependencymagnet.go: New file with blank import to
register the test/e2e package with the OTE binary.

Commit 2: Dependencies (1 insertion, 1 deletion)

go.mod: mark ginkgo/v2 as direct dependency

Move github.com/onsi/ginkgo/v2 from indirect to direct dependencies

Test Execution

Both test architectures run in parallel until OTE is stable:

Via go test (existing):
make test-e2e
# Runs TestTokenReviews(t *testing.T) → testTokenReviews(t)
Via OTE (new):
openshift-tests run openshift/component/serial --provider [...]
# Runs g.It(...) → testTokenReviews(g.GinkgoTB())
OTE Discovery

After merging, the OTE binary discovers:
[sig-auth] OAuth should successfully review valid and invalid tokens [apigroup:oauth.openshift.io]
Related

Infrastructure PR: CNTRLPLANE-2260:cmd/oauth-apiserver-tests-ext: Update OTE framework integration #162 (merged ✅)

Suite wiring + vendor PR: CNTRLPLANE-2260: cmd: wire up OTE ginkgo suite for tokenreviews #163 (merged ✅)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

Add Ginkgo entry point for the tokenreviews e2e test: - test/e2e/e2e.go: Ginkgo wrapper and testTokenReviews(ctx, testing.TB) function tagged [sig-auth][Component][Serial][apigroup:oauth.openshift.io]. Uses oauthClient.RESTClient() for authenticated tokenreviews requests — no port-forward needed. Computes token resource name via sha256 hashing (tokenName helper) to distinguish the stored resource name from the raw secret value sent in the TokenReview spec. - test/e2e/helpers.go: Convert NewClientConfigForTest, PortForwardSvc, NewResourceTrashbin, and ResourceTrashbin.Empty to accept testing.TB for Ginkgo compatibility. - cmd/oauth-apiserver-tests-ext/dependencymagnet.go: Blank import to register test/e2e with the OTE binary. Jira: OCPBUGS-XXXX

test/e2e/e2e.go now imports github.com/onsi/ginkgo/v2 directly; move it from indirect to direct in go.mod.

openshift-ci-robot · 2026-03-30T07:47:45Z

@wangke19: This pull request references CNTRLPLANE-2260 which is a valid jira issue.

Details

In response to this:

Summary

Migrate the tokenreviews e2e test to run under OTE/Ginkgo via openshift-tests.

Historical Background: Why go test Was Never Running This Test

test/e2e/tokenreviews.go has existed since 2021 but was never executed by go test. The reason: Go only compiles files ending in _test.go as test code. tokenreviews.go (no _test.go suffix) is compiled as regular package code, so go test ./test/e2e/... never picked it up. This was a latent bug — the TestTokenReviews function silently sat unused for ~5 years.

Given this, there is no meaningful go test baseline to preserve. Re-enabling go test for a 5-year-stale test that was never run would require fixing and validating a separate code path (port-forward, raw HTTP, InsecureSkipVerify) without any historical pass data. This PR focuses on OTE only.

What This PR Does

test/e2e/e2e.go (new): Ginkgo entry point with testTokenReviews(ctx, testing.TB).
Uses oauthClient.RESTClient() for authenticated tokenreviews calls — no port-forward,
no raw HTTP, no TLS workarounds. Computes the token resource name via sha256 hashing
(tokenName helper) to correctly distinguish the stored name from the raw token value
sent in the TokenReview spec.

test/e2e/helpers.go: Convert NewClientConfigForTest, PortForwardSvc,
NewResourceTrashbin, and ResourceTrashbin.Empty to accept testing.TB.

cmd/oauth-apiserver-tests-ext/dependencymagnet.go (new): Blank import to register
the test/e2e package with the OTE binary.

go.mod: Move github.com/onsi/ginkgo/v2 from indirect to direct.

Note: test/e2e/tokenreviews.go is left as-is (original upstream content). It remains dead
code as before — modifying it would be misleading since it is never executed.

Test Label
[sig-auth] OAuth should successfully review valid and invalid tokens [Component][Serial][apigroup:oauth.openshift.io]
Picked up by the openshift/oauth-apiserver/component/serial suite defined in
cmd/oauth-apiserver-tests-ext/main.go.

Local Verification
Ran 1 of 1 Specs in 2.902 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
Related

Infrastructure PR: CNTRLPLANE-2260:cmd/oauth-apiserver-tests-ext: Update OTE framework integration #162 (merged ✅)

Suite wiring + vendor PR: CNTRLPLANE-2260: cmd: wire up OTE ginkgo suite for tokenreviews #163 (merged ✅)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

wangke19 · 2026-03-30T11:45:43Z

/test e2e-aws-serial

wangke19 · 2026-03-30T12:24:00Z

/test e2e-aws-serial

wangke19 · 2026-03-30T13:13:35Z

/test e2e-aws-serial

wangke19 · 2026-03-30T15:38:02Z

/test e2e-aws-serial

Add optional OTE CI job running the openshift/oauth-apiserver/component/serial suite via openshift-tests on GCP. This replaces the e2e-component job (which runs `make test-e2e` = `go test ./test/e2e/...` and picks up zero tests due to the missing _test.go suffix) with a proper Ginkgo/OTE job that exercises the tokenreviews e2e test migrated in openshift/oauth-apiserver#182. Add the job to master, release-4.23, and release-4.22.

openshift-ci · 2026-03-30T20:53:25Z

@wangke19: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-gcp-component-serial-disruptive-ote	`0cfbc73`	link	false	`/test e2e-gcp-component-serial-disruptive-ote`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

wangke19 · 2026-03-31T02:46:23Z

/e2e-gcp-component-serial-disruptive-ote is failed as expected, because there is no case migration for now,

openshift-ci-robot · 2026-03-31T07:48:35Z

@wangke19: This pull request references CNTRLPLANE-2260 which is a valid jira issue.

Details

In response to this:

Summary

Migrate the tokenreviews e2e test to run under OTE/Ginkgo via openshift-tests.

Historical Background: Why go test Was Never Running This Test

test/e2e/tokenreviews.go has existed since 2021 but was never executed by go test. The reason: Go only compiles files ending in _test.go as test code. tokenreviews.go (no _test.go suffix) is compiled as regular package code, so go test ./test/e2e/... never picked it up. This was a latent bug — the TestTokenReviews function silently sat unused for ~5 years.

Given this, there is no meaningful go test baseline to preserve. Re-enabling go test for a 5-year-stale test that was never run would require fixing and validating a separate code path (port-forward, raw HTTP, InsecureSkipVerify) without any historical pass data. This PR focuses on OTE only.

What This PR Does

test/e2e/e2e.go (new): Ginkgo entry point with testTokenReviews(ctx, testing.TB).
Uses oauthClient.RESTClient() for authenticated tokenreviews calls — no port-forward,
no raw HTTP, no TLS workarounds. Computes the token resource name via sha256 hashing
(tokenName helper) to correctly distinguish the stored name from the raw token value
sent in the TokenReview spec.

test/e2e/helpers.go: Convert NewClientConfigForTest, PortForwardSvc,
NewResourceTrashbin, and ResourceTrashbin.Empty to accept testing.TB.

cmd/oauth-apiserver-tests-ext/dependencymagnet.go (new): Blank import to register
the test/e2e package with the OTE binary.

go.mod: Move github.com/onsi/ginkgo/v2 from indirect to direct.

Note: test/e2e/tokenreviews.go is left as-is (original upstream content). It remains dead
code as before — modifying it would be misleading since it is never executed.

Case Design
Setup
 └─ Create test user "tokenreviews-e2e-testuser"
 └─ Create OAuthClient "tokenreviews-e2e-client"
 └─ Create OAuthAccessToken with secret "tokenreviews-e2e-secret-value-for-testing"

Scenario A — Invalid token
 └─ POST TokenReview with a non-existent/garbage token
 └─ Expect: authenticated = false

Scenario B — Valid token
 └─ Compute resource name: sha256~<base64(SHA256(secret))>
 └─ POST TokenReview with the real token secret
 └─ Expect: authenticated = true, username matches

Teardown
 └─ ResourceTrashbin.Empty() deletes all created resources
Why SHA256? OpenShift doesn't store raw token secrets. The OAuthAccessToken resource name is derived as sha256~<base64-of-hash>. The tokenName() function performs this computation so the test can reference the token by its actual resource name.

Order matters: Testing the invalid case first confirms the API isn't accidentally open to anything — then the valid case proves it correctly authenticates a token that does exist.

Test Label
[sig-auth] OAuth should successfully review valid and invalid tokens [Component][Serial][apigroup:oauth.openshift.io]
Picked up by the openshift/oauth-apiserver/component/serial suite defined in
cmd/oauth-apiserver-tests-ext/main.go.

Local Verification
Ran 1 of 1 Specs in 2.902 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 0 Skipped
Related

Infrastructure PR: CNTRLPLANE-2260:cmd/oauth-apiserver-tests-ext: Update OTE framework integration #162 (merged ✅)

Suite wiring + vendor PR: CNTRLPLANE-2260: cmd: wire up OTE ginkgo suite for tokenreviews #163 (merged ✅)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

gangwgr · 2026-04-01T05:54:55Z

/lgtm

openshift-ci · 2026-04-01T05:55:13Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gangwgr, wangke19
Once this PR has been reviewed and has the lgtm label, please assign p0lyn0mial for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

wangke19 · 2026-04-07T20:30:42Z

/verified by CI

openshift-ci-robot · 2026-04-07T20:30:54Z

@wangke19: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Mar 23, 2026

openshift-ci Bot requested review from p0lyn0mial and sanchezl March 23, 2026 04:17

coderabbitai Bot reviewed Mar 23, 2026

View reviewed changes

Comment thread test/e2e/e2e.go Outdated

wangke19 force-pushed the ote-migrate-tokenreviews-vendor branch from 8c4d1ed to 6b2572e Compare March 23, 2026 05:06

coderabbitai Bot reviewed Mar 23, 2026

View reviewed changes

wangke19 mentioned this pull request Mar 23, 2026

CNTRLPLANE-2260: cmd: wire up OTE ginkgo suite for tokenreviews #163

Merged

wangke19 changed the title ~~CNTRLPLANE-2260: go.mod, vendor: add Ginkgo and OTE dependencies~~ CNTRLPLANE-2260: test/e2e: migrate tokenreviews test to OTE framework Mar 23, 2026

wangke19 force-pushed the ote-migrate-tokenreviews-vendor branch from 6b2572e to fe3bed2 Compare March 23, 2026 05:32

coderabbitai Bot reviewed Mar 23, 2026

View reviewed changes

Comment thread cmd/oauth-apiserver-tests-ext/main.go

wangke19 force-pushed the ote-migrate-tokenreviews-vendor branch from fe3bed2 to 5ddbdc4 Compare March 23, 2026 07:02

coderabbitai Bot reviewed Mar 23, 2026

View reviewed changes

wangke19 force-pushed the ote-migrate-tokenreviews-vendor branch from 5ddbdc4 to 6d57cb8 Compare March 27, 2026 08:33

coderabbitai Bot reviewed Mar 27, 2026

View reviewed changes

wangke19 force-pushed the ote-migrate-tokenreviews-vendor branch from 6d57cb8 to 9ff6244 Compare March 27, 2026 08:40

wangke19 force-pushed the ote-migrate-tokenreviews-vendor branch from 9ff6244 to a7551c9 Compare March 27, 2026 10:17

wangke19 force-pushed the ote-migrate-tokenreviews-vendor branch from a7551c9 to 911b698 Compare March 27, 2026 10:43

wangke19 force-pushed the ote-migrate-tokenreviews-vendor branch from 911b698 to 7987064 Compare March 27, 2026 11:33

wangke19 force-pushed the ote-migrate-tokenreviews-vendor branch 2 times, most recently from fd32acb to fbd12db Compare March 27, 2026 15:04

wangke19 changed the title ~~CNTRLPLANE-2260: test/e2e: migrate tokenreviews test to OTE framework~~ [WIP]CNTRLPLANE-2260: test/e2e: migrate tokenreviews test to OTE framework Mar 27, 2026

openshift-ci Bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 27, 2026

go.mod: mark ginkgo/v2 as direct dependency

0cfbc73

test/e2e/e2e.go now imports github.com/onsi/ginkgo/v2 directly; move it from indirect to direct in go.mod.

wangke19 force-pushed the ote-migrate-tokenreviews-vendor branch from fbd12db to 0cfbc73 Compare March 30, 2026 06:35

wangke19 changed the title ~~[WIP]CNTRLPLANE-2260: test/e2e: migrate tokenreviews test to OTE framework~~ CNTRLPLANE-2260: test/e2e: migrate tokenreviews test to OTE framework Mar 31, 2026

openshift-ci Bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 31, 2026

openshift-ci Bot assigned gangwgr Apr 1, 2026

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Apr 1, 2026

openshift-ci-robot added the verified Signifies that the PR passed pre-merge verification criteria label Apr 7, 2026

Conversation

wangke19 commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Historical Background: Why go test Was Never Running This Test

What This PR Does

Case Design

Test Label

Local Verification

Related

Uh oh!

openshift-ci-robot commented Mar 23, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Changes

Commit: Dependency updates only

Dependencies Added

Related

Uh oh!

coderabbitai Bot commented Mar 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Reviews paused

Walkthrough

Changes

Estimated code review effort

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Mar 27, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Commits

Commit 1: Test migration

OTE Discovery

Related

Uh oh!

coderabbitai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Mar 27, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Commits

Commit 1: Infrastructure code

Commit 2: Dependencies

OTE Discovery

Related

Uh oh!

openshift-ci-robot commented Mar 27, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Dual-Mode Pattern

Commits

Commit 1: Infrastructure code

Commit 2: Dependencies

Test Execution

OTE Discovery

Related

Uh oh!

openshift-ci-robot commented Mar 27, 2026 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Dual-Mode Pattern

Commits

Commit 1: Infrastructure code (177 additions, 144 deletions)

Commit 2: Dependencies (1 insertion, 1 deletion)

Test Execution

wangke19 commented Mar 23, 2026 •

edited

Loading

Historical Background: Why `go test` Was Never Running This Test

openshift-ci-robot commented Mar 23, 2026 •

edited by openshift-ci Bot

Loading

coderabbitai Bot commented Mar 23, 2026 •

edited

Loading

openshift-ci-robot commented Mar 27, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 27, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 27, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 27, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 27, 2026 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Mar 30, 2026 •

edited by openshift-ci Bot

Loading

Historical Background: Why `go test` Was Never Running This Test

openshift-ci-robot commented Mar 31, 2026 •

edited by openshift-ci Bot

Loading

Historical Background: Why `go test` Was Never Running This Test