CNTRLPLANE-3034:test/e2e: migrate crd-ca-bundle-injection to OTE serial suite#334
Conversation
Add testCRDCABundleInjection(testing.TB) and pollForCRDTB to e2e.go so the test runs under both the standard `go test` runner and the OTE Ginkgo suite via [Operator][Serial]. In e2e_test.go, replace the inline test body with a call to the shared function and remove the now-dead pollForCRD helper and its unused apiext/apiextclient imports. The update call is wrapped in retry.RetryOnConflict with a fresh Get inside the closure to avoid 409 conflicts from concurrent reconciliation. Relates to CNTRLPLANE-3000
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
WalkthroughAdded a new CRD CA bundle injection test context to Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes ✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Comment |
|
@wangke19: This pull request references CNTRLPLANE-3033 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/verified by CI |
|
@wangke19: This PR has been marked as verified by DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wangke19: This pull request references CNTRLPLANE-3034 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@wangke19: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: wangke19, zhouying7780 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Summary
Migrates the
crd-ca-bundle-injectiontest case to the OTE dual-mode framework, following the same pattern established in #332.testCRDCABundleInjection(testing.TB)andpollForCRDTBtoe2e.gowith[Operator][Serial]Ginkgo markere2e_test.gowith a delegating call + NOTE commentpollForCRDhelper and unusedapiext/apiextclientimports frome2e_test.goretry.RetryOnConflictwith a freshGetto avoid 409 conflicts from concurrent reconciliationNo
[Disruptive]label needed — no CA rotation is triggered.Relates to CNTRLPLANE-3000