CNTRLPLANE-3038: test/e2e: migrate validatingwebhook-ca-bundle-injection to OTE serial suite

[wangke19]

Summary

Migrates the validatingwebhook-ca-bundle-injection test case to the OTE dual-mode framework — the final case in the CA bundle injection series (#332, #334, #335).

• Adds testValidatingWebhookCABundleInjection(testing.TB) and pollForValidatingWebhookConfigurationTB to e2e.go with [Operator][Serial] Ginkgo marker
• Replaces the ~80-line inline body in e2e_test.go with a delegating call + NOTE comment
• Removes now-dead pollForValidatingWebhookConfiguration and checkWebhookCABundle helpers from e2e_test.go
• With both webhook tests now migrated, the shared webhookClientConfig/sideEffectNone variables and admissionreg/admissionregclient imports are also removed from e2e_test.go
• Both update calls (corrupt + add-webhook) are wrapped in retry.RetryOnConflict with a fresh Get to avoid 409 conflicts from concurrent reconciliation

No [Disruptive] label needed — no CA rotation is triggered.

Relates to CNTRLPLANE-3000

[openshift-ci-robot]

@wangke19: This pull request references CNTRLPLANE-3038 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.22.0" version, but no target version was set.

Details

In response to this:

Summary

Migrates the validatingwebhook-ca-bundle-injection test case to the OTE dual-mode framework — the final case in the CA bundle injection series (#332, #334, #335).

• Adds testValidatingWebhookCABundleInjection(testing.TB) and pollForValidatingWebhookConfigurationTB to e2e.go with [Operator][Serial] Ginkgo marker
• Replaces the ~80-line inline body in e2e_test.go with a delegating call + NOTE comment
• Removes now-dead pollForValidatingWebhookConfiguration and checkWebhookCABundle helpers from e2e_test.go
• With both webhook tests now migrated, the shared webhookClientConfig/sideEffectNone variables and admissionreg/admissionregclient imports are also removed from e2e_test.go
• Both update calls (corrupt + add-webhook) are wrapped in retry.RetryOnConflict with a fresh Get to avoid 409 conflicts from concurrent reconciliation

No [Disruptive] label needed — no CA rotation is triggered.

Relates to CNTRLPLANE-3000

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 64f47da3-36c6-4fd5-8f47-7c87e31fcde8

📥 Commits

Reviewing files that changed from the base of the PR and between 87f886a and 9155c5d.

📒 Files selected for processing (2)

• test/e2e/e2e.go
• test/e2e/e2e_test.go

---

Walkthrough

Changes refactor validating webhook CA bundle injection testing by extracting inline test logic from e2e_test.go into dedicated functions (testValidatingWebhookCABundleInjection, pollForValidatingWebhookConfigurationTB) in e2e.go, reorganizing test structure while preserving functionality.

Changes

Cohort / File(s)	Summary
E2E Test Refactoring test/e2e/e2e.go	Introduced polling helper pollForValidatingWebhookConfigurationTB and test function testValidatingWebhookCABundleInjection that creates a ValidatingWebhookConfiguration, injects CA bundles, mutates and validates restoration, appends webhooks, and verifies CA bundle presence across all webhooks using retry.RetryOnConflict.
E2E Test Refactoring test/e2e/e2e_test.go	Removed inline test helpers pollForValidatingWebhookConfiguration and checkWebhookCABundle, deleted validation logic from TestE2E, replaced with delegation to testValidatingWebhookCABundleInjection(t), and removed admissionregistration-related imports.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

📝 Coding Plan

• Generate coding plan for human review comments

---

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[openshift-ci]

@wangke19: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[wangke19]

/verified by CI

[gangwgr]

/lgtm

[openshift-ci-robot]

@wangke19: This PR has been marked as verified by CI.

Details

In response to this:

/verified by CI

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gangwgr, wangke19

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• test/OWNERS [wangke19]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment