Bug 1810959: oc adm inspect namespace doesn't collect pod logs
#245
Conversation
Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com> This commit fixes wrong placement of waitgroup.Add function in log collection method for `oc adm inspect` command.
openshift-ci-robot
added
the
size/XS
|
/lgtm |
openshift-ci-robot
added
lgtm
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ashishranjan738, mfojtik, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
5 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/cherrypick release-4.3 |
|
@ashishranjan738: new pull request created: #290 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
ashishranjan738
changed the title
oc adm inspect namespace doesn't collect pod logs
ashishranjan738
changed the title
oc adm inspect namespace doesn't collect pod logsoc adm inspect namespace doesn't collect pod logs
|
@ashishranjan738: All pull requests linked via external trackers have merged. Bugzilla bug 1810959 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.3 |
|
@ashishranjan738: failed to push cherry-picked changes in GitHub: pushing failed, output: "To https://github.com/openshift-cherrypick-robot/oc\n ! [rejected] cherry-pick-245-to-release-4.3 -> cherry-pick-245-to-release-4.3 (non-fast-forward)\nerror: failed to push some refs to 'https://openshift-cherrypick-robot:CENSORED@github.com/openshift-cherrypick-robot/oc'\nhint: Updates were rejected because the tip of your current branch is behind\nhint: its remote counterpart. Integrate the remote changes (e.g.\nhint: 'git pull ...') before pushing again.\nhint: See the 'Note about fast-forwards' in 'git push --help' for details.\n", error: exit status 1 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
7 participants
Signed-off-by: Ashish Ranjan ashishranjan738@gmail.com
This commit fixes wrong placement of
waitgroup.Addfunction in log collection method foroc adm inspectcommand. Thewaitgroup.Addfunction should be called before the goroutine is called.