Bug 1810959: `oc adm inspect namespace` doesn't collect pod logs #290

openshift-cherrypick-robot · 2020-02-10T14:48:04Z

This is an automated cherry-pick of #245

/assign ashishranjan738

Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com> This commit fixes wrong placement of waitgroup.Add function in log collection method for `oc adm inspect` command.

openshift-ci-robot · 2020-02-10T14:48:06Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.3] Fixes wrong placement of waitgroup.Add function

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh

/lgtm
/approve

openshift-ci-robot · 2020-03-06T09:24:48Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ashishranjan738 · 2020-03-06T10:23:22Z

/close

openshift-ci-robot · 2020-03-06T10:23:24Z

@ashishranjan738: Closed this PR.

Details

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ashishranjan738 · 2020-03-06T10:25:31Z

/reopen

openshift-ci-robot · 2020-03-06T10:25:33Z

@ashishranjan738: Reopened this PR.

Details

In response to this:

/reopen

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-06T10:25:33Z

@openshift-cherrypick-robot: No Bugzilla bug is referenced in the title of this pull request.
To reference a bug, add 'Bug XXX:' to the title of this pull request and request another bug refresh with /bugzilla refresh.

Details

In response to this:

[release-4.3] Fixes wrong placement of waitgroup.Add function

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ashishranjan738 · 2020-03-06T10:29:35Z

/retitle Bug 1810959: oc adm inspect namespace doesn't collect pod logs

openshift-ci-robot · 2020-03-06T10:29:38Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1810959, which is invalid:

expected the bug to target the "4.3.z" release, but it targets "---" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
expected Bugzilla bug 1810959 to depend on a bug targeting the "4.4.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1810959: oc adm inspect namespace doesn't collect pod logs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ashishranjan738 · 2020-03-06T10:31:12Z

/bugzilla refresh

openshift-ci-robot · 2020-03-06T10:31:14Z

@ashishranjan738: This pull request references Bugzilla bug 1810959, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
expected Bugzilla bug 1810959 to depend on a bug targeting the "4.4.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ashishranjan738 · 2020-03-06T10:50:14Z

/bugzilla refresh

openshift-ci-robot · 2020-03-06T10:50:16Z

@ashishranjan738: This pull request references Bugzilla bug 1810959, which is invalid:

expected Bugzilla bug 1810959 to depend on a bug targeting the "4.4.0" release and in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ashishranjan738 · 2020-03-06T11:02:04Z

/bugzilla refresh

openshift-ci-robot · 2020-03-06T11:02:08Z

@ashishranjan738: This pull request references Bugzilla bug 1810959, which is invalid:

expected dependent Bugzilla bug 1810987 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-03-07T04:20:39Z

/retest

Please review the full test history for this PR and help us cut down flakes.

ashishranjan738 · 2020-03-09T07:55:20Z

/bugzilla refresh

openshift-ci-robot · 2020-03-09T07:55:27Z

@ashishranjan738: This pull request references Bugzilla bug 1810959, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.3.z) matches configured target release for branch (4.3.z)
bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1810987 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1810987 targets the "4.4.0" release, matching the expected (4.4.0) release
bug has dependents

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ashishranjan738 · 2020-03-09T07:58:24Z

/label cherry-pick-approved

openshift-ci-robot · 2020-03-09T07:58:25Z

@ashishranjan738: The label(s) /label cherry-pick-approved cannot be applied. These labels are supported: platform/aws, platform/azure, platform/baremetal, platform/google, platform/libvirt, platform/openstack, ga, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash

Details

In response to this:

/label cherry-pick-approved

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2020-03-10T18:53:55Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-10T19:06:34Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-bot · 2020-03-10T20:25:05Z

/retest

Please review the full test history for this PR and help us cut down flakes.

openshift-ci-robot · 2020-03-10T21:26:52Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1810959 has been moved to the MODIFIED state.

Details

In response to this:

Bug 1810959: oc adm inspect namespace doesn't collect pod logs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Fixes wrong placement of waitgroup.Add function

f01da1e

Signed-off-by: Ashish Ranjan <ashishranjan738@gmail.com> This commit fixes wrong placement of waitgroup.Add function in log collection method for `oc adm inspect` command.

openshift-ci-robot assigned ashishranjan738 Feb 10, 2020

openshift-cherrypick-robot mentioned this pull request Feb 10, 2020

Bug 1810959: oc adm inspect namespace doesn't collect pod logs #245

Merged

openshift-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 10, 2020

openshift-ci-robot requested review from smarterclayton and soltysh February 10, 2020 14:49

soltysh approved these changes Mar 6, 2020

View reviewed changes

openshift-ci-robot assigned soltysh Mar 6, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020

openshift-ci-robot closed this Mar 6, 2020

openshift-ci-robot reopened this Mar 6, 2020

openshift-ci-robot changed the title ~~[release-4.3] Fixes wrong placement of waitgroup.Add function~~ Bug 1810959: oc adm inspect namespace doesn't collect pod logs Mar 6, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 6, 2020

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 9, 2020

sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 10, 2020

openshift-merge-robot merged commit b1ecc64 into openshift:release-4.3 Mar 10, 2020

Bug 1810959: oc adm inspect namespace doesn't collect pod logs #290

Bug 1810959: oc adm inspect namespace doesn't collect pod logs #290

Uh oh!

Conversation

openshift-cherrypick-robot commented Feb 10, 2020

Uh oh!

openshift-ci-robot commented Feb 10, 2020

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Mar 6, 2020

Uh oh!

ashishranjan738 commented Mar 6, 2020

Uh oh!

openshift-ci-robot commented Mar 6, 2020

Uh oh!

ashishranjan738 commented Mar 6, 2020

Uh oh!

openshift-ci-robot commented Mar 6, 2020

Uh oh!

openshift-ci-robot commented Mar 6, 2020

Uh oh!

ashishranjan738 commented Mar 6, 2020

Uh oh!

openshift-ci-robot commented Mar 6, 2020

Uh oh!

ashishranjan738 commented Mar 6, 2020

Uh oh!

openshift-ci-robot commented Mar 6, 2020

Uh oh!

ashishranjan738 commented Mar 6, 2020

Uh oh!

openshift-ci-robot commented Mar 6, 2020

Uh oh!

ashishranjan738 commented Mar 6, 2020

Uh oh!

openshift-ci-robot commented Mar 6, 2020

Uh oh!

openshift-bot commented Mar 7, 2020

Uh oh!

ashishranjan738 commented Mar 9, 2020

Uh oh!

openshift-ci-robot commented Mar 9, 2020

Uh oh!

ashishranjan738 commented Mar 9, 2020

Uh oh!

openshift-ci-robot commented Mar 9, 2020

Uh oh!

openshift-bot commented Mar 10, 2020

Uh oh!

openshift-bot commented Mar 10, 2020

Uh oh!

openshift-bot commented Mar 10, 2020

Uh oh!

openshift-ci-robot commented Mar 10, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Bug 1810959: `oc adm inspect namespace` doesn't collect pod logs #290

Bug 1810959: `oc adm inspect namespace` doesn't collect pod logs #290