[release-4.4] Bug 1810268: Don't default to always mirror manifestlists #341

openshift-cherrypick-robot · 2020-03-05T01:20:27Z

This is an automated cherry-pick of #339

/assign kevinrizza

A previous commit introduced new behavior to always mirror manifest list digests when running `oc image mirror`. This commit reverts that behavior, and instead adds a flag `--force-manifest-list` to allow that option. Additionally, the force behavior occurs when `--filter-by-os` is set to a wildcard.

openshift-ci-robot · 2020-03-05T01:20:30Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1810256, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "4.5.0" instead
expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
expected Bugzilla bug 1810256 to depend on a bug targeting the "4.5.0" release and in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1810256: Don't default to always mirror manifestlists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

kevinrizza · 2020-03-05T01:47:34Z

/bugzilla refresh

openshift-ci-robot · 2020-03-05T01:47:36Z

@kevinrizza: This pull request references Bugzilla bug 1810256, which is invalid:

expected the bug to target the "4.4.0" release, but it targets "4.5.0" instead
expected Bugzilla bug 1810256 to depend on a bug targeting the "4.5.0" release and in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh

/lgtm
/approve

openshift-ci-robot · 2020-03-05T12:49:16Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [soltysh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2020-03-05T12:50:28Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1810268, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.0) matches configured target release for branch (4.4.0)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1810256 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1810256 targets the "4.5.0" release, matching the expected (4.5.0) release
bug has dependents

Details

In response to this:

[release-4.4] Bug 1810268: Don't default to always mirror manifestlists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh · 2020-03-05T12:50:55Z

/retest

kevinrizza · 2020-03-05T12:57:33Z

/cherry-pick release-4.3

openshift-cherrypick-robot · 2020-03-05T12:57:34Z

@kevinrizza: once the present PR merges, I will cherry-pick it on top of release-4.3 in a new PR and assign it to you.

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ecordell · 2020-03-05T13:50:23Z

/retitle [release-4.4] Bug 1809528: Don't default to always mirror manifestlists

openshift-ci-robot · 2020-03-05T13:50:29Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1809528, which is invalid:

expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
expected Bugzilla bug 1809528 to depend on a bug targeting the "4.5.0" release and in one of the following states: MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but no dependents were found

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.4] Bug 1809528: Don't default to always mirror manifestlists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

ecordell · 2020-03-05T13:51:21Z

/retitle [release-4.4] Bug 1810268: Don't default to always mirror manifestlists

openshift-ci-robot · 2020-03-05T13:51:30Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1810268, which is valid.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.4.0) matches configured target release for branch (4.4.0)
bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1810256 is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
dependent Bugzilla bug 1810256 targets the "4.5.0" release, matching the expected (4.5.0) release
bug has dependents

Details

In response to this:

[release-4.4] Bug 1810268: Don't default to always mirror manifestlists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2020-03-05T14:22:51Z

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1810268 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.4] Bug 1810268: Don't default to always mirror manifestlists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot · 2020-03-05T14:23:13Z

@kevinrizza: new pull request created: #342

Details

In response to this:

/cherry-pick release-4.3

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-cherrypick-robot mentioned this pull request Mar 5, 2020

Bug 1810256: Don't default to always mirror manifestlists #339

Merged

openshift-ci-robot assigned kevinrizza Mar 5, 2020

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2020

openshift-ci-robot requested review from deads2k and soltysh March 5, 2020 01:21

soltysh approved these changes Mar 5, 2020

View reviewed changes

openshift-ci-robot assigned soltysh Mar 5, 2020

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 5, 2020

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 5, 2020

soltysh changed the title ~~[release-4.4] Bug 1810256: Don't default to always mirror manifestlists~~ [release-4.4] Bug 1810268: Don't default to always mirror manifestlists Mar 5, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 5, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 5, 2020

openshift-ci-robot changed the title ~~[release-4.4] Bug 1810268: Don't default to always mirror manifestlists~~ [release-4.4] Bug 1809528: Don't default to always mirror manifestlists Mar 5, 2020

openshift-ci-robot removed the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 5, 2020

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 5, 2020

openshift-ci-robot changed the title ~~[release-4.4] Bug 1809528: Don't default to always mirror manifestlists~~ [release-4.4] Bug 1810268: Don't default to always mirror manifestlists Mar 5, 2020

openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 5, 2020

openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 5, 2020

openshift-merge-robot merged commit 2576e48 into openshift:release-4.4 Mar 5, 2020

openshift-cherrypick-robot mentioned this pull request Mar 5, 2020

[release-4.3] Bug 1810533: Don't default to always mirror manifestlists #342

Merged

[release-4.4] Bug 1810268: Don't default to always mirror manifestlists #341

[release-4.4] Bug 1810268: Don't default to always mirror manifestlists #341

Uh oh!

Conversation

openshift-cherrypick-robot commented Mar 5, 2020

Uh oh!

openshift-ci-robot commented Mar 5, 2020

Uh oh!

kevinrizza commented Mar 5, 2020

Uh oh!

openshift-ci-robot commented Mar 5, 2020

Uh oh!

soltysh left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Mar 5, 2020

Uh oh!

openshift-ci-robot commented Mar 5, 2020

Uh oh!

soltysh commented Mar 5, 2020

Uh oh!

kevinrizza commented Mar 5, 2020

Uh oh!

openshift-cherrypick-robot commented Mar 5, 2020

Uh oh!

ecordell commented Mar 5, 2020

Uh oh!

openshift-ci-robot commented Mar 5, 2020

Uh oh!

ecordell commented Mar 5, 2020

Uh oh!

openshift-ci-robot commented Mar 5, 2020

Uh oh!

openshift-ci-robot commented Mar 5, 2020

Uh oh!

openshift-cherrypick-robot commented Mar 5, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants