Skip to content

[release-4.3] Bug 1810533: Don't default to always mirror manifestlists #342

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 11, 2020
Merged

[release-4.3] Bug 1810533: Don't default to always mirror manifestlists #342

openshift-merge-robot merged 1 commit into from
Mar 11, 2020

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Mar 5, 2020

This is an automated cherry-pick of #341

/assign kevinrizza

@kevinrizza
Don't default to always mirror manifestlists
919f3e4 
A previous commit introduced new behavior to always mirror manifest list
digests when running `oc image mirror`. This commit reverts that
behavior, and instead adds a flag `--force-manifest-list` to allow that
option. Additionally, the force behavior occurs when `--filter-by-os` is
set to a wildcard.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 5, 2020
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1810268, which is invalid:

  • expected the bug to target the "4.3.z" release, but it targets "4.4.0" instead
  • expected the bug to be in one of the following states: NEW, ASSIGNED, ON_DEV, POST, POST, but it is MODIFIED instead
  • expected dependent Bugzilla bug 1810256 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead
  • expected dependent Bugzilla bug 1810256 to target the "4.4.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] [release-4.4] Bug 1810268: Don't default to always mirror manifestlists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Mar 5, 2020
@kevinrizza
Copy link
Member

kevinrizza commented Mar 5, 2020

@soltysh Looks like cherry pick didn't play nice for some reason. Can you edit the title to point to this bz instead? https://bugzilla.redhat.com/show_bug.cgi?id=1810533 I don't have permission

/cc @ecordell @shawn-hurley

@ecordell
Copy link
Contributor

ecordell commented Mar 5, 2020

/retitle [release-4.3] Bug 1810533: Don't default to always mirror manifestlists

@openshift-ci-robot openshift-ci-robot changed the title [release-4.3] [release-4.4] Bug 1810268: Don't default to always mirror manifestlists [release-4.3] Bug 1810533: Don't default to always mirror manifestlists Mar 5, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2020

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1810533, which is invalid:

  • expected dependent Bugzilla bug 1810256 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1810268 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1810256 to target the "4.4.0" release, but it targets "4.5.0" instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.3] Bug 1810533: Don't default to always mirror manifestlists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Contributor

ecordell commented Mar 5, 2020

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 5, 2020

@ecordell: This pull request references Bugzilla bug 1810533, which is invalid:

  • expected dependent Bugzilla bug 1810268 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

soltysh
soltysh approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 6, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 6, 2020

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 6, 2020
@kevinrizza
Copy link
Member

kevinrizza commented Mar 10, 2020

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 10, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 10, 2020

@kevinrizza: This pull request references Bugzilla bug 1810533, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.3.z) matches configured target release for branch (4.3.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1810268 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA))
  • dependent Bugzilla bug 1810268 targets the "4.4.0" release, matching the expected (4.4.0) release
  • bug has dependents
Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sdodson sdodson added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 10, 2020
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

3 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 10, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 11, 2020

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit 62c8cca into openshift:release-4.3 Mar 11, 2020
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 11, 2020

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged. Bugzilla bug 1810533 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.3] Bug 1810533: Don't default to always mirror manifestlists

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@deads2k deads2k Awaiting requested review from deads2k

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

@ecordell ecordell Awaiting requested review from ecordell

@shawn-hurley shawn-hurley Awaiting requested review from shawn-hurley

1 more reviewer

@soltysh soltysh soltysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@soltysh soltysh

@kevinrizza kevinrizza

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@openshift-cherrypick-robot @openshift-ci-robot @kevinrizza @ecordell @openshift-bot @soltysh @sdodson @openshift-merge-robot