Skip to content

[release-4.7] Bug 1942059: when mirroring to a file destination, mount images under the index location #779

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-robot merged 1 commit into from
Mar 25, 2021
Merged

[release-4.7] Bug 1942059: when mirroring to a file destination, mount images under the index location #779

openshift-merge-robot merged 1 commit into from
Mar 25, 2021

Conversation

@openshift-cherrypick-robot
Copy link

@openshift-cherrypick-robot openshift-cherrypick-robot commented Mar 23, 2021

This is an automated cherry-pick of #772

/assign ecordell

@ecordell
when mirroring to a file destination, mount images under the index
cb66da0 
when mirroring an index image: quay.io/my/index:a
that contains a reference to another image: quay.io/other/bundle:1
to a local file: file:///local/index

the referenced images are now mounted under the location for the index
itself, resulting in (for example):

file:///local/index/my/index:a
file:///local/index/my/index/other/bundle:1

this fixes a bug where the next step of an airgap mirror can't find the
images to be mirrored.

as a side effect, this keeps all catalog content stored under the same
fs location. Local file storage can be shared with other mirrored
images while keeping it simple to copy the full contents of an index
to another location.
@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 23, 2021
Merged
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 23, 2021

@openshift-cherrypick-robot: Bugzilla bug 1919168 has been cloned as Bugzilla bug 1942059. Retitling PR to link against new bug.
/retitle [release-4.7] Bug 1942059: when mirroring to a file destination, mount images under the index location

Details

In response to this:

[release-4.7] Bug 1919168: when mirroring to a file destination, mount images under the index location

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot changed the title [release-4.7] Bug 1919168: when mirroring to a file destination, mount images under the index location [release-4.7] Bug 1942059: when mirroring to a file destination, mount images under the index location Mar 23, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 23, 2021

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1942059, which is invalid:

  • expected dependent Bugzilla bug 1919168 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.7] Bug 1942059: when mirroring to a file destination, mount images under the index location

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Mar 23, 2021
@ecordell
Copy link
Contributor

ecordell commented Mar 24, 2021

/approve
/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added the bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. label Mar 24, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 24, 2021

@ecordell: This pull request references Bugzilla bug 1942059, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target release (4.7.z) matches configured target release for branch (4.7.z)
  • bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
  • dependent bug Bugzilla bug 1919168 is in the state VERIFIED, which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
  • dependent Bugzilla bug 1919168 targets the "4.8.0" release, which is one of the valid target releases: 4.8.0
  • bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

/approve
/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot removed the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 24, 2021
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 24, 2021
@ecordell
Copy link
Contributor

ecordell commented Mar 24, 2021

/retest
/cherry-pick release-4.6

@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Mar 24, 2021

@ecordell: once the present PR merges, I will cherry-pick it on top of release-4.6 in a new PR and assign it to you.

Details

In response to this:

/retest
/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ecordell
Copy link
Contributor

ecordell commented Mar 24, 2021

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 24, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 24, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ecordell, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jwforres jwforres added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Mar 24, 2021
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 24, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

5 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 24, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 25, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 25, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 25, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Mar 25, 2021

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-merge-robot openshift-merge-robot merged commit d0ceebe into openshift:release-4.7 Mar 25, 2021
@openshift-ci-robot
Copy link

openshift-ci-robot commented Mar 25, 2021

@openshift-cherrypick-robot: All pull requests linked via external trackers have merged:

Bugzilla bug 1942059 has been moved to the MODIFIED state.

Details

In response to this:

[release-4.7] Bug 1942059: when mirroring to a file destination, mount images under the index location

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Mar 25, 2021
Closed
@openshift-cherrypick-robot
Copy link
Author

openshift-cherrypick-robot commented Mar 25, 2021

@ecordell: new pull request created: #781

Details

In response to this:

/retest
/cherry-pick release-4.6

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ecordell ecordell Awaiting requested review from ecordell

@soltysh soltysh Awaiting requested review from soltysh

@jianzhangbjz jianzhangbjz Awaiting requested review from jianzhangbjz

Assignees

@ecordell ecordell

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@openshift-cherrypick-robot @openshift-ci-robot @ecordell @openshift-bot @jwforres @openshift-merge-robot