[release-4.6] [release-4.7] Bug 1942818: when mirroring to a file destination, mount images under the index location #781

openshift-cherrypick-robot · 2021-03-25T04:29:14Z

This is an automated cherry-pick of #779

/assign ecordell

when mirroring an index image: quay.io/my/index:a that contains a reference to another image: quay.io/other/bundle:1 to a local file: file:///local/index the referenced images are now mounted under the location for the index itself, resulting in (for example): file:///local/index/my/index:a file:///local/index/my/index/other/bundle:1 this fixes a bug where the next step of an airgap mirror can't find the images to be mirrored. as a side effect, this keeps all catalog content stored under the same fs location. Local file storage can be shared with other mirrored images while keeping it simple to copy the full contents of an index to another location.

openshift-ci-robot · 2021-03-25T04:29:22Z

@openshift-cherrypick-robot: Bugzilla bug 1942059 has been cloned as Bugzilla bug 1942818. Retitling PR to link against new bug.
/retitle [release-4.6] [release-4.7] Bug 1942818: when mirroring to a file destination, mount images under the index location

Details

In response to this:

[release-4.6] [release-4.7] Bug 1942059: when mirroring to a file destination, mount images under the index location

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot · 2021-03-25T04:29:33Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: openshift-cherrypick-robot
To complete the pull request process, please assign ecordell after the PR has been reviewed.
You can assign the PR to them by writing /assign @ecordell in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

pkg/cli/admin/catalog/OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

openshift-ci-robot · 2021-03-25T04:29:37Z

@openshift-cherrypick-robot: This pull request references Bugzilla bug 1942818, which is invalid:

expected dependent Bugzilla bug 1942059 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.6] [release-4.7] Bug 1942818: when mirroring to a file destination, mount images under the index location

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci · 2021-03-25T06:00:34Z

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/unit	`669f6d5`	link	`/test unit`
ci/prow/verify	`669f6d5`	link	`/test verify`
ci/prow/e2e-agnostic-cmd	`669f6d5`	link	`/test e2e-agnostic-cmd`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

openshift-bot · 2021-06-23T07:59:05Z

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

ecordell · 2021-06-23T13:58:15Z

/bugzilla refresh

openshift-ci · 2021-06-23T13:58:30Z

@ecordell: This pull request references Bugzilla bug 1942818, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

6 validation(s) were run on this bug

bug is open, matching expected state (open)
bug target release (4.6.z) matches configured target release for branch (4.6.z)
bug is in the state NEW, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)
dependent bug Bugzilla bug 1942059 is in the state CLOSED (ERRATA), which is one of the valid states (VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), CLOSED (CURRENTRELEASE))
dependent Bugzilla bug 1942059 targets the "4.7.z" release, which is one of the valid target releases: 4.7.0, 4.7.z
bug has dependents

Requesting review from QA contact:
/cc @jianzhangbjz

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-bot · 2021-07-23T17:42:40Z

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.
Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten
/remove-lifecycle stale

timflannagan · 2021-08-05T13:27:21Z

pkg/cli/admin/catalog/mirrorer_test.go

+				mustParseRef(t, "quay.io/test/prometheus.0.14.0:latest"): mustParseRef(t, "file://local/index/example/image/test/prometheus.0.14.0:latest"),
+				mustParseRef(t, "quay.io/coreos/etcd-operator@sha256:db563baa8194fcfe39d1df744ed70024b0f1f9e9b55b5923c2f3a413c44dc6b8"): {
+					Type: imagesource.DestinationFile,
+					Ref: reference.DockerImageReference{


s/reference/imgref:

oc/pkg/cli/admin/catalog/mirrorer_test.go

Line 7 in 669f6d5

imgref "github.com/openshift/library-go/pkg/image/reference"

.

openshift-bot · 2021-09-04T14:27:24Z

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci · 2021-09-04T14:27:44Z

@openshift-bot: Closed this PR.

Details

In response to this:

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen.
Mark the issue as fresh by commenting /remove-lifecycle rotten.
Exclude this issue from closing again by commenting /lifecycle frozen.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

openshift-ci-robot assigned ecordell Mar 25, 2021

openshift-cherrypick-robot mentioned this pull request Mar 25, 2021

[release-4.7] Bug 1942059: when mirroring to a file destination, mount images under the index location #779

Merged

openshift-ci-robot changed the title ~~[release-4.6] [release-4.7] Bug 1942059: when mirroring to a file destination, mount images under the index location~~ [release-4.6] [release-4.7] Bug 1942818: when mirroring to a file destination, mount images under the index location Mar 25, 2021

openshift-ci-robot requested review from ecordell and smarterclayton March 25, 2021 04:29

openshift-ci-robot added the bugzilla/severity-medium Referenced Bugzilla bug's severity is medium for the branch this PR is targeting. label Mar 25, 2021

openshift-ci-robot added the bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. label Mar 25, 2021

openshift-ci bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 23, 2021

openshift-ci bot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Jun 23, 2021

openshift-ci bot requested a review from jianzhangbjz June 23, 2021 13:58

openshift-ci bot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 23, 2021

timflannagan reviewed Aug 5, 2021

View reviewed changes

timflannagan mentioned this pull request Aug 5, 2021

[release-4.6] Bug 1942818: when mirroring to a file destination, mount images under the index location #892

Merged

openshift-ci bot closed this Sep 4, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[release-4.6] [release-4.7] Bug 1942818: when mirroring to a file destination, mount images under the index location #781

[release-4.6] [release-4.7] Bug 1942818: when mirroring to a file destination, mount images under the index location #781

Uh oh!

openshift-cherrypick-robot commented Mar 25, 2021

Uh oh!

openshift-ci-robot commented Mar 25, 2021

Uh oh!

openshift-ci-robot commented Mar 25, 2021

Uh oh!

openshift-ci-robot commented Mar 25, 2021

Uh oh!

openshift-ci bot commented Mar 25, 2021

Uh oh!

openshift-bot commented Jun 23, 2021

Uh oh!

ecordell commented Jun 23, 2021

Uh oh!

openshift-ci bot commented Jun 23, 2021

Uh oh!

openshift-bot commented Jul 23, 2021

Uh oh!

timflannagan Aug 5, 2021

Uh oh!

openshift-bot commented Sep 4, 2021

Uh oh!

openshift-ci bot commented Sep 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

[release-4.6] [release-4.7] Bug 1942818: when mirroring to a file destination, mount images under the index location #781

[release-4.6] [release-4.7] Bug 1942818: when mirroring to a file destination, mount images under the index location #781

Uh oh!

Conversation

openshift-cherrypick-robot commented Mar 25, 2021

Uh oh!

openshift-ci-robot commented Mar 25, 2021

Uh oh!

openshift-ci-robot commented Mar 25, 2021

Uh oh!

openshift-ci-robot commented Mar 25, 2021

Uh oh!

openshift-ci bot commented Mar 25, 2021

Uh oh!

openshift-bot commented Jun 23, 2021

Uh oh!

ecordell commented Jun 23, 2021

Uh oh!

openshift-ci bot commented Jun 23, 2021

Uh oh!

openshift-bot commented Jul 23, 2021

Uh oh!

timflannagan Aug 5, 2021

Choose a reason for hiding this comment

Uh oh!

openshift-bot commented Sep 4, 2021

Uh oh!

openshift-ci bot commented Sep 4, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants