API-1863: Rebase 1.31 by dinhxuanvu · Pull Request #458 · openshift/openshift-apiserver

dinhxuanvu · 2024-11-05T17:16:40Z

No description provided.

dinhxuanvu · 2024-11-05T17:30:04Z

Waiting for openshift/kubernetes-apiserver#60 to merge first.

openshift-ci-robot · 2024-11-06T17:41:42Z

@dinhxuanvu: This pull request references API-1820 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

openshift-ci-robot · 2024-11-06T17:45:01Z

@dinhxuanvu: This pull request references API-1863 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.

Details

In response to this:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

dinhxuanvu · 2024-11-07T18:43:25Z

/test e2e-aws-ovn-cmd

dinhxuanvu · 2024-11-07T20:56:32Z

/retest-required

dinhxuanvu · 2024-11-07T23:54:42Z

/test e2e-aws-ovn-cmd

dinhxuanvu · 2024-11-09T01:08:35Z

/test e2e-aws-ovn-cmd

dinhxuanvu · 2024-11-09T04:09:47Z

@p0lyn0mial @tkashem PTAL

Signed-off-by: Vu Dinh <vudinh@outlook.com>

dinhxuanvu · 2024-11-12T17:24:11Z

@p0lyn0mial @tkashem Updated and ready for final review.

p0lyn0mial · 2024-11-13T08:24:59Z

-	k8s.io/utils v0.0.0-20230726121419-3b25d923346b
+	k8s.io/kubectl v0.31.1
+	k8s.io/kubernetes v1.31.1
+	k8s.io/utils v0.0.0-20240921022957-49e7df575cb6


kube in 1.31 uses utils in v0.0.0-20240711033017-18e509b52bc8 version

https://github.com/kubernetes/kubernetes/blob/release-1.31/go.mod#L120C37-L120C49

why not to use the same version ?

This is the result of go mod tidy/vendor cmd. I didn't manually change the k8s.io/utils. Only updated the dependencies with semver versioning.

p0lyn0mial · 2024-11-13T08:38:44Z

 	"k8s.io/client-go/rest"
 	"k8s.io/component-base/featuregate"
 	aggregatorapiserver "k8s.io/kube-aggregator/pkg/apiserver"
+	controlplaneadmission "k8s.io/kubernetes/pkg/controlplane/apiserver/admission"


I think this is okay, before we used k8s.io/kubernetes/pkg/kubeapiserver and now we will also be using k8s.io/kubernetes/pkg/controlplane

p0lyn0mial · 2024-11-13T08:40:59Z

+	objectMetaShallowCopy := review.ObjectMeta
+	objectMetaShallowCopy.Namespace = ""
+	objectMetaShallowCopy.ManagedFields = nil
+	if !equality.Semantic.DeepEqual(metav1.ObjectMeta{}, objectMetaShallowCopy) {


I think this is also okay, since the resources are not persisted.

Signed-off-by: Vu Dinh <vudinh@outlook.com>

- update missing genclient:skipVerbs to authorization types - add validation to require empty ObjectMeta

Signed-off-by: Vu Dinh <vudinh@outlook.com>

p0lyn0mial · 2024-11-13T10:04:47Z

/lgtm

openshift-ci · 2024-11-13T10:05:36Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dinhxuanvu, p0lyn0mial

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~OWNERS~~ [p0lyn0mial]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

chiragkyal · 2024-11-13T12:41:52Z

/test okd-scos-e2e-aws-ovn
/test e2e-aws-ovn-serial

openshift-ci · 2024-11-13T16:17:32Z

@dinhxuanvu: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/okd-scos-e2e-aws-ovn	`65ff9ae`	link	false	`/test okd-scos-e2e-aws-ovn`

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

openshift-bot · 2024-11-14T02:01:15Z

[ART PR BUILD NOTIFIER]

Distgit: ose-openshift-apiserver
This PR has been included in build ose-openshift-apiserver-container-v4.19.0-202411140108.p0.g53c5b3a.assembly.stream.el9.
All builds following this will include this PR.

openshift-ci Bot requested review from abhgupta and tkashem November 5, 2024 17:21

dinhxuanvu force-pushed the rebase-1.31 branch from 37d0128 to b4b65e6 Compare November 5, 2024 17:27

dinhxuanvu mentioned this pull request Nov 5, 2024

[WIP] WRKLDS-1554: bump openshift/api and bring in ObjectMeta for authorization and security types #444

Closed

dinhxuanvu force-pushed the rebase-1.31 branch from 0d62d7e to 8dda0b7 Compare November 6, 2024 08:59

dinhxuanvu changed the title ~~Rebase 1.31~~ API-1820: Rebase 1.31 Nov 6, 2024

openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 6, 2024

dinhxuanvu changed the title ~~API-1820: Rebase 1.31~~ API-1863: Rebase 1.31 Nov 6, 2024

chiragkyal mentioned this pull request Nov 7, 2024

OCPBUGS-34373: Bump library-go to fix routes/custom-host permission for externalCertificate #459

Merged

Bump k8s and libraries to 1.31.1

c9dedcc

Signed-off-by: Vu Dinh <vudinh@outlook.com>

dinhxuanvu force-pushed the rebase-1.31 branch from 667e84f to cd2704e Compare November 12, 2024 17:23

p0lyn0mial reviewed Nov 13, 2024

View reviewed changes

dinhxuanvu and others added 6 commits November 13, 2024 04:05

go mod vendor

d28134c

Signed-off-by: Vu Dinh <vudinh@outlook.com>

add ObjectMeta to authorization and security types

726c39b

- update missing genclient:skipVerbs to authorization types - add validation to require empty ObjectMeta

make update

c27efb5

Signed-off-by: Vu Dinh <vudinh@outlook.com>

Adapt to new changes

71a24d9

Signed-off-by: Vu Dinh <vudinh@outlook.com>

Add EffectiveVersion to config

498b05c

Signed-off-by: Vu Dinh <vudinh@outlook.com>

Add resourceQuota initializer

65ff9ae

Signed-off-by: Vu Dinh <vudinh@outlook.com>

dinhxuanvu force-pushed the rebase-1.31 branch from cd2704e to 65ff9ae Compare November 13, 2024 09:06

openshift-ci Bot assigned p0lyn0mial Nov 13, 2024

openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024

openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 13, 2024

openshift-merge-bot Bot merged commit 53c5b3a into openshift:master Nov 13, 2024

ardaguclu mentioned this pull request Nov 13, 2024

OCPBUGS-42532: Revert loosened policy test openshift/origin#29289

Merged

xingxingxia mentioned this pull request Nov 26, 2024

OCPQE-27132: Fix for PodSecurityXXXReview due to 4.18 APIs change openshift/verification-tests#3711

Merged

Conversation

dinhxuanvu commented Nov 5, 2024

Uh oh!

dinhxuanvu commented Nov 5, 2024

Uh oh!

openshift-ci-robot commented Nov 6, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openshift-ci-robot commented Nov 6, 2024 • edited by openshift-ci Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dinhxuanvu commented Nov 7, 2024

Uh oh!

dinhxuanvu commented Nov 7, 2024

Uh oh!

dinhxuanvu commented Nov 7, 2024

Uh oh!

dinhxuanvu commented Nov 9, 2024

Uh oh!

dinhxuanvu commented Nov 9, 2024

Uh oh!

dinhxuanvu commented Nov 12, 2024

Uh oh!

p0lyn0mial Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

dinhxuanvu Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

p0lyn0mial Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

Uh oh!

p0lyn0mial Nov 13, 2024

Choose a reason for hiding this comment

Uh oh!

p0lyn0mial commented Nov 13, 2024

Uh oh!

openshift-ci Bot commented Nov 13, 2024

Uh oh!

chiragkyal commented Nov 13, 2024

Uh oh!

openshift-ci Bot commented Nov 13, 2024

Uh oh!

openshift-bot commented Nov 14, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

openshift-ci-robot commented Nov 6, 2024 •

edited by openshift-ci Bot

Loading

openshift-ci-robot commented Nov 6, 2024 •

edited by openshift-ci Bot

Loading