Skip to content

OCPBUGS-42532: Revert loosened policy test#29289

Merged
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
ardaguclu:ocpbugs-42532
Nov 16, 2024
Merged

OCPBUGS-42532: Revert loosened policy test#29289
openshift-merge-bot[bot] merged 1 commit intoopenshift:masterfrom
ardaguclu:ocpbugs-42532

Conversation

@ardaguclu
Copy link
Copy Markdown
Member

Since openshift/openshift-apiserver#458 has merged, we can revert #29141

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Nov 13, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@ardaguclu: This pull request references Jira Issue OCPBUGS-42532, which is invalid:

  • expected the bug to target the "4.18.0" version, but no target version was set

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Since openshift/openshift-apiserver#458 has merged, we can revert #29141

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. label Nov 13, 2024
@ardaguclu
Copy link
Copy Markdown
Member Author

/cc @atiratree

@ardaguclu
Copy link
Copy Markdown
Member Author

/jira refresh

@openshift-ci-robot openshift-ci-robot added jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. and removed jira/invalid-bug Indicates that a referenced Jira bug is invalid for the branch this PR is targeting. labels Nov 13, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@ardaguclu: This pull request references Jira Issue OCPBUGS-42532, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

Details

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci Bot requested a review from zhouying7780 November 13, 2024 17:25
@ardaguclu
Copy link
Copy Markdown
Member Author

/cc @stbenjam
as the approver of the previous PR

@openshift-ci openshift-ci Bot requested a review from stbenjam November 13, 2024 17:25
@atiratree
Copy link
Copy Markdown
Member

/lgtm
@ardaguclu btw, it is better to use git revert for posterity

@openshift-ci openshift-ci Bot added the lgtm Indicates that a PR is ready to be merged. label Nov 13, 2024
@ardaguclu
Copy link
Copy Markdown
Member Author

/lgtm @ardaguclu btw, it is better to use git revert for posterity

You are right, that would be better. Next time, I'll use it :) and thanks for tagging.

@ardaguclu
Copy link
Copy Markdown
Member Author

/test e2e-agnostic-ovn-cmd

@ardaguclu
Copy link
Copy Markdown
Member Author

No failure of the enabled tests, but anyway it is better to retest one more time;
/retest

@zhouying7780
Copy link
Copy Markdown
Contributor

/label qe-approved

@openshift-ci openshift-ci Bot added the qe-approved Signifies that QE has signed off on this PR label Nov 14, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@ardaguclu: This pull request references Jira Issue OCPBUGS-42532, which is valid.

3 validation(s) were run on this bug
  • bug is open, matching expected state (open)
  • bug target version (4.18.0) matches configured target version for branch (4.18.0)
  • bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact:
/cc @zhouying7780

Details

In response to this:

Since openshift/openshift-apiserver#458 has merged, we can revert #29141

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@zhouying7780
Copy link
Copy Markdown
Contributor

/label cherry-pick-approved

@openshift-ci openshift-ci Bot added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Nov 14, 2024
@zhouying7780
Copy link
Copy Markdown
Contributor

/cherry-pick-approved cancel

@dgoodwin
Copy link
Copy Markdown
Contributor

/lgtm

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ardaguclu, atiratree, dgoodwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 14, 2024
@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 3fd5f62 and 2 for PR HEAD 27068ba in total

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD d86ecc9 and 2 for PR HEAD 27068ba in total

@openshift-trt-bot
Copy link
Copy Markdown

Job Failure Risk Analysis for sha: 27068ba

Job Name Failure Risk
pull-ci-openshift-origin-master-e2e-aws-ovn-serial Medium
[bz-kube-apiserver][invariant] alert/KubeAPIErrorBudgetBurn should not be at or above info
This test has passed 96.36% of 55 runs on jobs ['periodic-ci-openshift-release-master-ci-4.18-e2e-aws-ovn-serial' 'periodic-ci-openshift-release-master-nightly-4.18-e2e-aws-ovn-serial'] in the last 14 days.

Open Bugs
SNO error rate for alert/KubeAPIErrorBudgetBurn should not be at or above info

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 90f6954 and 1 for PR HEAD 27068ba in total

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Nov 15, 2024

@ardaguclu: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-kube-apiserver-rollout 27068ba link false /test e2e-aws-ovn-kube-apiserver-rollout
ci/prow/okd-scos-e2e-aws-ovn 27068ba link false /test okd-scos-e2e-aws-ovn
ci/prow/e2e-aws-ovn-single-node-upgrade 27068ba link false /test e2e-aws-ovn-single-node-upgrade

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD 92addf5 and 0 for PR HEAD 27068ba in total

@openshift-ci-robot
Copy link
Copy Markdown

/retest-required

Remaining retests: 0 against base HEAD f355db7 and 2 for PR HEAD 27068ba in total

@openshift-merge-bot openshift-merge-bot Bot merged commit 2ae2adf into openshift:master Nov 16, 2024
@openshift-ci-robot
Copy link
Copy Markdown

@ardaguclu: Jira Issue OCPBUGS-42532: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-42532 has been moved to the MODIFIED state.

Details

In response to this:

Since openshift/openshift-apiserver#458 has merged, we can revert #29141

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@ardaguclu ardaguclu deleted the ocpbugs-42532 branch November 16, 2024 01:32
@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.18.0-202411160307.p0.g2ae2adf.assembly.stream.el9.
All builds following this will include this PR.

@openshift-bot
Copy link
Copy Markdown
Contributor

[ART PR BUILD NOTIFIER]

Distgit: openshift-enterprise-tests
This PR has been included in build openshift-enterprise-tests-container-v4.19.0-202411160307.p0.g2ae2adf.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. jira/valid-bug Indicates that a referenced Jira bug is valid for the branch this PR is targeting. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged. qe-approved Signifies that QE has signed off on this PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants