OCPBUGS-52193: legacy image pull secret rollback controller #380
Conversation
sanchezl
changed the title
openshift-ci
bot
added
the
approved
sanchezl
changed the title
openshift-ci-robot
added
jira/valid-reference
|
@sanchezl: This pull request references Jira Issue OCPBUGS-52193, which is valid. 3 validation(s) were run on this bug
No GitHub users were found matching the public email listed for the QA contact in Jira (jitsingh@redhat.com), skipping review request. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
| kc, | ||
| ctx.KubernetesInformers.Core().V1().Secrets(), | ||
| ).Run(ctx.Context, 1) | ||
|
|
There was a problem hiding this comment.
What is up with this RunServiceAccountPullSecretsController function ? Is it used anywhere ?
There was a problem hiding this comment.
Dead code. I need to clean it up, but wanted to limit this PR to the issue at hand.
There was a problem hiding this comment.
Hi, I've actually just opened #381 , so we can get that merged if that is ok.
|
/retest |
|
/retest |
|
@sanchezl: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ricardomaraschini, sanchezl The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-bot
bot
merged commit ed71ab5
into
openshift:master
|
@sanchezl: Jira Issue OCPBUGS-52193: All pull requests linked via external trackers have merged: Jira Issue OCPBUGS-52193 has been moved to the MODIFIED state. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
[ART PR BUILD NOTIFIER] Distgit: ose-openshift-controller-manager |
|
/cherry-pick release-4.19 |
|
@sanchezl: new pull request created: #384 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
6 participants
openshift.io/serviceaccount-pull-secrets-rollbackcontroller set which runs when theopenshift.io/serviceaccount-pull-secretscontroller set is disabled.legacyImagePullSecretRollbackControllerto theopenshift.io/serviceaccount-pull-secretscontroller set.