Skip to content

Conversation

@tchap
Copy link
Contributor

@tchap tchap commented May 11, 2025

Once the unused function RunServiceAccountPullSecretsController
is removed and a few constants pulled out of the package,
it is actually unused and can be deleted.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 11, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 11, 2025

@tchap: This pull request references WRKLDS-1676 which is a valid jira issue.

Details

In response to this:

Once the unused function RunServiceAccountPullSecretsController
is removed and a few constants pulled out of the package,
it is actually unused and can be deleted.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tchap added 2 commits May 27, 2025 15:18
Once the unused function RunServiceAccountPullSecretsController
is removed and a few constants pulled out of the package,
it is actually unused and can be deleted.
@tchap tchap force-pushed the delete-pkg-serviceaccounts branch from 57642b6 to a61473f Compare May 27, 2025 13:19
Copy link
Contributor

@sanchezl sanchezl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 27, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 27, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sanchezl, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 7360d9f into openshift:master May 27, 2025
12 of 14 checks passed
@openshift-bot
Copy link
Contributor

[ART PR BUILD NOTIFIER]

Distgit: ose-openshift-controller-manager
This PR has been included in build ose-openshift-controller-manager-container-v4.20.0-202505271846.p0.g7360d9f.assembly.stream.el9.
All builds following this will include this PR.

@tchap tchap deleted the delete-pkg-serviceaccounts branch September 3, 2025 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants