-
Notifications
You must be signed in to change notification settings - Fork 96
WRKLDS-1676: Delete unused pkg/serviceaccounts #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WRKLDS-1676: Delete unused pkg/serviceaccounts #381
Conversation
|
@tchap: This pull request references WRKLDS-1676 which is a valid jira issue. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
a5e65da to
57642b6
Compare
Once the unused function RunServiceAccountPullSecretsController is removed and a few constants pulled out of the package, it is actually unused and can be deleted.
57642b6 to
a61473f
Compare
sanchezl
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: sanchezl, tchap The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7360d9f
into
openshift:master
|
[ART PR BUILD NOTIFIER] Distgit: ose-openshift-controller-manager |
Once the unused function RunServiceAccountPullSecretsController
is removed and a few constants pulled out of the package,
it is actually unused and can be deleted.