Skip to content

WRKLDS-1676: cmd: Refactor to use NewControllerCommand #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 2 commits into from
Jun 16, 2025
Merged

WRKLDS-1676: cmd: Refactor to use NewControllerCommand #378

openshift-merge-bot merged 2 commits into from
Jun 16, 2025

Conversation

@tchap
Copy link
Contributor

@tchap tchap commented May 5, 2025 •
edited
Loading

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 5, 2025 •
edited by openshift-ci bot
Loading

@tchap: This pull request references WRKLDS-1676 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the sub-task to target the "4.20.0" version, but no target version was set.

Details

In response to this:

Use controllercmd package from library-go.

https://issues.redhat.com/browse/WRKLDS-1676

This is a WIP. library-go needs to be extended to allow setting a custom resource lock name.

/hold

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 5, 2025
@openshift-ci openshift-ci bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels May 5, 2025
tchap
tchap commented May 5, 2025
View reviewed changes
@openshift-ci openshift-ci bot requested review from sanchezl and sayan-biswas May 5, 2025 15:00
@tchap tchap force-pushed the controller-command-config-library-go branch from 6f05ae7 to 42b46a7 Compare May 5, 2025 15:03
tchap
tchap commented May 5, 2025
View reviewed changes
@tchap tchap changed the title WIP: WRKLDS-1676: cmd: Refactor to use NewControllerCommand WRKLDS-1676: cmd: Refactor to use NewControllerCommand May 5, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2025
@tchap tchap changed the title WRKLDS-1676: cmd: Refactor to use NewControllerCommand WIP: WRKLDS-1676: cmd: Refactor to use NewControllerCommand May 5, 2025
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 5, 2025
@tchap tchap force-pushed the controller-command-config-library-go branch 2 times, most recently from 78c9764 to dad0369 Compare May 6, 2025 14:46
tchap
tchap commented May 6, 2025
View reviewed changes
@tchap tchap mentioned this pull request May 6, 2025
Merged
atiratree
atiratree reviewed May 6, 2025
View reviewed changes
@tchap tchap force-pushed the controller-command-config-library-go branch 2 times, most recently from 22a215f to b1c10ff Compare May 7, 2025 06:15
atiratree
atiratree reviewed May 7, 2025
View reviewed changes
@tchap tchap mentioned this pull request May 9, 2025
Merged
@tchap tchap force-pushed the controller-command-config-library-go branch from b1c10ff to 071c85c Compare May 10, 2025 17:12
@tchap tchap changed the title WIP: WRKLDS-1676: cmd: Refactor to use NewControllerCommand WRKLDS-1676: cmd: Refactor to use NewControllerCommand May 10, 2025
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 10, 2025
@tchap tchap force-pushed the controller-command-config-library-go branch 2 times, most recently from 173eee3 to 28655e6 Compare May 10, 2025 18:29
@tchap
Copy link
Contributor Author

tchap commented May 11, 2025

The failing security test is actually fixed once #381 is merged.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 11, 2025 •
edited by openshift-ci bot
Loading

@tchap: This pull request references WRKLDS-1676 which is a valid jira issue.

Details

In response to this:

Use controllercmd package from library-go.

https://issues.redhat.com/browse/WRKLDS-1676

This is a WIP. library-go needs to be extended to allow setting a custom resource lock name.

/hold

Dependencies:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 11, 2025 •
edited by openshift-ci bot
Loading

@tchap: This pull request references WRKLDS-1676 which is a valid jira issue.

Details

In response to this:

Use controllercmd package from library-go.

https://issues.redhat.com/browse/WRKLDS-1676

This is a WIP. library-go needs to be extended to allow setting a custom resource lock name.

/hold

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2025
@tchap tchap mentioned this pull request May 29, 2025
Merged
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 29, 2025 •
edited by openshift-ci bot
Loading

@tchap: This pull request references WRKLDS-1676 which is a valid jira issue.

Details

In response to this:

Use controllercmd package from library-go.

https://issues.redhat.com/browse/WRKLDS-1676

/hold

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tchap tchap force-pushed the controller-command-config-library-go branch from 9448355 to 00a505e Compare May 29, 2025 06:11
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 29, 2025
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 29, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 3, 2025 •
edited by openshift-ci bot
Loading

@tchap: This pull request references WRKLDS-1676 which is a valid jira issue.

Details

In response to this:

Use controllercmd package from library-go.

https://issues.redhat.com/browse/WRKLDS-1676

/hold

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tchap
Copy link
Contributor Author

tchap commented Jun 3, 2025

/retest-required

@tchap
Copy link
Contributor Author

tchap commented Jun 3, 2025

All tests seem to pass now.

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2025
@tchap
Copy link
Contributor Author

tchap commented Jun 3, 2025

We actually still need to think about unifying the multiple ways kube clients are being configured.

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 3, 2025
@tchap tchap force-pushed the controller-command-config-library-go branch from 00a505e to 9da3fbe Compare June 4, 2025 15:02
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 11, 2025 •
edited by openshift-ci bot
Loading

@tchap: This pull request references WRKLDS-1676 which is a valid jira issue.

Details

In response to this:

Use controllercmd package from library-go.

https://issues.redhat.com/browse/WRKLDS-1676

/hold

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

tchap added 2 commits June 13, 2025 11:05
@tchap
cmd: Refactor to use NewControllerCommand
c6ef409 
Use controllercmd package from library-go.
@tchap
go mod vendor
1da3ef8
@tchap tchap force-pushed the controller-command-config-library-go branch from 9da3fbe to 1da3ef8 Compare June 13, 2025 09:05
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented Jun 13, 2025 •
edited by openshift-ci bot
Loading

@tchap: This pull request references WRKLDS-1676 which is a valid jira issue.

Details

In response to this:

Use controllercmd package from library-go.

https://issues.redhat.com/browse/WRKLDS-1676

/hold

Dependencies

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@tchap
Copy link
Contributor Author

tchap commented Jun 13, 2025

This is ready as far as I can tell.

/unhold

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 13, 2025

@tchap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 1da3ef8 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@atiratree
Copy link
Member

atiratree commented Jun 16, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 16, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented Jun 16, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, sanchezl, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2025
@openshift-merge-bot openshift-merge-bot bot merged commit 42665fb into openshift:master Jun 16, 2025
13 of 14 checks passed
@tchap tchap deleted the controller-command-config-library-go branch June 16, 2025 21:48
@openshift-bot
Copy link
Contributor

openshift-bot commented Jun 16, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-openshift-controller-manager
This PR has been included in build ose-openshift-controller-manager-container-v4.20.0-202506162212.p0.g42665fb.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sayan-biswas sayan-biswas Awaiting requested review from sayan-biswas

2 more reviewers

@atiratree atiratree atiratree left review comments

@sanchezl sanchezl sanchezl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@atiratree atiratree

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@tchap @openshift-ci-robot @atiratree @openshift-bot @sanchezl @openshift-merge-robot