Skip to content

WRKLDS-1676: pkg/cmd: Add --kubeconfig and --namespace flag #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
openshift-merge-bot merged 1 commit into from
May 28, 2025
Merged

WRKLDS-1676: pkg/cmd: Add --kubeconfig and --namespace flag #385

openshift-merge-bot merged 1 commit into from
May 28, 2025

Conversation

@tchap
Copy link
Contributor

@tchap tchap commented May 28, 2025 •
edited
Loading

This is needed as a temporary solution to be able to align
Hypershift OCM configuration for future compatibility with library-go.

The flags are currently being ignored.

This is going to be followed by applying openshift/hypershift@main...tchap:hypershift:ocm-kubeconfig

Blocking #378

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label May 28, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 28, 2025 •
edited by openshift-ci bot
Loading

@tchap: This pull request references WRKLDS-1676 which is a valid jira issue.

Details

In response to this:

This is needed as a temporary solution to be able to align Hypershift OCM configuration for future compatibility with library-go.

Blocking #378

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from Moebasim and sayan-biswas May 28, 2025 12:36
atiratree
atiratree reviewed May 28, 2025
View reviewed changes
@tchap tchap force-pushed the kubeconfig-flag branch 2 times, most recently from b87f93f to e57f1ed Compare May 28, 2025 12:48
@tchap tchap changed the title WRKLDS-1676: pkg/cmd: Add --kubeconfig flag, which is ignored WRKLDS-1676: pkg/cmd: Add --kubeconfig and --namespace flag May 28, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 28, 2025 •
edited by openshift-ci bot
Loading

@tchap: This pull request references WRKLDS-1676 which is a valid jira issue.

Details

In response to this:

This is needed as a temporary solution to be able to align
Hypershift OCM configuration for future compatibility with library-go.

The flags are currently being ignored.

Blocking #378

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@atiratree
Copy link
Member

atiratree commented May 28, 2025

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
@openshift-ci-robot
Copy link
Contributor

openshift-ci-robot commented May 28, 2025 •
edited by openshift-ci bot
Loading

@tchap: This pull request references WRKLDS-1676 which is a valid jira issue.

Details

In response to this:

This is needed as a temporary solution to be able to align
Hypershift OCM configuration for future compatibility with library-go.

The flags are currently being ignored.

This is going to be followed by applying openshift/hypershift@main...tchap:hypershift:ocm-kubeconfig

Blocking #378

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

sanchezl
sanchezl suggested changes May 28, 2025
View reviewed changes
@tchap
pkg/cmd: Add --kubeconfig and --namespace flag
817407c 
This is needed as a temporary solution to be able to align
Hypershift OCM configuration for future compatibility with library-go.

The flags are currently being ignored.
@tchap tchap force-pushed the kubeconfig-flag branch from e57f1ed to 817407c Compare May 28, 2025 15:16
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
sanchezl
sanchezl approved these changes May 28, 2025
View reviewed changes
Copy link
Contributor

@sanchezl sanchezl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 28, 2025
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 28, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atiratree, sanchezl, tchap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 28, 2025
@tchap tchap mentioned this pull request May 28, 2025
Merged
6 tasks
@openshift-merge-bot openshift-merge-bot bot merged commit 597799c into openshift:master May 28, 2025
12 of 14 checks passed
@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 28, 2025

@tchap: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-aws-ovn-proxy 817407c link false /test e2e-aws-ovn-proxy

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@tchap tchap deleted the kubeconfig-flag branch May 28, 2025 21:39
@openshift-bot
Copy link
Contributor

openshift-bot commented May 28, 2025

[ART PR BUILD NOTIFIER]

Distgit: ose-openshift-controller-manager
This PR has been included in build ose-openshift-controller-manager-container-v4.20.0-202505282215.p0.g597799c.assembly.stream.el9.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Moebasim Moebasim Awaiting requested review from Moebasim

@sayan-biswas sayan-biswas Awaiting requested review from sayan-biswas

2 more reviewers

@atiratree atiratree atiratree left review comments

@sanchezl sanchezl sanchezl approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@atiratree atiratree

@sanchezl sanchezl

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@tchap @openshift-ci-robot @atiratree @openshift-bot @sanchezl