-
Notifications
You must be signed in to change notification settings - Fork 96
Bug 1755140: add build ca bundle to init containers #46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@gabemontero: This pull request references Bugzilla bug 1755140, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
Hmmm ... CI's image registry is not happy: |
|
/retest |
|
/hold trying to verify locally |
|
/hold cancel verified locally ... ocm/builder combo works with image src injection !! |
|
@gabemontero builds should be unblocked now, ping me if that's not the case. |
adambkaplan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, gabemontero The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/cherrypick release-4.2 |
|
@adambkaplan: once the present PR merges, I will cherry-pick it on top of release-4.2 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/cherrypick release-4.1 |
|
@adambkaplan: once the present PR merges, I will cherry-pick it on top of release-4.1 in a new PR and assign it to you. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/retest |
|
@adambkaplan: new pull request created: #47 DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@adambkaplan: cannot checkout release-4.1: error checking out release-4.1: exit status 1. output: error: pathspec 'release-4.1' did not match any file(s) known to git. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
@gabemontero forgot that in 4.2 ocm got moved to its own repo. We'll have to pick this by hand to 4.1 in origin. |
|
4.1 openshift/origin PR openshift/origin#24130 is the hand pick @adambkaplan noted above |
manifests: add memory request to operator pod
/assign @adambkaplan
@openshift/openshift-team-developer-experience FYI