Skip to content

Conversation

@gabemontero
Copy link
Contributor

/assign @adambkaplan

@openshift/openshift-team-developer-experience FYI

@openshift-ci-robot
Copy link
Contributor

@gabemontero: This pull request references Bugzilla bug 1755140, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

Bug 1755140: add build ca bundle to init containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2019
@gabemontero
Copy link
Contributor Author

Hmmm ... CI's image registry is not happy: error: unable to extract layer sha256:d1d384fd6d0362866057f95d61efc198657980d2e86db8385a48b7cbdaeb0da9 from registry.svc.ci.openshift.org/ci-op-q1cp1s82/stable@sha256:406ba6a4ea2fba92c319b5a3383c2e60ecd97dff34ecebe87a77bd4a3488cf4d: stream error: stream ID 139; INTERNAL_ERROR

@gabemontero
Copy link
Contributor Author

/retest

@gabemontero
Copy link
Contributor Author

/hold

trying to verify locally

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2019
@gabemontero
Copy link
Contributor Author

/hold cancel

verified locally ... ocm/builder combo works with image src injection !!

@openshift-ci-robot openshift-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2019
@adambkaplan
Copy link
Contributor

@gabemontero builds should be unblocked now, ping me if that's not the case.

Copy link
Contributor

@adambkaplan adambkaplan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 7, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 7, 2019
@adambkaplan
Copy link
Contributor

/cherrypick release-4.2

@openshift-cherrypick-robot

@adambkaplan: once the present PR merges, I will cherry-pick it on top of release-4.2 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan
Copy link
Contributor

/cherrypick release-4.1

@openshift-cherrypick-robot

@adambkaplan: once the present PR merges, I will cherry-pick it on top of release-4.1 in a new PR and assign it to you.

Details

In response to this:

/cherrypick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan
Copy link
Contributor

/retest

@openshift-merge-robot openshift-merge-robot merged commit 19ee883 into openshift:master Nov 7, 2019
@openshift-cherrypick-robot

@adambkaplan: new pull request created: #47

Details

In response to this:

/cherrypick release-4.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-cherrypick-robot

@adambkaplan: cannot checkout release-4.1: error checking out release-4.1: exit status 1. output: error: pathspec 'release-4.1' did not match any file(s) known to git.

Details

In response to this:

/cherrypick release-4.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero deleted the tls-verify branch November 7, 2019 21:21
@adambkaplan
Copy link
Contributor

@gabemontero forgot that in 4.2 ocm got moved to its own repo. We'll have to pick this by hand to 4.1 in origin.

@gabemontero
Copy link
Contributor Author

4.1 openshift/origin PR openshift/origin#24130 is the hand pick @adambkaplan noted above

stlaz pushed a commit to stlaz/openshift-controller-manager that referenced this pull request Jul 29, 2021
manifests: add memory request to operator pod
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants