Bug 1754681: add build ca bundle to init containers #24130

gabemontero · 2019-11-11T19:59:55Z

manual pick of openshift/openshift-controller-manager#46 into 4.1 since in 4.1 the code lived in openshift/origin but in 4.2 it was moved to openshift/openshift-controller-manager

openshift-ci-robot · 2019-11-11T19:59:59Z

@gabemontero: This pull request references Bugzilla bug 1771053, which is invalid:

expected dependent Bugzilla bug 1754680 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1755140 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is MODIFIED instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1771053: add build ca bundle to init containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2019-11-11T20:33:27Z

unit test were k8s flakes

verify was a gofmt

gabemontero · 2019-11-12T14:30:20Z

apparent flakes and some ruby 22 stuff

/retest

gabemontero · 2019-11-12T18:27:10Z

the cmd, e2e-aws-builds, and integration failures all need @adambkaplan 's #24111 for 4.1

the unit test failures however seem to be unrelated hard/consistent errors ... among other things, I'm seeing the same vsphere failures in both this PR and @adambkaplan 's PR that I just noted with this comment

/test unit

gabemontero · 2019-11-13T23:42:14Z

/test unit

openshift-ci-robot · 2019-11-14T14:56:01Z

@gabemontero: This pull request references Bugzilla bug 1754681, which is invalid:

expected dependent Bugzilla bug 1754680 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ASSIGNED instead
expected dependent Bugzilla bug 1755140 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

Bug 1754681: add build ca bundle to init containers

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2019-11-18T13:59:27Z

/retest

eparis · 2019-11-20T17:05:28Z

/retest

gabemontero · 2019-11-20T17:38:18Z

@eparis we are minimally going to need #24111 before tests pass in this PR

adambkaplan · 2019-11-20T18:46:08Z

@gabemontero #24176 has the requisite fixes and has merged.

gabemontero · 2019-11-20T18:52:38Z

cool thanks @adambkaplan

and look at that some of the failing tests are green again :-)

adambkaplan

/lgtm

openshift-ci-robot · 2019-11-20T20:07:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, gabemontero

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/build/OWNERS~~ [adambkaplan]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

gabemontero · 2019-11-20T20:26:01Z

/bugzilla refresh

openshift-ci-robot · 2019-11-20T20:26:05Z

@gabemontero: This pull request references Bugzilla bug 1754681, which is invalid:

expected dependent Bugzilla bug 1754680 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is POST instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2019-12-03T15:01:01Z

/bugzilla refresh

openshift-ci-robot · 2019-12-03T15:01:13Z

@gabemontero: This pull request references Bugzilla bug 1754681, which is valid. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

gabemontero · 2019-12-03T15:01:41Z

bump @adambkaplan we now have valid bugzilla

openshift-ci-robot assigned adambkaplan Nov 11, 2019

openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Nov 11, 2019

openshift-ci-robot requested review from csrwng and smarterclayton November 11, 2019 20:00

gabemontero mentioned this pull request Nov 11, 2019

Bug 1755140: add build ca bundle to init containers openshift/openshift-controller-manager#46

Merged

add build ca bundle to init containers

4c34be8

gabemontero force-pushed the build-tls-verify-41 branch from 2200f46 to 4c34be8 Compare November 11, 2019 20:35

gabemontero changed the title ~~Bug 1771053: add build ca bundle to init containers~~ Bug 1754681: add build ca bundle to init containers Nov 14, 2019

gabemontero mentioned this pull request Nov 18, 2019

[release-4.1] Bug 1754681: do not force skip tls verify to true on image source injection openshift/builder#112

Merged

adambkaplan approved these changes Nov 20, 2019

View reviewed changes

openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2019

openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 20, 2019

openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Dec 3, 2019

shawn-hurley added the cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. label Dec 6, 2019

openshift-merge-robot merged commit aceddcc into openshift:release-4.1 Dec 6, 2019

gabemontero deleted the build-tls-verify-41 branch December 6, 2019 18:35

Bug 1754681: add build ca bundle to init containers #24130

Bug 1754681: add build ca bundle to init containers #24130

Uh oh!

Conversation

gabemontero commented Nov 11, 2019

Uh oh!

openshift-ci-robot commented Nov 11, 2019

Uh oh!

gabemontero commented Nov 11, 2019

Uh oh!

gabemontero commented Nov 12, 2019

Uh oh!

gabemontero commented Nov 12, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gabemontero commented Nov 13, 2019

Uh oh!

openshift-ci-robot commented Nov 14, 2019

Uh oh!

gabemontero commented Nov 18, 2019

Uh oh!

eparis commented Nov 20, 2019

Uh oh!

gabemontero commented Nov 20, 2019

Uh oh!

adambkaplan commented Nov 20, 2019

Uh oh!

gabemontero commented Nov 20, 2019

Uh oh!

adambkaplan left a comment

Choose a reason for hiding this comment

Uh oh!

openshift-ci-robot commented Nov 20, 2019

Uh oh!

gabemontero commented Nov 20, 2019

Uh oh!

openshift-ci-robot commented Nov 20, 2019

Uh oh!

gabemontero commented Dec 3, 2019

Uh oh!

openshift-ci-robot commented Dec 3, 2019

Uh oh!

gabemontero commented Dec 3, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

gabemontero commented Nov 12, 2019 •

edited

Loading