Bug 1769951: [4.1.z] Fix origin tests #24176
Conversation
Update build, cmd, and integration tests to use centos/ruby-25-centos7 image
* Skip test-util suite in test-cmd * Remove named ports in cmd and unit tests
|
@adambkaplan: No Bugzilla bug is referenced in the title of this pull request. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
size/L
adambkaplan
changed the title
|
@adambkaplan: This pull request references Bugzilla bug 1769951, which is valid. The bug has been updated to refer to the pull request using the external bug tracker. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
openshift-ci-robot
added
the
bugzilla/valid-bug
Makefile
Outdated
| # make test-cmd | ||
| test-cmd: build | ||
| hack/test-util.sh | ||
| # hack/test-util.sh |
There was a problem hiding this comment.
Is this intentional? If so, what about deleting the line instead?
There was a problem hiding this comment.
Yes - this is intentional. TBH I did not have time to dig into why these tests were failing - it seemed that the suite itself is a "test of the tests" and has dependencies which no longer exist in the container running the tests.
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: adambkaplan, eparis The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
|
/retest Please review the full test history for this PR and help us cut down flakes. |
eparis
added
the
cherry-pick-approved
|
I'm applying cherrypick approved, hopefully it will mean tomorrow when 4.1 opens stuff can actually merge. |
7 participants
Cleaned up from #24111 - should get 4.1.z tests back to green.