Skip to content

[release-4.1] WIP: Bug 1769951: Get 4.1.z tests working again #24111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
adambkaplan wants to merge 9 commits into from
Closed

[release-4.1] WIP: Bug 1769951: Get 4.1.z tests working again #24111

adambkaplan wants to merge 9 commits into from

Conversation

@adambkaplan
Copy link
Contributor

@adambkaplan adambkaplan commented Nov 7, 2019

Update to use centos/ruby-25-centos7 image

@adambkaplan
[release-4.1] React to openshift/ruby-hello-world changes
8943fac 
Update to use centos/ruby-25-centos7 image
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 7, 2019

@adambkaplan: This pull request references Bugzilla bug 1769951, which is invalid:

  • expected dependent Bugzilla bug 1769949 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead
  • expected dependent Bugzilla bug 1769950 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is NEW instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

[release-4.1] Bug 1769951: React to openshift/ruby-hello-world changes

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@openshift-ci-robot openshift-ci-robot added bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 7, 2019
@bparees
Copy link
Contributor

bparees commented Nov 7, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added lgtm Indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Nov 7, 2019
@ironcladlou
Copy link
Contributor

ironcladlou commented Nov 7, 2019

/unassign @ironcladlou

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Nov 8, 2019

/retest

@stlaz stlaz mentioned this pull request Nov 12, 2019
Merged
@gabemontero gabemontero mentioned this pull request Nov 12, 2019
Merged
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 13, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

openshift-bot commented Nov 14, 2019

/retest

Please review the full test history for this PR and help us cut down flakes.

@bparees
Copy link
Contributor

bparees commented Nov 14, 2019

/hold

this has never passed, please investigate the failure before unholding.

@openshift-ci-robot openshift-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2019
@stlaz
Copy link
Contributor

stlaz commented Nov 14, 2019

@adambkaplan since you're fixing tests in this PR, please also include the unittest fixes from #24124 - Golang 1.11 fixed a vulnerability which requires ports to be a valid integer.

It's yet to be found what's wrong with the cmd tests, or I am not aware of any PR fixing them yet

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Nov 14, 2019
@adambkaplan adambkaplan changed the title [release-4.1] Bug 1769951: React to openshift/ruby-hello-world changes [release-4.1] WIP: Bug 1769951: React to openshift/ruby-hello-world changes Nov 14, 2019
@adambkaplan
Copy link
Contributor Author

adambkaplan commented Nov 15, 2019

@soltysh test-cmd is still very broken, and it's failing on tests that frankly don't feel relevant. Do we just drop those?

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Nov 18, 2019

/bugzilla refresh

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 18, 2019

@adambkaplan: This pull request references Bugzilla bug 1769951, which is invalid:

  • expected dependent Bugzilla bug 1769950 to be in one of the following states: VERIFIED, RELEASE_PENDING, CLOSED (ERRATA), but it is ON_QA instead

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@gabemontero gabemontero mentioned this pull request Nov 18, 2019
Merged
@adambkaplan adambkaplan mentioned this pull request Nov 19, 2019
Merged
@adambkaplan
Copy link
Contributor Author

adambkaplan commented Nov 19, 2019

/retest

@adambkaplan adambkaplan changed the title [release-4.1] WIP: Bug 1769951: React to openshift/ruby-hello-world changes [release-4.1] WIP: Bug 1769951: Get 4.1.z tests working again Nov 19, 2019
@adambkaplan
Copy link
Contributor Author

adambkaplan commented Nov 19, 2019

/test unit

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Nov 19, 2019

/retest

@soltysh
Copy link
Contributor

soltysh commented Nov 19, 2019

/bugzilla refresh

@openshift-ci-robot openshift-ci-robot added bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. and removed bugzilla/invalid-bug Indicates that a referenced Bugzilla bug is invalid for the branch this PR is targeting. labels Nov 19, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 19, 2019

@soltysh: This pull request references Bugzilla bug 1769951, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

Details

In response to this:

/bugzilla refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@adambkaplan adambkaplan mentioned this pull request Nov 20, 2019
Merged
@mfojtik
Copy link
Contributor

mfojtik commented Nov 20, 2019

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Nov 20, 2019
@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2019

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adambkaplan, bparees, mfojtik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@eparis
Copy link
Member

eparis commented Nov 20, 2019

this should be closed after #24176 merged, right?

@adambkaplan
Copy link
Contributor Author

adambkaplan commented Nov 20, 2019

/close

Replaced by #24176

@openshift-ci-robot
Copy link

openshift-ci-robot commented Nov 20, 2019

@adambkaplan: Closed this PR.

Details

In response to this:

/close

Replaced by #24176

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bparees bparees Awaiting requested review from bparees

@ironcladlou ironcladlou Awaiting requested review from ironcladlou

Assignees

@mfojtik mfojtik

@bparees bparees

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. bugzilla/valid-bug Indicates that a referenced Bugzilla bug is valid for the branch this PR is targeting. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

@adambkaplan @openshift-ci-robot @bparees @ironcladlou @openshift-bot @stlaz @soltysh @mfojtik @eparis